Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469955 --- Comment #2 from Bastien Nocera <bnocera(a)redhat.com&gt; 2008-11-18 14:03:33 EDT --- (In reply to comment #1) It's not stable/tested enough to replace pam_fprint. So I'm currently only conflicting with it. True, will fix. Yes and no. %{_sysconfdir}/fprintd.conf should be marked as %config, but it doesn't actually do anything useful yet, so it's better to just have it replaced for now. I should add a comment about it. That should be fixed, I updated libfprint in F11: http://koji.fedoraproject.org/koji/taskinfo?taskID=938201 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469955 Matthias Clasen <mclasen(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mclasen(a)redhat.com --- Comment #4 from Matthias Clasen <mclasen(a)redhat.com&gt; 2008-11-25 11:15:53 EDT --- Here is what rpmlint says on the rpms: fprintd.i386: W: non-conffile-in-etc /etc/fprintd.conf You said you wanted to make this conf ? fprintd.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/net.reactivated.Fprint.conf This is ignorable fprintd-devel.i386: W: summary-not-capitalized fprintd development documentation I always use a more-or-less standardized summary of "Development files for %{name}" for -devel packages. fprintd-devel.i386: W: invalid-license GFDLv1.1+ No + there, I think. printd-pam.i386: W: no-documentation Thats sad, but ignorable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469955 --- Comment #6 from Bastien Nocera <bnocera(a)redhat.com&gt; 2008-11-25 11:36:42 EDT --- (In reply to comment #4) No, I added a comment about it: # This file should be marked as config when it does something useful OK, will change. But the docs say: "Permission is granted to copy, distribute and/or modify this document under the terms of the GNU Free Documentation License, Version 1.1 or any later version [...]" I'll write a little something to go upstream and in the package. (In reply to comment #5) Yes, will fix. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469955 --- Comment #7 from Matthias Clasen <mclasen(a)redhat.com&gt; 2008-11-26 01:46:25 EDT --- two more informal comments on the spec before I run down the checklist: - I don't think the explicit Requires: PolicyKit is needed, library deps should take care of that - The Conflicts: pam_fprint should probably have a comment explaining your rationale from comment #2 rpmlint run: see above package name: ok spec file name: ok packaging guidelines: ok license: ok license field: not ok the license field says GPLv2+, and the source files say so too, but the license file is GPL3. What gives ? license file: ok spec file language: ok spec file legible: ok upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok shared libs: ok relocatable: ok directory ownership: not ok -devel should require gtk-doc, for /usr/share/gtk-doc/html -pam should require pam, for /lib/security duplicate files: ok permissions: not ok the %files sections for pam and devel need %defattr %clean: ok macro use: ok permissible content: ok large docs: ok %doc content: ok headers: ok static libs: ok pc files: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok file ownership: ok %install: ok utf8 filenames: ok summary: some small fixes left -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469955 Bastien Nocera <bnocera(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|474573 | --- Comment #8 from Bastien Nocera <bnocera(a)redhat.com&gt; 2008-12-04 10:09:49 EDT --- Fixed Require: %{name} = %{version}-%{release} Changed summary for devel files Added README for pam (In reply to comment #7) Removed I removed the Conflicts. The configuration is different, so I'll add some release notes. Fixed, it's supposed to be a GPLv2 COPYING file. Added. Already dragged in through library deps (PAM libs are in the pam package) Done. All done! http://hadess.fedorapeople.org/fprintd/fprintd.spec http://hadess.fedorapeople.org/fprintd/fprintd-0.1-3.git43fe72a2aa.fc10.s... Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=976118 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469955 Matthias Clasen <mclasen(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #9 from Matthias Clasen <mclasen(a)redhat.com&gt; 2008-12-04 12:18:55 EDT --- Looks fine now. Approved. Might be nice to add /usr/share/dbus/interfaces/net.reactivated.Fprint.xml at some point -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469955 Kevin Fenzi <kevin(a)tummy.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #11 from Kevin Fenzi <kevin(a)tummy.com&gt; 2008-12-05 00:10:42 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469955 Kevin Fenzi <kevin(a)tummy.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.