[Bug 454166] New: Review Request: griv - a gtk rivchat - package-review

[Bug 454166] New: Review Request: griv - a gtk rivchat

[Bug 457212] Review Request:...

[Bug 457546] New: Review Request:...

Red Hat Bugzilla

Saturday, 5 July 2008 Sat, 5 Jul '08

3:48 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/show_bug.cgi?id=454166 Summary: Review Request: griv - a gtk rivchat Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody(a)fedoraproject.org ReportedBy: cassmodiah(a)fedoraproject.org QAContact: extras-qa(a)fedoraproject.org CC: fedora-package-review@redhat.com,notting(a)redhat.com Spec URL: http://packages.cassmodiah.de/fedora/griv/griv.spec SRPM URL: http://packages.cassmodiah.de/fedora/griv/griv-0.1.9-1.fc9.src.rpm Description: griv is a gtk chat using a modified riv-protocol for a serverless communication in a network. In this version the autoaway will beactive. There is just one Problem, the standard-port 16127 is closed by default and has to be opened manually. This is my first package and I need a sponsor -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

Saturday, 5 July Sat, 5 Jul

4:08 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 wolfy(a)nobugconsulting.ro changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| | ------- Additional Comments From wolfy(a)nobugconsulting.ro 2008-07-05 17:08 EST ------- What's the reason for including perl and intltool as Requires ? rpmbuild picks libgtk-x11 as dependency so (without testing the program itself) I'd say that completely removing the Requires line is a good idea. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:08 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Red Hat Bugzilla

4:47 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

...

What's the reason for including perl and intltool as Requires?

I thougt Requires is a mandatory field new version: SPEC URL: http://packages.cassmodiah.de/fedora/griv/bug-454166/05.07-2343/griv.spec SRPM URL: http://packages.cassmodiah.de/fedora/griv/bug-454166/05.07-2343/griv-0.1.... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

Sunday, 6 July Sun, 6 Jul

3:39 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Red Hat Bugzilla

Tuesday, 8 July Tue, 8 Jul

2 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Red Hat Bugzilla

Wednesday, 9 July Wed, 9 Jul

12:15 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 cheekyboinc(a)foresightlinux.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cheekyboinc(a)foresightlinux.o | |rg ------- Additional Comments From cheekyboinc(a)foresightlinux.org 2008-07-09 13:15 EST ------- Manuel, are you willing to do a formal review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

Monday, 21 July Mon, 21 Jul

9:37 a.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody(a)fedoraproject.org |mtasaka(a)ioa.s.u-tokyo.ac.jp Status|NEW |ASSIGNED Flag| |fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10 a.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2008-07-21 11:00 EST ------- Created an attachment (id=312268) --> (https://bugzilla.redhat.com/attachment.cgi?id=312268&action=view) Patch to honor Fedora cflags correctly For 0.1.9-2: * License - License tag should be "GPLv3". * BuildRequires - Please don't write "perl-devel" as BuildRequies Instead please use module name virtual Provides the needed rpms Provide: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides * CFLAGS - Fedora specific compilation flags are not correctly passed yet: http://koji.fedoraproject.org/koji/getfile?taskID=729334&name=build.log (Parent task: http://koji.fedoraproject.org/koji/taskinfo?taskID=729331 ) Makefiles in the tarball is wrong. Please apply the patch attached and remove extra lines ------------------------------------------------------------- CFLAGS="${CFLAGS:-$RPM_OPT_FLAGS}" export CFLAGS ------------------------------------------------------------- ! Note These 2 lines should not be needed anyway. You can check what %configure actually does by $ rpm --eval %configure * icons - Please verify if installing a icon into %{_datadir}/icons/hicolor/22x22/apps is really needed. The same icon is already installed under %{_datadir}/pixmaps/. * Documents - Please add the following files to %doc. ------------------------------------------------------------- AUTHORS Changelog ------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:13 a.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 ------- Additional Comments From wolfy(a)nobugconsulting.ro 2008-07-21 11:13 EST ------- There are a couple of problems. The major one is that , according to the build log, the RPMOPT flags are not used: gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/ usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/freetype2 -MT conf.o -MD -MP -MF .deps/ conf.Tpo -c -o conf.o conf.c while, a few lines above (before %configure) we have: + CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' + export CFLAGS I've just come back from vacation and I do not have the time for a deeper check, but I suspect that the makefile needs a bit of love. Minor nitpicks - there is no need to delete the original desktop file from the tree - please use either RPMBUILDROOT or rpmbuildroot, but not both - the Icon tag in the desktop file should either use the full path to the icon or the icon name without extension ( see Packaging/Guidelines#desktop ) - Your idea to create a man page is excellent and once you settle on a final format of the file, I suggest to send it upstream for inclusion in their next release. However the current wording needs a bit of improvement. I am not a native English speaker either, so take the next lines with a grain of salt. I have included below a slightly modified text for the Description paragraph of the man page. Feel free to use it (or not): DESCRIPTION griv is a serverless lan chat program, with the protocol based on RivChat by Arkadiusz Kolacz (Wielebny K.) The specification is available at ......... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:31 a.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

...

There are a couple of problems. The major one is that , according to the build log, the RPMOPT flags are not used:

Would you check my comment?

...

Minor nitpicks - there is no need to delete the original desktop file from the tree

Why? Unless using "--delete-original", this is needed (if --vendor fedora is specified)

...

- please use either RPMBUILDROOT or rpmbuildroot, but not both

Where is it used? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:55 a.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

...

Would you check my comment?

I apologize, I have started the review quite early today but I have been interrupted by $RegularWork. Before I had the chance to come back to the review in order to end it, you have replied and assigned the bug to yourself.

...

Why? Unless using "--delete-original", this is needed (if --vendor fedora is

specified) Because either --delete-original in desktop-file-install or an exclude line in %files can be used

...

> - please use either RPMBUILDROOT or rpmbuildroot, but not both Where is it used?

desktop-file-install --vendor="fedora" \ --dir=$RPM_BUILD_ROOT%{_datadir}/applications \ %{buildroot}/%{_datadir}/applications/%{name}.desktop (obviously, in #8 I meant %buildroot not rpmbuildroot ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:13 a.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

...

>Why? Unless using "--delete-original", this is needed (if --vendor fedora is specified) Because either --delete-original in desktop-file-install or an exclude line in %files can be used

Well, slightly unrelated to this, however I usually recommend _not_ to use %exclude but to remove files explicitly unless avoided such cases like - Some complicated %files entry description like a situation in which some files in a same directories are packaged in different subpackages - .py{o,c} under %_bindir ... especially when including binaries (for this package, desktop file is a text file and --delete-original can be used here). For binaries, using %exclude makes debuginfo rpm larger unneededly (because splitted out part of binaries are included into debuginfo rpm even if they are %exclude'd). To avoid further issues I don't know, I recommend not to use %exclude.

...

>> - please use either RPMBUILDROOT or rpmbuildroot, but not both >Where is it used? desktop-file-install --vendor="fedora" \ --dir=$RPM_BUILD_ROOT%{_datadir}/applications \ %{buildroot}/%{_datadir}/applications/%{name}.desktop (obviously, in #8 I meant %buildroot not rpmbuildroot )

Ah, okay, sorry for not noticing this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

Tuesday, 29 July Tue, 29 Jul

1:34 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Red Hat Bugzilla

3:20 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Red Hat Bugzilla

Wednesday, 30 July Wed, 30 Jul

2:46 a.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| | ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2008-07-30 03:46 EST ------- Removing NEEDSPONSOR as I am sponsoring the submitter (bug 454208) Review will follow later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9:08 a.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2008-07-30 10:08 EST ------- Created an attachment (id=313000) --> (https://bugzilla.redhat.com/attachment.cgi?id=313000&action=view) Patch to suppress implicit function declaration warning For -3: * BR: perl-devel - Writing "BuildRequires: perl-devel" is not recommended on Fedora: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides For this package "BuildRequires: perl(XML::Parser)" is sufficient (and even this is redundant because perl(XML::Parser) is required by intltool) * sed -i "s|%{name}.png|%{name}|" - Fixing Icon entry on the desktop file after executing desktop-file-install leaves a warning like: --------------------------------------------------------------- 524 /builddir/rpmbuild/BUILDROOT/griv-0.1.9-3.fc10.i386/usr/share/applications/fedora-griv.desktop: warning: val ue "griv.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no exte nsion as described in the Icon Theme Specification if the value is not an absolute path --------------------------------------------------------------- Fix griv.desktop(.in) before desktop-file-install is called (generally modifying griv.desktop.in in %prep is preferred) ! Misc issue - Please consider to apply the patch attached to suppress implicit function declaration function warning. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12:19 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Red Hat Bugzilla

12:26 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 cassmodiah(a)fedoraproject.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #313014|application/octet-stream |text/plain mime type| | Attachment #313014|0 |1 is patch| | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12:27 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Red Hat Bugzilla

12:39 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

...

should i replace the sed command with the diff-patch above? eventually it would be easier, than handle it with sed.(In reply to comment #16)

Either will be okay. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3:20 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Red Hat Bugzilla

Thursday, 31 July Thu, 31 Jul

2:08 a.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 mtasaka(a)ioa.s.u-tokyo.ac.jp changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2008-07-31 03:08 EST ------- Okay, clean. ------------------------------------------------------------- This package (griv) is APPROVED by me ------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12:51 p.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 simon(a)w3sp.de changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? ------- Additional Comments From simon(a)w3sp.de 2008-07-31 13:51 EST ------- New Package CVS Request ======================= Package Name: griv Short Description: a gtk rivchat Owners: cassmodiah Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

Friday, 1 August Fri, 1 Aug

10:51 a.m.

New subject: [Bug 454166] Review Request: griv - a gtk rivchat

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: griv - a gtk rivchat https://bugzilla.redhat.com/show_bug.cgi?id=454166 kevin(a)tummy.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ ------- Additional Comments From kevin(a)tummy.com 2008-08-01 11:51 EST ------- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

5753

days inactive

5780

days old

package-review@lists.fedoraproject.org

Manage subscription

24 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Bug 454166] New: Review Request: griv - a gtk rivchat