https://bugzilla.redhat.com/show_bug.cgi?id=2057412
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
URL and Source0 are usable. Ok.
TODO: Remove a trailing slash from URL.
Source archive (SHA-512:
69a27de5576ccec1bd085c492a2d1160327215f74957e4c2e5a842093615f7ed7061d3f61922328d2993640d356d0f73e79b55430cf08ec77ce55e28ed357b7f)
is original. Ok.
Summary verified from lib/Authen/WebAuthn.pod. Ok.
TODO: Description is same as Summary. Not much helpful. Could you replace it
with a synopsis text from lib/Authen/WebAuthn.pod?
License verified from lib/Authen/WebAuthn/Test.pm, lib/Authen/WebAuthn.pod,
lib/Authen/WebAuthn.pm, Makefile.PL, LICENSE, and README. Ok.
I can see you intent to support EPEL7. Ok.
No XS code, noarch BuildArch is Ok.
FIX: Build-require coreutils (perl-Authen-WebAuthn.spec:49).
TODO: Remove a useless find command deleting empty directories.
ExtUtils::MakeMaker in any supported EPEL does not create them.
FIX: Build-require perl-interpreter (perl-Authen-WebAuthn.spec:30).
All tests pass. Ok.
$ rpmlint perl-Authen-WebAuthn.spec
../SRPMS/perl-Authen-WebAuthn-0.001-1.fc37.src.rpm
../RPMS/noarch/perl-Authen-WebAuthn-0.001-1.fc37.noarch.rpm
======================================== rpmlint session starts
=======================================
rpmlint: 2.2.0
configuration:
/usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
perl-Authen-WebAuthn.spec:20: W: comparison-operator-in-deptoken %{!?el7:>=
perl-Authen-WebAuthn.spec:20: W: comparison-operator-in-deptoken %{!?el7:>=
========= 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness;
has taken 0.4 s ========
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Authen-WebAuthn-0.001-1.fc37.noarch.rpm
drwxr-xr-x 2 root root 0 Apr 29 12:44
/usr/share/doc/perl-Authen-WebAuthn
-rw-r--r-- 1 root root 404 Feb 2 11:03
/usr/share/doc/perl-Authen-WebAuthn/README
-rw-r--r-- 1 root root 517 Feb 2 11:03
/usr/share/doc/perl-Authen-WebAuthn/README.md
drwxr-xr-x 2 root root 0 Apr 29 12:44
/usr/share/licenses/perl-Authen-WebAuthn
-rw-r--r-- 1 root root 18352 Feb 2 11:03
/usr/share/licenses/perl-Authen-WebAuthn/LICENSE
-rw-r--r-- 1 root root 1286 Apr 29 12:44
/usr/share/man/man3/Authen::WebAuthn.3pm.gz
-rw-r--r-- 1 root root 1289 Apr 29 12:44
/usr/share/man/man3/Authen::WebAuthn::Test.3pm.gz
drwxr-xr-x 2 root root 0 Apr 29 12:44
/usr/share/perl5/vendor_perl/Authen
drwxr-xr-x 2 root root 0 Apr 29 12:44
/usr/share/perl5/vendor_perl/Authen/WebAuthn
-rw-r--r-- 1 root root 32315 Feb 2 11:03
/usr/share/perl5/vendor_perl/Authen/WebAuthn.pm
-rw-r--r-- 1 root root 6826 Feb 2 11:03
/usr/share/perl5/vendor_perl/Authen/WebAuthn.pod
-rw-r--r-- 1 root root 8108 Feb 2 11:03
/usr/share/perl5/vendor_perl/Authen/WebAuthn/Test.pm
File permissions and layout are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-Authen-WebAuthn-0.001-1.fc37.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.34.1)
1 perl(Authen::WebAuthn)
1 perl(Carp)
1 perl(CBOR::XS)
1 perl(constant)
1 perl(Crypt::OpenSSL::X509)
1 perl(Crypt::PK::ECC)
1 perl(Crypt::PK::RSA)
1 perl(Digest::SHA)
1 perl(Hash::Merge::Simple)
1 perl(JSON)
1 perl(MIME::Base64)
1 perl(Mouse)
1 perl(strict)
1 perl(URI)
1 perl(utf8)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p
../RPMS/noarch/perl-Authen-WebAuthn-0.001-1.fc37.noarch.rpm | sort -f | uniq -c
1 perl(Authen::WebAuthn) = 0.001
1 perl(Authen::WebAuthn::Test) = 0.001
1 perl-Authen-WebAuthn = 0.001-1.fc37
Binary provides are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-Authen-WebAuthn-0.001-1.fc37.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Rawhide
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=86393020). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the FIX items and consider fixing the TODO items before building
this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2057412