https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Bug ID: 1093500 Summary: Review Request: clasp - A conflict-driven nogood learning answer set solver Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: logans@cottsay.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://cottsay.fedorapeople.org/clasp/clasp.spec SRPM URL: http://cottsay.fedorapeople.org/clasp/clasp-3.0.1-1.fc21.src.rpm
Description: clasp is an answer set solver for (extended) normal and disjunctive logic programs. It combines the high-level modeling capacities of answer set programming (ASP) with state-of-the-art techniques from the area of Boolean constraint solving. The primary clasp algorithm relies on conflict-driven nogood learning, a technique that proved very successful for satisfiability checking (SAT). Unlike other learning ASP solvers, clasp does not rely on legacy software, such as a SAT solver or any other existing ASP solver. Rather, clasp has been genuinely developed for answer set solving based on conflict-driven nogood learning. clasp can be applied as an ASP solver (on SMODELS format, as output by Gringo), as a SAT solver (on a simplified version of DIMACS/CNF format), or as a PB solver (on OPB format).
Fedora Account System Username: cottsay
Copr builds (F19, F20 and rawhide): http://copr.fedoraproject.org/coprs/cottsay/gringo/monitor/
rpmlint output: SPECS/clasp.spec:43: W: configure-without-libdir-spec clasp.src: W: spelling-error Summary(en_US) nogood -> no good, no-good, Gounod clasp.src: W: spelling-error %description -l en_US nogood -> no good, no-good, Gounod clasp.src: W: spelling-error %description -l en_US satisfiability -> insatiability, advisability clasp.src:43: W: configure-without-libdir-spec clasp.x86_64: W: spelling-error Summary(en_US) nogood -> no good, no-good, Gounod clasp.x86_64: W: spelling-error %description -l en_US nogood -> no good, no-good, Gounod clasp.x86_64: W: spelling-error %description -l en_US satisfiability -> insatiability, advisability clasp.x86_64: W: no-manual-page-for-binary clasp clasp-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 10 warnings.
Notes: - Because this is part of a chained group of packages (clasp => gringo => clingo => aspcud), I opted to use copr for test builds instead of koji. - This package contains static-only libraries and adheres to the guidelines [1]. - The latest version of this project is not directly compatible with the other packages in this group, so to avoid bundling the this version of clasp in the other three, I needed to fall back to the version that they used in those bundles. - rpmlint reports "configure-without-libdir-spec", but if I include a libdir option, the configure fails because it is not an option. Installation is done manually, so this isn't a problem.
Thanks!
[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Librari...
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Scott K Logan logans@cottsay.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1093516
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1093516 [Bug 1093516] Review Request: gringo - Grounding tools for (disjunctive) logic programs
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Scott K Logan logans@cottsay.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1093521
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1093521 [Bug 1093521] Review Request: clingo - A bottom up grounder for logic programs
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i@cicku.me
--- Comment #1 from Christopher Meng i@cicku.me --- 1. Have you tried CMake to build it?
Actually, I mean if it's possible to build it as a shared library.
2. Not the latest version packaged.
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
--- Comment #2 from Scott K Logan logans@cottsay.net --- Hi Christopher -
1. I have tried it, and no, it doesn't build any non-static libraries. From what I can tell, the project only supports static libraries on non-Windows systems.
2. I noted this in my initial comment. The downstream packages bundle this version of clasp, and they won't build with the newest version. If we want to unbundle the clasp that they use, we'll need to use the version that they use. So until gringo and clingo update to the newest clasp, we'll need to keep this version as-is.
Thanks!
--scott
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |i@cicku.me
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Christopher Meng i@cicku.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
--- Comment #3 from Christopher Meng i@cicku.me --- SPEC:
0. 3.0.6 is available. Notified yet upstream about the wrong license header? I don't think you need to modify them, just let upstream know and fix that.
1. cd build/custom_mt && make %{?_smp_mflags}
make %{?_smp_mflags} -C build/custom_mt
2. install -m0755 -D build/custom_mt/bin/%{name} %{buildroot}%{_bindir}/%{name} install -m0644 -D build/custom_mt/lib%{name}/lib/lib%{name}.a %{buildroot}%{_libdir}/lib%{name}.a
Missing -p option to preserve the timestamp.
3. Requires: tbb-devel >= 3.0.0
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
--- Comment #4 from Scott K Logan logans@cottsay.net --- Christopher -
Thanks for the feedback.
(1) and (2) have been fixed as described.
For (3), I assume you were looking for the -devel package to depend on the base. I added that.
For (0), I'm sorry to report that this is not a straightforward fix. Current versions of gringo and clingo bundle version 3.0.1 of clasp, and won't build with newer versions of clasp. So in order to un-bundle clasp later, I have to use older clasp here. I've contacted upstream about this issue to see what they have to say about this issue, and the FSF address issue. Until they have a fix, we can't use the newest version.
Thanks,
--scott
Spec URL: http://cottsay.fedorapeople.org/clasp/clasp.spec SRPM URL: http://cottsay.fedorapeople.org/clasp/clasp-3.0.1-2.fc21.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
--- Comment #5 from Scott K Logan logans@cottsay.net --- Upstream just released new versions of this chain that are sync'd properly. All packages are now building at their latest versions without any bundled software.
Spec URL: https://cottsay.fedorapeople.org/clasp/clasp.spec SRPM URL: https://cottsay.fedorapeople.org/clasp/clasp-3.1.0-1.fc20.src.rpm
Copr builds (F20, F21 and rawhide): http://copr.fedoraproject.org/coprs/cottsay/gringo/monitor/
rpmlint output: SPECS/clasp.spec:39: W: configure-without-libdir-spec clasp.x86_64: W: spelling-error Summary(en_US) nogood -> no good, no-good, Gounod clasp.x86_64: W: spelling-error %description -l en_US nogood -> no good, no-good, Gounod clasp.x86_64: W: spelling-error %description -l en_US satisfiability -> insatiability, advisability clasp.x86_64: W: no-manual-page-for-binary clasp clasp-devel.x86_64: W: no-documentation 3 packages and 1 specfiles checked; 0 errors, 6 warnings.
Thanks,
--scott
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
--- Comment #6 from Scott K Logan logans@cottsay.net --- There is interest in a downstream package, aspcud, being added in the near future.
Christopher, is there any chance you can take another look at this anytime soon?
Thanks,
--scott
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Rich Mattes richmattes@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |richmattes@gmail.com Blocks| |1225692
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1225692 [Bug 1225692] Tracker for Fedora Robotics SIG
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |james.hogarth@gmail.com Flags| |needinfo?(i@cicku.me)
--- Comment #7 from James Hogarth james.hogarth@gmail.com --- Christopher are you interested in progressing the review of this package?
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
--- Comment #8 from Scott K Logan logans@cottsay.net --- James - Christopher has been MIA on this review for a very long time now, despite being pinged about it. If you are able, please take the review so we can proceed.
--scott
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Scott K Logan logans@cottsay.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|i@cicku.me |nobody@fedoraproject.org Flags|fedora-review? |
--- Comment #9 from Scott K Logan logans@cottsay.net --- Okay, I'm going to throw this review back into the pool. Haven't heard from Christopher in over a year.
--scott
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Ben Rosser rosser.bjr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rosser.bjr@gmail.com
--- Comment #10 from Ben Rosser rosser.bjr@gmail.com --- Hi,
Are you still interested in this (series of) reviews? I'm happy to take them.
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Ben Rosser rosser.bjr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |logans@cottsay.net Flags|needinfo?(i@cicku.me) |needinfo?(logans@cottsay.ne | |t)
--- Comment #11 from Ben Rosser rosser.bjr@gmail.com --- Ping.
aspcud is the recommended external depsolver for opam, the OCaml package manager. I've been taking over work on packaging opam (that got stalled back in 2015), and it would be nice to be able to get aspcud and its dependency stack into Fedora too.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews, please respond soon if you're still interested in these reviews.
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Scott K Logan logans@cottsay.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(logans@cottsay.ne | |t) |
--- Comment #12 from Scott K Logan logans@cottsay.net --- Yes, I can continue with the review. I'll do my best to get it updated to the latest sources by EOW.
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
Ben Rosser rosser.bjr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |rosser.bjr@gmail.com
--- Comment #13 from Ben Rosser rosser.bjr@gmail.com --- Awesome, thanks a lot.
Let me know when it's ready, and I'll review (and the other packages that depend on it). :)
https://bugzilla.redhat.com/show_bug.cgi?id=1093500
--- Comment #14 from Scott K Logan logans@cottsay.net --- Hey, Ben -
I did some work on this Sunday, and it looks like the Potassco codebase is in significantly better shape than it was when I started these reviews. Instead of the currently proposed model, I'd like to make these three packages: 1) libpotassco 2) clasp 3) clingo - clingo - gringo - libreify - python-clingo - lua-clingo
I have the first two done-ish, but the last one is pretty big, and unfortunately I need to do some work to unbundle clasp and libpotassco from it.
I'll keep you updated, and will probably submit the first two for review sooner rather than later. The spec files are structured almost identically, anyway.
package-review@lists.fedoraproject.org