https://bugzilla.redhat.com/show_bug.cgi?id=1853634
Bug ID: 1853634 Summary: Review Request: perl-Color-ANSI-Util - Routines for dealing with ANSI colors Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jplesnik.fedorapeople.org/perl-Color-ANSI-Util/perl-Color-ANSI-Util.... SRPM URL: https://jplesnik.fedorapeople.org/perl-Color-ANSI-Util/perl-Color-ANSI-Util-...
Description: This module provides routines for dealing with ANSI colors. The two main functions are ansifg and ansibg. With those functions, you can specify colors in RGB and let it output the correct ANSI color escape code according to the color depth support of the terminal (whether 16-color, 256-color, or 24bit). There are other functions to convert RGB to ANSI in specific color depths, or reverse functions to convert from ANSI to RGB codes.
Fedora Account System Username: jplesnik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1853634
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1853629
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1853629 [Bug 1853629] Review Request: perl-Color-RGB-Util - Utilities related to RGB colors
https://bugzilla.redhat.com/show_bug.cgi?id=1853634
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1853571
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1853571 [Bug 1853571] perl-JSON-Color-0.130 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1853634
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- URL and Source addresses are Ok. Source archive (SHA-256: 681c1c88d0d06e635d981482db855d2b8803b9a31e8de54e18912e76d1fdd062) is original. Ok. Summary verified from lib/Color/ANSI/Util.pm. Ok. Description verified. Ok. License verified from README and lib/Color/ANSI/Util.pm. Ok. No XS code, noarch BuildArch is Ok.
Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod are not used. Ok. AUTHOR_TESTING variable is unset before executing "make test". Ok.
$ rpmlint perl-Color-ANSI-Util.spec review-perl-Color-ANSI-Util/results/perl-Color-ANSI-Util-0.164-1.fc33.noarch.rpm review-perl-Color-ANSI-Util/results/perl-Color-ANSI-Util-0.164-1.fc33.src.rpm perl-Color-ANSI-Util.noarch: W: spelling-error %description -l en_US ansifg -> ANSI perl-Color-ANSI-Util.noarch: W: spelling-error %description -l en_US ansibg -> ANSI perl-Color-ANSI-Util.src: W: spelling-error %description -l en_US ansifg -> ANSI perl-Color-ANSI-Util.src: W: spelling-error %description -l en_US ansibg -> ANSI 2 packages and 1 specfiles checked; 0 errors, 4 warnings.
$ rpm -q -lv -p review-perl-Color-ANSI-Util/results/perl-Color-ANSI-Util-0.164-1.fc33.noarch.rpm 12:37:20 drwxr-xr-x 2 root root 0 Jul 4 12:34 /usr/share/doc/perl-Color-ANSI-Util -rw-r--r-- 1 root root 3200 Jun 9 11:01 /usr/share/doc/perl-Color-ANSI-Util/Changes -rw-r--r-- 1 root root 8293 Jun 9 11:01 /usr/share/doc/perl-Color-ANSI-Util/README drwxr-xr-x 2 root root 0 Jul 4 12:34 /usr/share/licenses/perl-Color-ANSI-Util -rw-r--r-- 1 root root 18493 Jun 9 11:01 /usr/share/licenses/perl-Color-ANSI-Util/LICENSE -rw-r--r-- 1 root root 3408 Jul 4 12:34 /usr/share/man/man3/Color::ANSI::Util.3pm.gz drwxr-xr-x 2 root root 0 Jul 4 12:34 /usr/share/perl5/vendor_perl/Color drwxr-xr-x 2 root root 0 Jul 4 12:34 /usr/share/perl5/vendor_perl/Color/ANSI -rw-r--r-- 1 root root 24365 Jun 9 11:01 /usr/share/perl5/vendor_perl/Color/ANSI/Util.pm File layout and permissions are Ok.
$ rpm -q --requires -p review-perl-Color-ANSI-Util/results/perl-Color-ANSI-Util-0.164-1.fc33.noarch.rpm | sort -f | uniq perl(:MODULE_COMPAT_5.32.0) perl(:VERSION) >= 5.10.1 perl(Color::RGB::Util) >= 0.600 perl(Exporter) >= 5.57 perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok.
$ rpm -q --provides -p review-perl-Color-ANSI-Util/results/perl-Color-ANSI-Util-0.164-1.fc33.noarch.rpm | sort -f | uniq -c 1 perl(Color::ANSI::Util) = 0.164 1 perl-Color-ANSI-Util = 0.164-1.fc33 Binary provides are Ok.
The package builds in Fedora 33 (Mock). Ok.
The package is in line with Fedora and Perl packagaging guidelines.
Resolution: Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1853634
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- https://pagure.io/releng/fedora-scm-requests/issue/26872
https://bugzilla.redhat.com/show_bug.cgi?id=1853634
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Color-ANSI-Util
https://bugzilla.redhat.com/show_bug.cgi?id=1853634 Bug 1853634 depends on bug 1853629, which changed state.
Bug 1853629 Summary: Review Request: perl-Color-RGB-Util - Utilities related to RGB colors https://bugzilla.redhat.com/show_bug.cgi?id=1853629
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1853634
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |perl-Color-ANSI-Util-0.164- | |1.fc33 Resolution|--- |RAWHIDE Last Closed| |2020-07-07 16:55:17
--- Comment #4 from Jitka Plesnikova jplesnik@redhat.com --- Thank you for the review and the repository.
package-review@lists.fedoraproject.org