[Bug 1870208] New: Review Request: rubygem-ruby-vips - Ruby extension for the vips image processing library
9:28 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1870208
Bug ID: 1870208
Summary: Review Request: rubygem-ruby-vips - Ruby extension for
the vips image processing library
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: pvalena(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedor...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedor...
Description: ruby-vips is a binding for the vips image processing library. It
is fast and it can process large images without loading the whole image in
memory.
Fedora Account System Username: pvalena
Builds & Tests run:
https://gist.github.com/pvalena/75824094c5d97a347c036680bb2185ed
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:59 a.m.
New subject: [Bug 1870208] Review Request: rubygem-ruby-vips - Ruby extension for
the vips image processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1870208
Vít Ondruch <vondruch(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |vondruch(a)redhat.com
Assignee|nobody(a)fedoraproject.org |vondruch(a)redhat.com
Flags| |fedora-review?
--- Comment #1 from Vít Ondruch <vondruch(a)redhat.com> ---
I'm taking this for a review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:07 a.m.
New subject: [Bug 1870208] Review Request: rubygem-ruby-vips - Ruby extension for
the vips image processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1870208
--- Comment #2 from Vít Ondruch <vondruch(a)redhat.com> ---
* `BuildRequires: vips-devel`
- What is the reason to include vips-devel instead of just vips?
* Requires
- I think there should be something aka `Requires: vips`
- Possibly, there could be required all libraries loaded via `ffi_lib` call.
BTW, I'd rather see requires such as 'libvips.so.42`, but they are not properly
required [1].
* Wrong shebangs:
~~~
rubygem-ruby-vips-doc.noarch: E: env-script-interpreter
/usr/share/gems/gems/ruby-vips-2.0.17/example/example1.rb /usr/bin/env ruby
rubygem-ruby-vips-doc.noarch: E: env-script-interpreter
/usr/share/gems/gems/ruby-vips-2.0.17/example/thumb.rb /usr/bin/env ruby
~~~
[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1870275
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:32 p.m.
New subject: [Bug 1870208] Review Request: rubygem-ruby-vips - Ruby extension for
the vips image processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1870208
--- Comment #3 from Pavel Valena <pvalena(a)redhat.com> ---
Thank you for your reviews!
- What is the reason to include vips-devel instead of just vips?
You're right, I thought I needed headers, but I don't.
- I think there should be something aka `Requires: vips`
Yes, you're right. I've tried using it in the test suite of image_processing
gem (which succeeds).
* Wrong shebangs:
Hmm. I've already fixed that (I've linked probably an earlier iteration of spec
file by mistake).
Refreshed SPEC and SRPM with the changes (the release bump is just for COPR).
Spec:
https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedor...
SRPM:
https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedor...
Builds & Test log:
https://gist.github.com/pvalena/7dc8d06603fc58c7f207cd854a1d4b8d
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:02 a.m.
New subject: [Bug 1870208] Review Request: rubygem-ruby-vips - Ruby extension for
the vips image processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1870208
Vít Ondruch <vondruch(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #4 from Vít Ondruch <vondruch(a)redhat.com> ---
(In reply to Pavel Valena from comment #3)
> * Wrong shebangs:
Hmm. I've already fixed that (I've linked probably an earlier iteration of
spec file by mistake).
I admire your upstream convincing skills in this regard :)
Otherwise LGTM => APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 a.m.
New subject: [Bug 1870208] Review Request: rubygem-ruby-vips - Ruby extension for
the vips image processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1870208
--- Comment #5 from Vít Ondruch <vondruch(a)redhat.com> ---
(In reply to Vít Ondruch from comment #2)
BTW, I'd rather see requires such as 'libvips.so.42`, but
they are not
properly required [1].
And it turns out, there is way to do it according to RPM upstream [1]:
~~~
Requires: (libvips.so.42()(64bit) if libc.so.6()(64bit))
Requires: (libvips.so.42 if libc.so.6)
~~~
Because this is Ruby package, we could possible use libruby.so instead.
[1]:
https://github.com/rpm-software-management/rpm/issues/1344#issuecomment-6...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:51 a.m.
New subject: [Bug 1870208] Review Request: rubygem-ruby-vips - Ruby extension for
the vips image processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1870208
--- Comment #6 from Vít Ondruch <vondruch(a)redhat.com> ---
(In reply to Vít Ondruch from comment #5)
Because this is Ruby package, we could possible use libruby.so
instead.
or libffi.so.6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:47 a.m.
New subject: [Bug 1870208] Review Request: rubygem-ruby-vips - Ruby extension for
the vips image processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1870208
--- Comment #7 from Pavel Valena <pvalena(a)redhat.com> ---
(In reply to Vít Ondruch from comment #4)
(In reply to Pavel Valena from comment #3)
> > * Wrong shebangs:
>
> Hmm. I've already fixed that (I've linked probably an earlier iteration of
> spec file by mistake).
I admire your upstream convincing skills in this regard :)
Otherwise LGTM => APPROVED
I think it was luck.
(In reply to Vít Ondruch from comment #5)
(In reply to Vít Ondruch from comment #2)
> BTW, I'd rather see requires such as 'libvips.so.42`, but they are not
> properly required [1].
And it turns out, there is way to do it according to RPM upstream [1]:
~~~
Requires: (libvips.so.42()(64bit) if libc.so.6()(64bit))
Requires: (libvips.so.42 if libc.so.6)
~~~
Because this is Ruby package, we could possible use libruby.so instead.
[1]:
https://github.com/rpm-software-management/rpm/issues/1344#issuecomment-
681916527
Thanks of figuring this out! `libffi.so.6` seems like a good choice indeed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:31 a.m.
New subject: [Bug 1870208] Review Request: rubygem-ruby-vips - Ruby extension for
the vips image processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1870208
--- Comment #8 from Gwyn Ciesla <gwync(a)protonmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-ruby-vips
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:27 p.m.
New subject: [Bug 1870208] Review Request: rubygem-ruby-vips - Ruby extension for
the vips image processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1870208
Pavel Valena <pvalena(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Fixed In Version| |rubygem-ruby-vips-2.0.17-1.
| |fc34
Resolution|--- |RAWHIDE
Last Closed| |2020-10-30 00:27:49
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1276
days inactive
1348
days old
package-review@lists.fedoraproject.org
9 comments
1 participants
participants (1)
-
bugzilla＠redhat.com