Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-delayed_job_active_record - ActiveRecord back-end for DelayedJob
https://bugzilla.redhat.com/show_bug.cgi?id=818629
Summary: Review Request: rubygem-delayed_job_active_record - ActiveRecord back-end for DelayedJob Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: vondruch@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://people.redhat.com/vondruch/rubygem-delayed_job_active_record.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-delayed_job_active_record-0.3.2-1.... Description: ActiveRecord back-end for DelayedJob, originally authored by Tobias Luetke
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4050135
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818629
Richard Su rwsu@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rwsu@redhat.com AssignedTo|nobody@fedoraproject.org |rwsu@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=818629
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jstribny@redhat.com
--- Comment #1 from Josef Stribny jstribny@redhat.com --- Hi,
1, rpmlint gives me no errors on .spec file and src.rpm:
`0 packages and 1 specfiles checked; 0 errors, 0 warnings.` `1 packages and 0 specfiles checked; 0 errors, 0 warnings.`
2, The version of the gem in the spec file is 0.3.2, but 0.3.3 is already out:
`gem fetch delayed_job_active_record` `Fetching: delayed_job_active_record-0.3.3.gem (100%)`
It's recommended to always build for the latest upstream release if available.
3, Running:
`mock -r fedora-rawhide-x86_64 rubygem-delayed_job_active_record-0.3.2-1.fc19.src.rpm` raises an exception, in the build.log I found a failing test: ``` + rspec spec DEPRECATION WARNING: Calling set_primary_key is deprecated. Please use `self.primary_key = 'the_name'` instead. (called from class:Story at /builddir/build/BUILD/rubygem-delayed_job_active_record-0.3.2/usr/share/gems/gems/delayed_job_active_record-0.3.2/spec/spec_helper.rb:43) ............................................................F................ Failures: 1) Delayed::Backend::ActiveRecord::Job it should behave like a delayed_job backend worker integration failed jobs should re-schedule jobs after failing Failure/Error: @job.attempts.should == 1 expected: 1 ```
This also happens when building using mock for fedora-18-x86_64.
https://bugzilla.redhat.com/show_bug.cgi?id=818629
--- Comment #2 from Vít Ondruch vondruch@redhat.com --- Thank you for looking into this package. Here is its updated version:
Spec URL: http://people.redhat.com/vondruch/rubygem-delayed_job_active_record.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-delayed_job_active_record-0.3.3-1....
(In reply to comment #1)
2, The version of the gem in the spec file is 0.3.2, but 0.3.3 is already out:
`gem fetch delayed_job_active_record` `Fetching: delayed_job_active_record-0.3.3.gem (100%)`
It's recommended to always build for the latest upstream release if available.
Yes, the .spec file was laying around for some time. I updated it to the latest version.
3, Running:
`mock -r fedora-rawhide-x86_64 rubygem-delayed_job_active_record-0.3.2-1.fc19.src.rpm` raises an exception, in the build.log I found a failing test:
+ rspec spec DEPRECATION WARNING: Calling set_primary_key is deprecated. Please use `self.primary_key = 'the_name'` instead. (called from <class:Story> at /builddir/build/BUILD/rubygem-delayed_job_active_record-0.3.2/usr/share/gems/ gems/delayed_job_active_record-0.3.2/spec/spec_helper.rb:43) ............................................................F................ Failures: 1) Delayed::Backend::ActiveRecord::Job it should behave like a delayed_job backend worker integration failed jobs should re-schedule jobs after failing Failure/Error: @job.attempts.should == 1 expected: 1
This also happens when building using mock for fedora-18-x86_64.
Weird. You can see from the attached Koji link that the test suite used to pass. However, it was probably against Rails 3.0 at that time. I was not able to locate the issue, so I have reported it upstream: https://github.com/collectiveidea/delayed_job_active_record/issues/24
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818629
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #3 from Josef Stribny jstribny@redhat.com --- Seems like that upstream is not doing anything about the issue for the time being. The package is otherwise okay => APPROVED.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818629
Josef Stribny jstribny@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818629
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- No SCM request found in bug 818629.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818629
--- Comment #5 from Vít Ondruch vondruch@redhat.com --- Thank you for your review!
New Package SCM Request ======================= Package Name: rubygem-delayed_job_active_record Short Description: ActiveRecord back-end for DelayedJob Owners: vondruch Branches: InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818629
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818629
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818629
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed| |2012-12-11 10:21:09
package-review@lists.fedoraproject.org