https://bugzilla.redhat.com/show_bug.cgi?id=1487430
Bug ID: 1487430 Summary: Review Request: git-lfs - Git extension for versioning large files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: quantum.analyst@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-rawhi... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-rawhi... Description: Git Large File Storage (LFS) replaces large files such as audio samples, videos, datasets, and graphics with text pointers inside Git, while storing the file contents on a remote server. Fedora Account System Username: qulogic
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ignatenko@redhat.com
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- *** Bug 1336168 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1486510, 1486511 Alias| |git-lfs
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1486510 [Bug 1486510] Review Request: golang-github-bgentry-go-netrc - netrc file parser for Go programming language https://bugzilla.redhat.com/show_bug.cgi?id=1486511 [Bug 1486511] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Initial pass through:
# Generate devel rpm %global with_devel 0
Why is this disabled? Is it not possible to use Git LFS code as a module in other Go programs?
# Generate unit-test rpm %global with_unit_test 0
Why is this disabled?
%post /bin/git-lfs install --system
Please use "%{_bindir}/%{name}" here, as that's how it is actually installed.
%preun if [ $1 -gt 0 ]; then /bin/git-lfs uninstall fi exit 0
Same here, and also properly indent the shell script here.
%files %license LICENSE.md %{_bindir}/%{name} %doc %{_mandir}/man1/%{name}*.1* %doc %{_mandir}/man5/%{name}*.5*
It is redundant to declare man pages as documentation, as rpm auto-marks files installed into %{_mandir}/*/* as documentation files.
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #4 from Elliott Sales de Andrade quantum.analyst@gmail.com --- I can't say for certain whether you can or cannot use it as a module, but the draft Go spec doesn't even try to build devel/unit-test RPMs: https://fedoraproject.org/wiki/PackagingDrafts/Go#Packaging_a_binary Instead, I left those in there in case we need to enable them later.
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #5 from Elliott Sales de Andrade quantum.analyst@gmail.com --- According to godoc, there are no importers: https://godoc.org/github.com/git-lfs/git-lfs
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #6 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Fixed the initial comments.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-rawhi... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-rawhi... Description: Git Large File Storage (LFS) replaces large files such as audio samples, videos, datasets, and graphics with text pointers inside Git, while storing the file contents on a remote server. Fedora Account System Username: qulogic
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- Package was generated through gofed, simplifying the review considerably.
- Conforms to packaging guidelines (gofed generated spec) - license correct and valid - license file installed correctly - Binaries for applications installed - Scriptlets look sane
PACKAGE APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #8 from Igor Gnatenko ignatenko@redhat.com --- to me scriptlets don't look sane... I would expect it to be executed while package is built, but this is one thing...
Another thing could be done is to reference all files it creates via %ghost.
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #9 from Elliott Sales de Andrade quantum.analyst@gmail.com --- According to its man page, git only seems to support a single /etc/gitconfig file and not a directory like /etc/mercurial/hgrc.d. So I don't see how this could be done at build time. The file is not technically owned by git-lfs.
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #10 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/git-lfs
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #11 from Neal Gompa ngompa13@gmail.com --- (In reply to Igor Gnatenko from comment #8)
to me scriptlets don't look sane... I would expect it to be executed while package is built, but this is one thing...
Another thing could be done is to reference all files it creates via %ghost.
Unfortunately, git is insane, so... :(
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- git-lfs-2.2.1-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-090bbadbe3
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- git-lfs-2.2.1-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ae6d44aaa
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- git-lfs-2.2.1-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ae6d44aaa
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- git-lfs-2.2.1-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-090bbadbe3
https://bugzilla.redhat.com/show_bug.cgi?id=1487430 Bug 1487430 depends on bug 1486511, which changed state.
Bug 1486511 Summary: Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go https://bugzilla.redhat.com/show_bug.cgi?id=1486511
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1487430 Bug 1487430 depends on bug 1486510, which changed state.
Bug 1486510 Summary: Review Request: golang-github-bgentry-go-netrc - netrc file parser for Go programming language https://bugzilla.redhat.com/show_bug.cgi?id=1486510
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-09-11 20:23:00
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- git-lfs-2.2.1-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords| |Reopened
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- git-lfs-2.3.4-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ae6d44aaa
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- git-lfs-2.3.4-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ae6d44aaa
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- git-lfs-2.3.4-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1487430
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|Reopened | Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-09-11 20:23:00 |2017-11-18 16:37:54
--- Comment #20 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Only reopened because the freeze took so long.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com