https://bugzilla.redhat.com/show_bug.cgi?id=1776513
--- Comment #2 from Paul Howarth <paul(a)city-fan.org> ---
Hi Petr,
In reply to Petr Pisar from comment #1)
TODO: Please constrain 'BuildRequires:
perl(ExtUtils::MakeMaker)' with '>=
6.76' due to the use of 'NO_PACKLIST=1 NO_PERLLOCAL=1'.
OK.
FIX: Build-require 'findutils' (perl-XString.spec:47).
OK.
TODO: Remove '>= 0.88' constrain from 'BuildRequires:
perl(Test::More)'
because it's needed only for author tests that the spec file does not
perform.
That version is needed by t/cstring.t, which uses done_testing but upstream
hasn't put the versioned use of Test::More in that file.
FIX: Either build-require 'perl(CPAN::Meta::Prereqs)'
(t/00-report-prereqs.t:29) or do not build-require 'perl(CPAN::Meta)'. They
are needed both for the optional tests.
OK.
FIX: Do not build-require unused
'perl(Test2::Bundle::Extended)',
'perl(Test2::Plugin::NoWarnings)', and 'perl(Test2::Tools::Explain)'.
I put those in because the test suite complains quite loudly about them being
missing. I raised
https://github.com/atoomic/XString/issues/2 for upstream to
get rid of them.
$ rpm -q --requires -p
../RPMS/x86_64/perl-XString-0.002-1.fc32.x86_64.rpm |
sort -f | uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 libperl.so.5.30()(64bit)
1 libpthread.so.0()(64bit)
1 libpthread.so.0(GLIBC_2.2.5)(64bit)
1 perl(:MODULE_COMPAT_5.30.1)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
1 rtld(GNU_HASH)
FIX: Run-require 'perl(XSLoader)' (lib/XString.pm:11). This one is not
autodetected because of an indentation.
OK.
Please correct the 'FIX' items and consider fixing
'TODO' items before
building this pacakge.
Resolution: Pacakge APPROVED.
Thanks for the review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component