Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226004
Summary: Merge Review: libfontenc Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: sandmann@redhat.com
Fedora Merge Review: libfontenc
http://cvs.fedora.redhat.com/viewcvs/devel/libfontenc/ Initial Owner: sandmann@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226004
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2010-09-07 02:20:16 EDT --- rpmlint gave
libfontenc.src: W: spelling-error Summary(en_US) runtime -> run time, run-time, runtish libfontenc.src: W: name-repeated-in-summary C libfontenc libfontenc.src: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish libfontenc.src:30: W: unversioned-explicit-obsoletes XFree86-devel libfontenc.src:30: W: unversioned-explicit-obsoletes xorg-x11-devel libfontenc.src: W: invalid-url Source0: ftp://ftp.x.org/pub/individual/lib/libfontenc-1.0.5.tar.bz2 <urlopen error ftp error: timed out> libfontenc.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, runtish libfontenc.x86_64: W: name-repeated-in-summary C libfontenc libfontenc.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish libfontenc.x86_64: E: zero-length /usr/share/doc/libfontenc-1.0.5/AUTHORS libfontenc-devel.x86_64: W: obsolete-not-provided XFree86-devel libfontenc-devel.x86_64: W: obsolete-not-provided xorg-x11-devel libfontenc-devel.x86_64: W: no-documentation
Suggestions: 1)As this review is currently for F15, following should be implemented in spec a) buildroot should be removed b) %clean not needed c) cleaning of buildroot at start of %install also not needed
2) AUTHORS file should be removed as its zero-length.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226004
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226004
--- Comment #2 from Parag AN(पराग) panemade@gmail.com 2010-09-07 02:23:30 EDT --- Created attachment 443407 --> https://bugzilla.redhat.com/attachment.cgi?id=443407 merge-review cleanup patch
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226004
--- Comment #3 from Parag AN(पराग) panemade@gmail.com 2010-09-07 02:43:29 EDT --- Maintainer please commit above patch or approve me to commit it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226004
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2010-09-07 12:40:57 EDT --- ssp and ajax have previously asked me to just go ahead and deal with simple merge review cleanups for them. I committed your patch to master, but did not build.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226004
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed| |2010-09-08 01:50:10
--- Comment #5 from Parag AN(पराग) panemade@gmail.com 2010-09-08 01:50:10 EDT --- To make myself happy, I have built above changes to make sure some other spec commit will not overwrite it.
APPROVED libfontenc-1.0.5-3.fc15 and Closing this review.
package-review@lists.fedoraproject.org