Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-User - API for locating user information regardless of OS

https://bugzilla.redhat.com/show_bug.cgi?id=428114

xavier@bachelot.org changed:

What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |428115 nThis| |

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-User - API for locating user information regardless of OS

https://bugzilla.redhat.com/show_bug.cgi?id=428114

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From panemade@gmail.com 2008-01-09 06:56 EST ------- I don't think you need %check ||: make it %check only.

Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url b8b2c677dc4ef08e84b5b4f8cb021540 User-1.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl 1..3 # Running under perl version 5.008008 for linux # Current time local: Wed Jan 9 06:21:40 2008 # Current time GMT: Wed Jan 9 11:21:40 2008 # Using Test.pm version 1.25 ok 1 ok 2 ok 3 + Package perl-User-1.8-1.fc9 -> Provides: perl(User) = 1.8 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(strict) perl(vars) APPROVED.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-User - API for locating user information regardless of OS

https://bugzilla.redhat.com/show_bug.cgi?id=428114

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-01-09 13:25 EST ------- cvs done.