Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Ngspice - A mixed level/signal circuit simulator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204250 ------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-08-28 06:33 EST ------- I will review this package. 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * rpmlint issue ( also * Exclusion of Static Libraries ) - W: ngspice devel-file-in-non-devel-package \ /usr/lib/ng-spice-rework/libbsim4.a This static archive should be removed unless there is a reason that this must be installed. (Try if this package works well with this archive removed.) * Compiler flags - This package does not accept Fedora specific compilation flags and debuginfo rpm is useless. Fix Makefile or the environment of "make" invocation to use Fedora specific compilation flags. (See build log). 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : * shared library files - Does this package require to call ldconfig? This package does not have any shared libraries in default paths. 3. Other things I have noticed : * Spec file cosmetic issue - I think that %{_mandir}/man1/ngnutmeg.1* is more preferable than %{_mandir}/man1/ngnutmeg.1.gz . * File entry - /usr/share/doc/ngspice-doc-17/doc/ngspice.info* and /usr/share/info/ngspice.info* may be duplicate. Check if both of these are needed. * Mock issue - Ah... I don't know how to use this package at all!! However, I watched some URL and tried: $ cat > rc.cir <<EOF Basic RC circuit r 1 2 1.0 c 2 0 1.0 vin 1 0 pulse (0 1) ac 1 .tran 0.1 7.0 .plot tran v(2) i(vin) .end EOF $ ngspice -b -r rc.raw rc.cir $ ngnutmeg rc.raw .... ... ngnutmeg * -> plot v(2) Then I installed ngspice with rebuilt in mock, I got... [tasaka1@dhcp151 NGSPICE2]$ ngnutmeg rc.raw ****** ** ngnutmeg-17 : data analysis and manipulation program ** The U. C. Berkeley CAD Group ** Copyright 1985-1994, Regents of the University of California. ** Please submit bug-reports to: ngspice-bugs(a)lists.sourceforge.net ** Creation Date: Mon Aug 28 04:04:22 EDT 2006 ****** external error: no graphics interface; please check compiling instructions Loading raw data file ("rc.raw") . . . done. Title: Basic RC circuit Name: Transient Analysis Date: Mon Aug 28 19:18:36 2006 ngnutmeg 4 -> plot v(2) Can't open viewport for graphics. ngnutmeg 5 -> and.. when I tried the rpm rebuilt with normal rpmbuild, I got a X window graph (perhaps as expected) So, again, some BR are missing. I attach a full mock build log. The diff I am concerned in is: @@ -189,31 +478,14 @@ checking whether a program can dlopen itself... (cached) yes checking whether a statically linked program can dlopen itself... (cached) yes appending configuration tag "F77" to libtool -checking if libtool supports shared libraries... yes -checking whether to build shared libraries... yes -checking whether to build static libraries... yes -checking for f95 option to produce PIC... -fPIC -checking if f95 PIC flag -fPIC works... yes -checking if f95 supports -c -o file.o... yes -checking whether the f95 linker (/usr/bin/ld) supports shared libraries... yes -checking dynamic linker characteristics... GNU/Linux ld.so -checking how to hardcode library paths into programs... immediate -checking whether stripping libraries is possible... yes checking whether windows code is enabled... no -checking for X... libraries , headers in standard search path -checking for gethostbyname... yes -checking for connect... yes -checking for remove... yes -checking for shmat... yes -checking for IceConnectionNumber in -lICE... yes -checking for main in -lXaw... yes -checking for main in -lXmu... yes -checking for XShmAttach in -lXext... yes -checking for bison... bison -y -checking for flex... flex -checking for yywrap in -lfl... yes -checking lex output file root... lex.yy -checking whether yytext is a pointer... yes +checking for X... no +checking for bison... no +checking for byacc... no +checking for flex... no +checking for lex... no +checking for yywrap in -lfl... no +checking for yywrap in -ll... no checking for pid_t... yes checking return type of signal handlers... void checking for dirent.h that defines DIR... yes @@ -295,7 +567,7 @@ checking readline/history.h usability... yes checking readline/history.h presence... yes checking for readline/history.h... yes -checking for library containing tputs... -lncurses +checking for library containing tputs... -ltermcap checking for readline in -lreadline... yes BSD editline disabled. configure: creating ./config.status @@ -447,12 +719,7 @@ checking for style of include used by make... GNU checking dependency style of gcc... gcc3 checking how to run the C preprocessor... gcc -E -checking for X... libraries , headers in standard search path -checking for gethostbyname... yes -checking for connect... yes -checking for remove... yes -checking for shmat... yes -checking for IceConnectionNumber in -lICE... yes +checking for X... no checking for egrep... grep -E checking for ANSI C header files... yes checking for sys/types.h... yes -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.