Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com

------- Additional Comments From panemade@gmail.com 2007-10-16 00:09 EST ------- mock build failed with following log checking for SQLITE... configure: error: Package requirements (sqlite3) were not met:

No package 'sqlite3' found

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

peter@thecodergeek.com changed:

What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |333471 nThis| |

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From panemade@gmail.com 2007-10-16 01:23 EST ------- Also, I can't see any man file getting installed as can be seen from build.log File not found by glob: /var/tmp/PackageKit-0.1.0-2.fc8-root-mockbuild/usr/share/man/man1/*.1.gz

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From panemade@gmail.com 2007-10-16 01:40 EST ------- COPYING seems like GPLv2, you still want to have license tag as GPL+?

I think my comments are over now, You can update SPEC and provide new SRPM for further review.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From panemade@gmail.com 2007-10-16 23:24 EST ------- Thanks.

1) I found problem in mockbuild => RPM build errors: File not found by glob: /var/tmp/PackageKit-0.1.0-2.fc8-root-mockbuild/usr/share/man/man1/*.1.gz This is happening because of missing BR: docbook-utils in SPEC.

2) After adding missing BR when I mock build it went fine. But rpmlint complained PackageKit.i386: E: non-executable-script /usr/lib/python2.5/site-packages/packagekit/backend.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.

PackageKit.i386: E: non-executable-script /usr/lib/python2.5/site-packages/packagekit/frontend.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. ===> Once you fix this in upstream. Kindly provide new SRPM for review with fixes mentioned in this comment.

PackageKit.i386: W: file-not-utf8 /usr/share/doc/packagekit/reference.html The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). ==> You need to use iconv command on that file. Not needed in SPEC as you are upstream you can release new tarball with this fix.

PackageKit.i386: W: non-standard-dir-in-var db Your package is creating a non-standard subdirectory in /var. The standard directories are: account, lib, cache, crash, games, lock, log, opt, run, spool, state, tmp, yp, www, ftp ==> This looks fake warning as /var/db is already owned by filesystem package.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From rnorwood@redhat.com 2007-10-17 10:43 EST ------- Tim - thanks - I'm going to see today when Hughsie wants to release 0.1.1 - if it's soon enough (like in a day or two), I might just wait for that.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From rnorwood@redhat.com 2007-10-23 11:41 EST ------- Ok - new version:

http://people.redhat.com/rnorwood/rpms/PackageKit-0.1.1-1.fc8.src.rpm http://people.redhat.com/rnorwood/rpms/PackageKit.spec

Should fix all of the existing issues, as well as going to the latest version.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From panemade@gmail.com 2007-10-24 02:23 EST ------- Installed PackageKit after solving above problem but then found that package PackageKit installed /usr/share/doc/packagekit/pk-reference.html but can't find who owns /usr/share/doc/packagekit ? and why to create one more docs directory for PackageKit? I did some workaround for docs files here.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From rnorwood@redhat.com 2007-10-24 16:50 EST ------- o Included your docs cleanup changes o It looks like the build is generating /usr/share/doc/packagekit/pk-reference.html and copying it to the other doc directory. Changed the specfile to just remove the one in /usr/share/doc/packagekit and leave the other. o I'm mystified by the chmod error in comment #13 - I don't get that error, and if I leave out the chmod command I get:

PackageKit.i386: E: script-without-shebang /usr/share/PackageKit/helpers/yum/yumBackend.py

from rpmlint.

I'll leave it out for now.

New SRPM and spec file:

http://people.redhat.com/rnorwood/rpms/PackageKit.spec http://people.redhat.com/rnorwood/rpms/PackageKit-0.1.1-2.fc8.src.rpm

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From panemade@gmail.com 2007-10-25 01:16 EST ------- mclasen, Are you using old rawhide(say one month old) by any chance? I also got same error. But when I mock build on latest rawhide I got it working fine on my local machine.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From panemade@gmail.com 2007-10-25 04:25 EST ------- looks like my local rawhide setup gone wrong with last week's updates. Did a koji build then and found this package is really missing BR:python-devel

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From mclasen@redhat.com 2007-10-26 00:05 EST ------- The configure option changed, you must use --with-default-backend=yum now.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From panemade@gmail.com 2007-10-26 00:51 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. ad915a2cd3d5028fa6e399e0947aecdc PackageKit-0.1.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + packagekit.pc files are present. + -devel,-libs subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + package PackageKit-0.1.0-4.fc8 -> Provides: config(PackageKit) = 0.1.0-4.fc8 Requires: /bin/sh /usr/bin/python PackageKit-libs = 0.1.1-4.fc9 config(PackageKit) = 0.1.1-4.fc9 dbus >= 0.90 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdbus-1.so.3 libdbus-glib-1.so.2 libdl.so.2 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libnm_glib.so.0 libpackagekit.so.2 libpolkit-dbus.so.2 libpolkit-grant.so.2 libpolkit.so.2 libpthread.so.0 libpthread.so.0(GLIBC_2.0) librt.so.1 libsqlite3.so.0 python(abi) = 2.5 rtld(GNU_HASH) yum >= 3.2.6 + package PackageKit-devel-0.1.0-4.fc8 -> Requires: PackageKit = 0.1.1-4.fc9 dbus-devel >= 0.90 libpackagekit.so.2 pkgconfig sqlite-devel + package PackageKit-libs-0.1.0-4.fc8 -> Provides: libpackagekit.so.2 libpk_backend_dummy.so libpk_backend_test_fail.so libpk_backend_test_nop.so libpk_backend_test_spawn.so libpk_backend_test_succeed.so libpk_backend_test_thread.so libpk_backend_yum.so Requires: dbus >= 0.90 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libdbus-1.so.3 libdbus-glib-1.so.2 libdl.so.2 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libnm_glib.so.0 libpackagekit.so.2 libpthread.so.0 librt.so.1 rtld(GNU_HASH) + Not a GUI app.

APPROVED.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-26 02:32 EST ------- Would you check what owns the following directories? --------------------------------------------------------------- %{_localstatedir}/run/PackageKit/ %{_libdir}/packagekit-backend/ ---------------------------------------------------------------

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From panemade@gmail.com 2007-10-26 02:52 EST ------- thanks for having a look on this package Mamoru.

You are right. directory is not owned /usr/lib/packagekit-backend and missed my eyes following rpm view drwxr-xr-x 2 root root 0 Oct 26 11:59 /var/lib/PackageKit -rw-r--r-- 1 root root 3072 Oct 26 11:59 /var/lib/PackageKit/transactions.db -rw-r--r-- 1 root root 2 Oct 26 11:59 /var/run/PackageKit/job_count.dat

so directory /var/run/PackageKit is not owned.

For Documentation thing I agree with you. -libs should install docs.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-26 03:06 EST ------- Well, one more thing - It doesn't seem that PackageKit-devel should require sqlite-devel.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From liviopl.pl@gmail.com 2007-10-26 14:14 EST ------- You could replace PackageKit in Source0 with %{name}.

PS: I'm starting with packaging.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

------- Additional Comments From panemade@gmail.com 2007-10-26 23:26 EST ------- New version looks ok now.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

wtogami@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: PackageKit - Package management with dbus and policykit

https://bugzilla.redhat.com/show_bug.cgi?id=333451

rnorwood@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE