https://bugzilla.redhat.com/show_bug.cgi?id=872957
Bug ID: 872957 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: php-pear-XML-SVG - API for building SVG documents Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: fedora@famillecollet.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: https://raw.github.com/remicollet/remirepo/master/php/pear/php-pear-XML-SVG/... SRPM URL: http://rpms.famillecollet.com/SRPMS/php-pear-XML-SVG-1.1.0-1.remi.src.rpm Description: This package provides an object-oriented API for building SVG documents.
Fedora Account System Username: remi
Target: Fedora >= 17 and EPEL >= 5
https://bugzilla.redhat.com/show_bug.cgi?id=872957
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nb@fedoraproject.org
--- Comment #1 from Remi Collet fedora@famillecollet.com --- This is an optional dependency of php-horde-Horde-Image
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shawn.iwinski@gmail.com
--- Comment #2 from Shawn Iwinski shawn.iwinski@gmail.com --- * In package.xml, is this cross-project baseinstalldir normal?:
<file baseinstalldir="/Horde" md5sum="4c9de300b87bef9f2e967e1b71c1f639" name="docs/examples/basic.php" role="doc" /> <file baseinstalldir="/Horde" md5sum="0ca5fd8f47288120ebeeaa5a1f97daf3" name="docs/examples/radialGradient.php" role="doc" />
The files get installed into the correct PEAR document directory, but it just looks a little strange.
* In %prep, you might want to:
sed '/README/s/role="data"/role="doc"/' -i package.xml
(could also remove "%{pear_datadir}/%{pear_name}" from %files if this is done)
* In %files, instead of:
%{pear_phpdir}/XML
shouldn't it be:
%dir %{pear_phpdir}/XML %{pear_phpdir}/XML/SVG
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #3 from Remi Collet fedora@famillecollet.com --- (In reply to comment #2)
- In package.xml, is this cross-project baseinstalldir normal?:
XML_SVG is a part of the Horde project... (old one, before they have their own channel)
- In %prep, you might want to:
sed '/README/s/role="data"/role="doc"/' -i package.xml
Good catch... I shouldn't have miss it...
%dir %{pear_phpdir}/XML %{pear_phpdir}/XML/SVG
Yes could be more explicit.
Changes: https://github.com/remicollet/remirepo/commit/f8416ce3dcfb44d6e9a63859029c6f...
Spec URL: https://raw.github.com/remicollet/remirepo/master/php/pear/php-pear-XML-SVG/... SRPM URL: http://rpms.famillecollet.com/SRPMS/php-pear-XML-SVG-1.1.0-2.remi.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |shawn.iwinski@gmail.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #4 from Shawn Iwinski shawn.iwinski@gmail.com --- Created attachment 653201 --> https://bugzilla.redhat.com/attachment.cgi?id=653201&action=edit php-pear-XML-SVG-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 872957
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #5 from Shawn Iwinski shawn.iwinski@gmail.com --- === APPROVED ===
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Remi Collet fedora@famillecollet.com --- Thanks for the review
New Package SCM Request ======================= Package Name: php-pear-XML-SVG Short Description: API for building SVG documents Owners: remi Branches: f17 f18 el6 el5 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- php-pear-XML-SVG-1.1.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-pear-XML-SVG-1.1.0-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- php-pear-XML-SVG-1.1.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-pear-XML-SVG-1.1.0-2.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-pear-XML-SVG-1.1.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-pear-XML-SVG-1.1.0-2.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-pear-XML-SVG-1.1.0-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/php-pear-XML-SVG-1.1.0-2.el5
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-pear-XML-SVG-1.1.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2012-12-02 22:23:47
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-pear-XML-SVG-1.1.0-2.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-pear-XML-SVG-1.1.0-2.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- php-pear-XML-SVG-1.1.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872957
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- php-pear-XML-SVG-1.1.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository.
package-review@lists.fedoraproject.org