Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
Summary: Review Request: Veusz - a scientific plotting package Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: jeremy@jeremysanders.net QAContact: fedora-package-review@redhat.com
Spec URL: http://download.gna.org/veusz/rpms/review/veusz.spec SRPM URL: http://download.gna.org/veusz/rpms/review/veusz-0.10-3.src.rpm
This is my first Fedora package and I'm seeking a sponser. Thanks!
Description: Veusz is a scientific plotting package, designed to create publication-ready Postscript output. It features GUI, command-line, and scripting interfaces. Graphs are constructed from "widgets", allowing complex layouts to be designed. Veusz supports plotting functions, data with errors, keys, labels, stacked plots, multiple plots, contours, and fitting data.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
jeremy@jeremysanders.net changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
gemi@bluewin.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gemi@bluewin.ch
------- Additional Comments From gemi@bluewin.ch 2006-06-19 16:35 EST ------- I am not a sponsor, just a few comments: * the following directories must be owned: - /usr/lib/python2.4/site-packages/veusz - /usr/share/pixmaps/veusz * the icon is not displayed in the gnome main menu, using absolute path /usr/share/pixmaps/veusz/veusz.png works * to recognize .vsz files you must add a file to /usr/share/mime/packages that describes the mime type (look at the examples), then in %post and %postun you run /usr/bin/update-mime-database /usr/share/mime
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com
------- Additional Comments From panemade@gmail.com 2006-06-20 00:34 EST ------- Not an official review as I'm not yet sponsored To add above review i suggest you to go thru http://fedoraproject.org/wiki/Packaging/Python?highlight=%28CategoryExtras%2... for python packaging. This is because you have not added to SPEC file under %files %dir %{python_sitelib}/veusz
Also i did mock build for your package for i386 and found /var/tmp/veusz-0.10-3.fc6-root-mockbuild/usr/share/applications/fedora-veusz.desktop: warning: file contains key "Patterns", usage of this key is not recommended, since it has been deprecated so you can remove Patterns line from veusz.desktop file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
------- Additional Comments From jeremy@jeremysanders.net 2006-06-21 15:23 EST ------- Thanks for your useful comments! I've done the following: * Add an xml file to add application/x-veusz as a mime type * Fix the relative icon in the desktop file by using a symlink * Own the directories %{python_sitelib}/veusz and /usr/share/pixmaps/veusz * Run update-mime-database and update-desktop-database on post and postun * Removed the patterns keyword from the desktop file
The program now appears to be properly associated to .vsz in Gnome
Here are the new versions of the SRPM and spec: SRPM URL: http://download.gna.org/veusz/rpms/review/veusz-0.10-4.src.rpm Spec URL: http://download.gna.org/veusz/rpms/review/veusz.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
------- Additional Comments From panemade@gmail.com 2006-06-22 00:12 EST ------- rpmlint on new version shows no error successfully built on i386 development SPEC file is having no problem now
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
jpmahowald@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776, 177841 |163778 nThis| |
------- Additional Comments From jpmahowald@gmail.com 2006-06-25 18:39 EST ------- Commented, nice!
.pyo files should be %ghosted. http://fedoraproject.org/wiki/Packaging/Python
* Desktop file: the Categories tag should contain X-Fedora (wiki: Packaging/Guidelines#desktop) * Missing dependancy on update-desktop-database for %post (package desktop-file-utils) * Missing dependancy on update-desktop-database for %postun (package desktop-file-utils)
rpmlint clean as mentioned previously.
Fix these up and apply for cvsextras and I'll sponsor you and approve package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
jpmahowald@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |jpmahowald@gmail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
------- Additional Comments From jeremy@jeremysanders.net 2006-06-26 15:07 EST ------- Here are the new versions of the SRPM and spec: SRPM URL: http://download.gna.org/veusz/rpms/review/veusz-0.10-5.src.rpm Spec URL: http://download.gna.org/veusz/rpms/review/veusz.spec
Thanks very much for reviewing the package and offering to sponser me. I've done as you suggested. The %post and %postun update-desktop-database deps have been added. X-Fedora is now added to the .desktop file. The .pyo files were ghosted before (using an implicit veusz/*/*.pyo ghost), but now I've made them explicit. I hope this is okay.
I've opened an account (username jsanders), signed the CLA, and requested cvsextras membership. Thanks for your time.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
------- Additional Comments From jpmahowald@gmail.com 2006-06-27 22:20 EST ------- Not building on FC5 now.
/builddir/build/SOURCES/veusz.desktop: key "Categories" string list not semicolon-terminated, fixing
+ mv '/var/tmp/veusz-0.10-5.fc5-root-mockbuild/usr/lib/python2.4/site-packages/veusz/windows/icons/*.png' /var/tmp/veusz-0.10-5.fc5-root-mockbuild/usr/share/pixmaps/veusz mv: cannot stat `/var/tmp/veusz-0.10-5.fc5-root-mockbuild/usr/lib/python2.4/site-packages/veusz/windows/icons/*.png': No such file or directory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
------- Additional Comments From jeremy@jeremysanders.net 2006-06-28 16:17 EST ------- Thanks for the reply. I don't see why it is failing as I haven't touched anything to do with the png files, which are those mentioned in you error report. I think there was a semicolon missing at the end of the Categories field in the desktop file, which I've now fixed, but I have no idea how to fix the build failure. My Fedora Core machine running Development appears to build the package without problems. I need to try it with mock, but I don't have the bandwidth at the moment. Maybe there's some file corruption. Here is the latest version:
SRPM URL: http://download.gna.org/veusz/rpms/review/veusz-0.10-6.src.rpm Spec URL: http://download.gna.org/veusz/rpms/review/veusz.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
------- Additional Comments From jpmahowald@gmail.com 2006-07-04 22:35 EST ------- I'm building on x86_64. On this architecture %{python_sitelib} evaluates to /usr/lib/python2.4/site-packages while %{python_sitearch} is /usr/lib64/python2.4/site-packages. The build log shows the icon copy doing things like "copying windows/icons/stock-new.png -> /var/tmp/veusz-0.10-6.fc6-root-mockbuild/usr/lib64/python2.4/site-packages/veusz/windows/icons" And: in you mv command in the spec you use %{python_sitelib}. Change to %{python_sitearch}.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
------- Additional Comments From jeremy@jeremysanders.net 2006-07-07 16:30 EST ------- SRPM URL: http://download.gna.org/veusz/rpms/review/veusz-0.10-7.src.rpm Spec URL: http://download.gna.org/veusz/rpms/review/veusz.spec
Thanks for spotting that. I've fixed the sitearch/sitelib problem and tested the package on an x86_64 and an i386 system.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
jpmahowald@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From jpmahowald@gmail.com 2006-07-08 12:16 EST ------- The helper C module is the architcture dependent part.
rpmlint: W: veusz mixed-use-of-spaces-and-tabs The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Minor.
- package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file works - mime association works (no icon, minor) - runs
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195942
jeremy@jeremysanders.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From jeremy@jeremysanders.net 2006-07-17 15:31 EST ------- Appears to be in extras now. Closing. Thanks for the help.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Veusz - a scientific plotting package
https://bugzilla.redhat.com/show_bug.cgi?id=195942
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla