https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #1 from Miro Hrončok <miro(a)hroncok.cz&gt; --- Spec URL: https://raw.github.com/hroncok/SPECS/master/printrun.spec SRPM URL: http://repo.hroncok.cz/SRPMS/printrun-0.0-8.20120924gitb6935b93.fc17.src.rpm Links (ln -s) skeinforge dir, requires exact versions of subpackages. I've got W: dangling-relative-symlink now, but I think it is correct to link to a file that belongs to a package I require, right? -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #3 from Miro Hrončok <miro(a)hroncok.cz&gt; --- Spec URL: https://raw.github.com/hroncok/SPECS/master/printrun.spec SRPM URL: http://repo.hroncok.cz/SRPMS/printrun-0.0-10.20120924gitb6935b93.fc17.src... - Switched generic names and names in desktop files - Don't use rm, cp and ln -s macros -- You are receiving this mail because: You are on the CC list for the bug.

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 Mario Blättermann <mario.blaettermann(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann(a)gmail.co | |m Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug.

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 Volker Fröhlich <volker27(a)gmx.at&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27(a)gmx.at --- Comment #6 from Volker Fröhlich <volker27(a)gmx.at&gt; --- The last SRPM link is dead. -- You are receiving this mail because: You are on the CC list for the bug.

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #8 from Miro Hrončok <miro(a)hroncok.cz&gt; --- Spec URL: https://raw.github.com/hroncok/SPECS/master/printrun.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/printrun-0.0-13.20121103git6fa... - Do not download the desktop files from my GitHub -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nkXKEUSxZk&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #10 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- Spec URL: https://raw.github.com/hroncok/SPECS/master/printrun.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/printrun-0.0-15.20121103git6fa... - Updated to respect new GitHub rule -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gBgf9r4nHw&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 Pete Travis <me(a)petetravis.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody(a)fedoraproject.org |me(a)petetravis.com Whiteboard| | NotReady Flags| |needinfo+ Flags| |needinfo?(mhroncok(a)redhat.c | |om) --- Comment #12 from Pete Travis <me(a)petetravis.com&gt; --- Hey Miro, I'd like to tackle this review, assuming you have a sponsor. Please bear with me - I'm new at this, but I'm not afraid to ask for help :) A couple comments after a quick look: Cited license is AGPLv3, but the included COPYING file is GPLv3. These should match. Not all included files use the same licence, and some files do not declare a license. The relationship between `printrun` and `skeinforge` is a little confusing. The SPEC for printrun looks like it is working with skeinforge files and directories. You'll want to make sure there are no conflicts between these related packages. There are no upstream URLs for Source1, Source2, Source3. All sources should have a valid URL. You're using the generated pronterface.lang with the common package; it should probably go with the pronterface files rpmlint complains about macros in changelog; you probably don't need to be so specific about the change made. The locales loop is failing in my build log, you should investigate. I hope this helps get the ball rolling, will check in again soon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tI8x3wkM73&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #14 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- (In reply to comment #12) I see GPLv3 in the spec. Are we looking at the same file? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=noctXORH4g&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #16 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- - Pronterface lang moved from common to pronterface, is not needed by pronsole any more -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c4fxOay6PJ&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #17 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- Spec URL: https://raw.github.com/hroncok/SPECS/master/printrun.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/printrun-0.0-17.20121103git589... - New "version" (bugfix) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SkwfsI0l8M&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #19 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- Spec URL: https://raw.github.com/hroncok/SPECS/master/printrun.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/printrun-0.0-18.20130113git589... Adding my patch from https://github.com/kliment/Printrun/pull/318 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TeUgvHtaTg&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 Pete Travis <me(a)petetravis.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(me(a)petetravis.com | |) | Flags| |fedora-review+ Flags| |fedora_requires_release_not | |e+ --- Comment #21 from Pete Travis <me(a)petetravis.com&gt; --- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. x -- No licensing issues. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: %build honors applicable compiler flags or justifies otherwise. x -- No compiler flag issues. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [ ]: Package contains no bundled libraries. x -- No bundled libraries. [ ]: Changelog in prescribed format. x -- Changelog is properly formatted [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [ ]: Sources contain only permissible code or content. x -- No permissibility issues. [x]: Each %files section contains %defattr if rpm < 4.4 [ ]: Macros in Summary, %description expandable at SRPM build time. - -- No macros in summary, descriptions [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [ ]: Development files must be in a -devel package - -- No development files [ ]: Package requires other packages for directories it uses. x -- No directory conflicts [ ]: Package uses nothing in %doc for runtime. x -- Only apropriate files in %doc [ ]: Package is not known to require ExcludeArch. - -- No arch issues. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package -n plater, %package common, %package -n pronterface, %package -n pronsole - -- noarch packages; dependencies are appropriately declared. [ ]: Package complies to the Packaging Guidelines x -- [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v3 or later)", "GPL (v3 or later)", "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/makerpm/rpmbuild/863796-printrun/licensecheck.txt x -- Undeclared individual files are inheriting license of project [ ]: License file installed when any subpackage combination is installed. - -- No upstream license files; please raise the issue upstream [ ]: The spec file handles locales properly. x -- Spec file is not translating, no errors. [ ]: Package consistently uses macro is (instead of hard-coded directory names). x -- [x]: Package is named using only allowed ASCII characters. [ ]: Package is named according to the Package Naming Guidelines. x -- No name issues. [ ]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) x -- No Conflicts. [x]: Package do not use a name that already exist [ ]: Package obeys FHS, except libexecdir and /usr/target. x -- FHS Compliant. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. - -- not applicable [ ]: Package must own all directories that it creates. x -- No directory conflicts. [ ]: Package does not own files or directories owned by other packages. x -- No file conflicts. [!]: Package installs properly. Note: Installation errors (see attachment) x -- Depends on other package recently reviewed; tested to install properly when dependencies are available. [ ]: Package is not relocatable. x -- [ ]: Requires correct, justified where necessary. x -- Requires are correct and trimmed. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [ ]: Spec file is legible and written in American English. x -- [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [ ]: Package contains systemd file(s) if in need. - -- Not required [x]: File names are valid UTF-8. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 256000 bytes in 20 files. - -- not required. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Package contains BR: python2-devel or python3-devel [ ]: Binary eggs must be removed in %prep Note: Cannot find sources under BUILD (using prebuilt sources?) - -- No binaries, just an egg-defined dir in site-packages. [ ]: Python eggs must not download any dependencies during the build process. x -- [ ]: A package which is used by another package via an egg interface should provide egg info. x -- Package does provide egg info [ ]: Package meets the Packaging Guidelines::Python x -- ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. - -- No license files included, you should query upstream [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [ ]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). x -- [ ]: Package functions as described. x -- [ ]: Latest version is packaged. x -- [ ]: Package does not include license text files separate from upstream. x -- [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. x -- Filed and cited. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source2 (pronterface.desktop) Source3 (plater.desktop) Source1 (pronsole.desktop) [x]: SourceX is a working URL. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed x -- rpmlint only complains about spelling of subpackage names. Package does build. [x]: Spec file according to URL is the same as in SRPM. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. I see no issues here. Thanks for your contribution, Miro! This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E4oPAVnWD3&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 Miro Hrončok <mhroncok(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs? --- Comment #22 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- New Package SCM Request ======================= Package Name: printrun Short Description: RepRap printer interface and tools Owners: churchyard Branches: f17 f18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5JbDyNB0ZS&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NeoDg4cNxk&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #25 from Fedora Update System <updates(a)fedoraproject.org&gt; --- printrun-0.0-19.20130113git5897fbc.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/printrun-0.0-19.20130113git5897fb... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cLy6qmJP9G&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #27 from Fedora Update System <updates(a)fedoraproject.org&gt; --- printrun-0.0-22.20130123git71e5da0.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/printrun-0.0-22.20130123git71e5da... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M2I0iJgBfn&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JMT5rVRf8Y&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-02-01 23:16:53 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OjCNOhzVlu&a=cc_unsubscribe

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863796 --- Comment #30 from Fedora Update System <updates(a)fedoraproject.org&gt; --- printrun-0.0-22.20130123git71e5da0.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M0wZaSsnBU&a=cc_unsubscribe

https://bugzilla.redhat.com/show_bug.cgi?id=863796 Bug 863796 depends on bug 863793, which changed state. Bug 863793 Summary: Review Request: skeinforge - Converts 3D model into G-Code for RepRap https://bugzilla.redhat.com/show_bug.cgi?id=863793 What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component