https://bugzilla.redhat.com/show_bug.cgi?id=2021029
Bug ID: 2021029 Summary: Review Request: phonesim - Phone Simulator for modem testing Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: thunderbirdtr@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pagure.io/phonesim/raw/main/f/phonesim.spec SRPM URL: https://pagure.io/phonesim/raw/main/f/phonesim-1.21-1.fc35.src.rpm Description: phonesim is a soft modem that eliminates the need to have an actual AT modem connected to the system for testing and developing Ofono.
Fedora Account System Username: thunderbirdtr
Pagure URL : https://pagure.io/phonesim
https://bugzilla.redhat.com/show_bug.cgi?id=2021029
Artur Frenszek-Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl Doc Type|--- |If docs needed, set a value
--- Comment #1 from Artur Frenszek-Iwicki fedora@svgames.pl ---
%configure %{__make} %{?_smp_mflags}
1. Using macro forms of system executables (%{__make}, %{__rm}, etc.) is discouraged. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros 2. "%make_build" is preferred for building.
%files %{_datarootdir}/%{name}/default.xml
This will make the package own the "/usr/share/phonesim/default.xml" file, but not the "/usr/share/phonesim" directory. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories...
Also, the license file is not included in the package. Add "%license COPYING" under %files.
https://bugzilla.redhat.com/show_bug.cgi?id=2021029
Justin Zobel justin.zobel@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |justin.zobel@gmail.com
--- Comment #2 from Justin Zobel justin.zobel@gmail.com --- I believe this can now be abandoned as it is part of ofono and no longer used by the Plasma Mobile stack.
https://bugzilla.redhat.com/show_bug.cgi?id=2021029
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(thunderbirdtr@fed | |oraproject.org) CC| |pemensik@redhat.com
--- Comment #3 from Petr Menšík pemensik@redhat.com --- There were recently released version 2.0 [1]. This package might need version update or closing the review bug. Please close this review is you do not want to include this package anymore. Is it still useful to be included?
[1] https://git.kernel.org/pub/scm/network/ofono/phonesim.git/tag/?h=2.0
package-review@lists.fedoraproject.org