https://bugzilla.redhat.com/show_bug.cgi?id=1692560 Robert-André Mauchin <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m(a)gmail.com --- Comment #2 from Robert-André Mauchin <zebob.m(a)gmail.com&gt; --- - Use macros and better name for your archive: Source0: https://github.com/jfcoz/postgresqltuner/archive/%{version}/%{name}-%{ver... - use perl() for all your dep please: Requires: perl(DBI) Requires: perl(DBD::Pg) Requires: perl(Term::ANSIColor) - Add all BR: Requires: perl(Getopt::Long) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 Robert-André Mauchin <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com Flags| |fedora-review+ --- Comment #4 from Robert-André Mauchin <zebob.m(a)gmail.com&gt; --- Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)". 7 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/postgresqltuner/review- postgresqltuner/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: postgresqltuner-1.0.1-4.fc31.noarch.rpm postgresqltuner-1.0.1-4.fc31.src.rpm postgresqltuner.noarch: W: spelling-error %description -l en_US mysqltuner -> mysteriousness postgresqltuner.noarch: W: no-manual-page-for-binary postgresqltuner postgresqltuner.src: W: spelling-error %description -l en_US mysqltuner -> mysteriousness postgresqltuner.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 4 warnings. You will still need to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 Mikel Olasagasti Uranga <mikel(a)olasagasti.info&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m(a)gmail.com | |) --- Comment #6 from Mikel Olasagasti Uranga <mikel(a)olasagasti.info&gt; --- Hi Robert, I've a sponsor now and I tried to `request_repo` for this package, but it complains that 'review was approved over 60 days ago'. Can you re-approve this package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; --- (In reply to Mikel Olasagasti Uranga from comment #6) Sorry I'm deep into Go packaging, I didn't check my Bugzilla mail. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED --- Comment #9 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-2020-40c75bb11a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-40c75bb11a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 --- Comment #11 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-2020-9b95b9e6e7 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9b95b9e6e7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 --- Comment #13 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-EPEL-2020-2f9876b6cf has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-2f9876b6cf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 --- Comment #15 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-EPEL-2020-2f9876b6cf has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-2f9876b6cf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 --- Comment #17 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-EPEL-2020-d884e10277 has been pushed to the Fedora EPEL 6 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-d884e10277 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-08-23 01:03:35 --- Comment #19 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-2020-40c75bb11a has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 --- Comment #21 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-EPEL-2020-2f9876b6cf has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1692560 --- Comment #23 from Fedora Update System <updates(a)fedoraproject.org&gt; --- FEDORA-EPEL-2020-d884e10277 has been pushed to the Fedora EPEL 6 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component