Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508066 Jason Tibbitts <tibbs(a)math.uh.edu&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody(a)fedoraproject.org |tibbs(a)math.uh.edu Flag| |fedora-review? --- Comment #2 from Jason Tibbitts <tibbs(a)math.uh.edu&gt; 2009-07-01 16:51:16 EDT --- Not much to this one. Is there any part of the test suite which could be run at build time? At least some of the tests don't seem to require a database server. Why not build the documentation? It's not exactly user-friendly to provide raw tex source and a Makefile. * source files match upstream. sha256sum: a4dcac0d5ac6ae9145301fd804de238d20d5ec960e7af2a25b6df850d1f8b782 python- sybase-0.39.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: sybasect.so()(64bit) python-sybase = 0.39-1.fc12 python-sybase(x86-64) = 0.39-1.fc12 = libct.so.4()(64bit) libpython2.6.so.1.0()(64bit) python(abi) = 2.6 ? %check is not present but there seems to be a test suite. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508066 --- Comment #4 from Yanko Kaneti <yaneti(a)declera.com&gt; 2009-07-06 10:39:12 EDT --- This the shortest I've achieved at getting a doc built. Open to any suggestions on how to deal with it better. SPEC: http://declera.com/~yaneti/python-sybase/python-sybase.spec SRPM: http://declera.com/~yaneti/python-sybase/python-sybase-0.39-2.fc12.src.rpm * Mon Jul 6 2009 Yanko Kaneti <yaneti(a)declera.com&gt; - 0.39-2 - Try harder to build human readable documentation - Move the sybasect.so chmod after the install phase -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508066 Yanko Kaneti <yaneti(a)declera.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #6 from Yanko Kaneti <yaneti(a)declera.com&gt; 2009-07-08 13:43:36 EDT --- New Package CVS Request ======================= Package Name: python-sybase Short Description: Python interface to Sybase Owners: yaneti Branches: F-10 F-11 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508066 Yanko Kaneti <yaneti(a)declera.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE --- Comment #8 from Yanko Kaneti <yaneti(a)declera.com&gt; 2009-07-08 16:21:01 EDT --- Imported. Builds done. Bodhi updates penging. I added a small comment wrt the tests. Also enabled an upstream compile option for using threads. Could be a little buggy but not in the packaging sense. Thanks again for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.