[Bug 1979315] New: Review Request: python-lsp-server - Python implementation of language server protocol
10:14 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
Bug ID: 1979315
Summary: Review Request: python-lsp-server - Python
implementation of language server protocol
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: nonamedotc(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-...
SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-...
Description:
A python implementation of language server protocol. This package provides
the community maintained version of python-language-server.
Fedora Account System Username: nonamedotc
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:14 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
Mukundan Ragavan <nonamedotc(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends On| |1979275
Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1979275
[Bug 1979275] Review Request: python-lsp-jsonrpc - Python implementation of
JSON RPC 2.0 protocol
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:16 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
Mukundan Ragavan <nonamedotc(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1979316
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1979316
[Bug 1979316] Review Request: python-lsp-black - A python-lsp-server plugin
that adds support to black autoformatter
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:17 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
Mukundan Ragavan <nonamedotc(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|1979316 |
--- Comment #1 from Mukundan Ragavan <nonamedotc(a)gmail.com> ---
Full build logs are here -
https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder5dev/builds/
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1979316
[Bug 1979316] Review Request: python-lsp-black - A python-lsp-server plugin
that adds support to black autoformatter
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:18 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
Mukundan Ragavan <nonamedotc(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1979316
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1979316
[Bug 1979316] Review Request: python-lsp-black - A python-lsp-server plugin
that adds support to black autoformatter
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:01 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
--- Comment #2 from Mukundan Ragavan <nonamedotc(a)gmail.com> ---
Since pylsp requires pycodestyle, PR updating pyflakes, flake8 and pycodestyle
have been submitted.
Builds can be seen here -
https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder5dev/builds/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:25 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbyszek(a)in.waw.pl
--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
A python implementation of language server protocol. This package
provides
the community maintained version of python-language-server.
That's very circular: if I don't already know what "python language
server" is,
this
tells me nothing. Is /bin/pylsp the main "entry point" for this package, i.e.
are users
expected to call this directly? Or will this mostly be used as a library and/or
backend
by other packages?
Also note that the %description has an empty leading line like in #1979275.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:34 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
--- Comment #4 from Mukundan Ragavan <nonamedotc(a)gmail.com> ---
Updated SPEC URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-...
Updated SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-lsp-...
Changes from previous spec are -
- updated description
- use pypi_source macro
- avoid empty leading line in description
- remove egg cleanup
mock build is running here -
https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder5dev/build/2316171/
I disabled two tests that fail because I could not figure out how to fix it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:35 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
--- Comment #5 from Mukundan Ragavan <nonamedotc(a)gmail.com> ---
koji scratch build now that jsonrpc is built on rawhide -
https://koji.fedoraproject.org/koji/taskinfo?taskID=71466427
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:36 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
Bug 1979315 depends on bug 1979275, which changed state.
Bug 1979275 Summary: Review Request: python-lsp-jsonrpc - Python implementation of JSON
RPC 2.0 protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979275
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Resolution|--- |RAWHIDE
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:34 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl
Flags| |fedora-review+
--- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
This package provides the community maintained version of
python-language-server.
This is still unclear… Everything in Fedora is "community maintained". I assume
that
there's some paid version? Please be more explicit.
Review:
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ BR/R/P seem correct
+ %check is present and passes
rpmlint:
python-lsp-server.src: E: description-line-too-long C This package
provides the community maintained version of python-language-server.
Please wrap.
fedora-review doesn't find any issues.
Suggestion: add "Provides:pylsp".
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:36 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
--- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
How is the user supposed to launch this? Should it have a systemd user service
file?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:46 p.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
--- Comment #8 from Gwyn Ciesla <gwync(a)protonmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-lsp-server
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:48 p.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
--- Comment #9 from Mukundan Ragavan <nonamedotc(a)gmail.com> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> This package provides the community maintained version of
python-language-server.
This is still unclear… Everything in Fedora is "community maintained". I
assume that
there's some paid version? Please be more explicit.
Yeah, I should have mentioned spyder-IDE team. I will add spyder-IDE team
explicitly - not palantir or microsoft.
Review:
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ BR/R/P seem correct
+ %check is present and passes
rpmlint:
> python-lsp-server.src: E: description-line-too-long C This package provides the
community maintained version of python-language-server.
Please wrap.
Will do.
fedora-review doesn't find any issues.
Suggestion: add "Provides:pylsp".
I will do this in import.
Package is APPROVED.
Thanks for the review.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
How is the user supposed to launch this? Should it have a systemd
user
service file?
This package is consumed by editors (at the moment, only spyder). As far as I
know, end user does not run this directly.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:23 a.m.
New subject: [Bug 1979315] Review Request: python-lsp-server - Python
implementation of language server protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1979315
Mukundan Ragavan <nonamedotc(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2021-07-09 15:23:45
--- Comment #10 from Mukundan Ragavan <nonamedotc(a)gmail.com> ---
built on rawhide.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1023
days inactive
1027
days old
package-review@lists.fedoraproject.org
14 comments
1 participants
participants (1)
-
bugzilla＠redhat.com