Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

Dominik 'Rathann' Mierzejewski rpm@greysector.net changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |462851

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

--- Comment #2 from Dominik 'Rathann' Mierzejewski rpm@greysector.net 2009-03-09 08:06:30 EDT --- (In reply to comment #1)

I'd question whether this sort of package is even needed in Fedora.

The killswitches can be handled through HAL and an interface to it,

They don't work currently and yes, I know, I should submit a bug report. I will when I have some time to sit on it. In the meantime, I've found this little tool which works (at least partially), so I packaged it for myself and decided to share with the rest of Fedora.

brightness should be handled through either HAL, or X11,

Setting brightness works already and this tool doesn't even touch it.

and the rest of the configuration should probably have nice defaults, instead of requiring users to toggle the "smart fan control".

Maybe, but there's also a setting that overclocks the CPU to 1.8GHz (1.6GHz is normal). Do we have something like that in Fedora? And besides, with all that Windows-mimicking going on lately, why oppose the inclusion of a tool that Eee users have present in their Windows XP installations? ;)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

Bastien Nocera bnocera@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|462851(FedoraMini) |

--- Comment #4 from Bastien Nocera bnocera@redhat.com 2009-03-09 19:45:42 EDT --- Windows mimicking? Anyway, that's besides the point. There are standard interfaces for killswitches, hotkey setup, and brightness control[1]. So this shouldn't be on the tracker for netbook bugs. Fixing whatever needs fixing to use the standard interfaces should be.

[1]: You say it doesn't touch brightness, but http://greg.geekmind.org/eee-control/#features lists "Extended LCD brightness (brighter and darker than the default range, not supported on all models)"

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

--- Comment #6 from Guido Grazioli guido.grazioli@gmail.com 2009-03-10 09:54:03 EDT --- I'm a novice with bugzilla but here are my two cents: * the super performance setting overclocks the fsb, so if you also have cpufreq-applet in the tray, it looks inconsistent (it continues to report the max available scaling freq) * overclocking my 900 model while running a yum transaction crashes my system at 85°C core temp * the graphics used as tray-icon is possibly a reg. trademark

I was interested in this package initially, but maybe could be left to some 3rd party repo

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

Chris Bagwell chris@cnpbagwell.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@cnpbagwell.com

--- Comment #8 from Chris Bagwell chris@cnpbagwell.com 2009-05-15 13:44:07 EDT --- Just chiming in. I don't have much use for overlapping features of this as well but there are a few items that are not overlapping that I'd like to use.

- FSB overclocking. If you have a 900 with infamously slow 16G SSD then this makes a noticeable difference in usability (under Windows XP anyways).

- Automatic FSB overclocking. By that I mean something that monitors when your on battery power and disables overclocking and also notifiws you. Not sure I wish to use this feature unless the daemon is also actively monitoring CPU temp. and also disabling. Going purely from Comment #6 it might not be... but then whats the related "smart fan control" about?

- Tray menu to disable Webcam and Card Reader. Looking around /sys/bus, it looks like the onboard card reader does not support auto suspending. It would be nice to disable that device when on battery for extended periods. Disabling Wifi and Bluetooth overlaps with keyboard toggles but a common menu for all devives would be nice.

Overclocking is a questionable reason to package this since harm could occur to hardware... but the power savings feature of disabling hardware is more interesting.

Current rawhide is looking very good, power wise, and I have no numbers to back up disabling card reader or webcam results in noticeable savings.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

--- Comment #9 from Chris Bagwell chris@cnpbagwell.com 2009-06-23 23:52:22 EDT --- Created an attachment (id=349189) --> (https://bugzilla.redhat.com/attachment.cgi?id=349189) Updated spec to 0.9.3 release

My eee pc was feeling sluggish so I went ahead and updated spec file to support latest release of eee-control. This will install a /etc/eee-control.conf that enables all features; even without custom kernel module.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

Bill McGonigle bill-bugzilla.redhat.com@bfccomputing.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |bill-bugzilla.redhat.com@bf | |ccomputing.com

--- Comment #11 from Bill McGonigle bill-bugzilla.redhat.com@bfccomputing.com 2009-08-06 14:22:01 EDT --- Regarding the latest build, it builds and installs correctly for me (f11 on an 1000he). Starting the service does:

http://fpaste.org/MnH2/

More generally, is there something exposed to set the FSB speed in Fedora already?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

--- Comment #13 from Chris Bagwell chris@cnpbagwell.com 2009-08-06 14:45:43 EDT --- I've lost access to my eee-pc so I can't help debug things now. From ouptut in #11 it looks like perhaps you've misconfigured your /etc/eee-control.conf. Since upgrading/installing RPM won't overwrite an old copy, you may want to delete it before installing RPM.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

Christoph Wickert fedora@christoph-wickert.de changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@christoph-wickert.de

--- Comment #15 from Christoph Wickert fedora@christoph-wickert.de 2009-08-06 18:57:18 EDT --- I doubt we are allowed to ship eee-icon.png. I also want to remind you of https://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or...

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

--- Comment #17 from Christoph Wickert cwickert@fedoraproject.org 2010-03-07 09:26:34 EST --- Why don't you get involved? Submit a package, become a packager and review this package.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

--- Comment #19 from Christoph Wickert cwickert@fedoraproject.org 2010-03-08 16:15:19 EST --- (In reply to comment #18)

I think we can do better than "why don't you become a computer programmer if you want this to proceed?".

Nobody expects somebody to become a programmer, we are talking about packaging and reviewing here. In case you didn't konw, Valent already is a Fedora ambassador for years now and as such it should be possible for him to read the packaging and the review guidelines in order to get involved instead of just nagging other people for ages.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

--- Comment #21 from Valent Turkovic valent.turkovic@gmail.com 2010-03-08 17:15:11 EST --- I'm working on other project to make Fedora better and making a custom Fedora remix, taking over management of Fedora Geo spin and lots of other things... and asking politely for a update on progress of this package.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

--- Comment #23 from Jason Tibbitts tibbs@math.uh.edu 2010-11-02 19:18:17 EDT --- It doesn't appear that there's been any comment from the submitter since March of 2009. Can we just close this now?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

Ruediger Landmann r.landmann@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |r.landmann@redhat.com Flag| |needinfo?(rpm@greysector.ne | |t)

--- Comment #25 from Ruediger Landmann r.landmann@redhat.com 2010-11-11 20:48:18 EST --- Thanks Chris.

Dominik, in light of Chris' statements in comment #24, are you still interested in packaging eee-control for Fedora? Or should this request now be closed?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

Jason Tibbitts tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |StalledSubmitter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

Jason Tibbitts tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|StalledSubmitter |

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

--- Comment #29 from Dominik 'Rathann' Mierzejewski rpm@greysector.net 2010-11-13 20:52:17 EST --- (In reply to comment #28)

...

rfkill doesn't work for my bluetooth, eee-control does.

I peeked into eee-control-daemon script and it looks like its using rfkill to turn off bluetooth. Can you expand on what you mean?

Actually, it seems that my bluetooth device got into some strange state and I kept getting usb errors in dmesg. A hard reset (poweroff and take out the battery) seems to have helped. Now both eee-control and rfkill work fine.

Does your Fn-F2 key turn off wlan but not bluetooth? Or are you just saying you want a control that turns off bluetooth but not wlan (eee-control gives a GUI to toggle just one using rfkill).

Is there another gui? It seems a bit stupid to have to use root priviledges just to turn bluetooth on/off.

Thats a fair statement and why I threw in "above 9 inches" part. So probably these 9 and 7 inch models need the disable HW features and Super Hybrid Engine parts where as above 9 inches need only SHE part.

Maybe that could be made part of the acpi-cpufreq or thereabouts?

BTW: Since I last last wrote, I found out we can get touchpad toggle working out of the box. We just need to change eeepc-laptop/wmi to send F22 instead of F13. I'm working with upstream (kernel and udev) to get this working.

Cool!

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

Ruediger Landmann r.landmann@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |r.landmann@redhat.com Flag| |fedora-review?, | |needinfo?(rpm@greysector.ne | |t)

--- Comment #31 from Ruediger Landmann r.landmann@redhat.com 2010-11-14 19:44:55 EST --- Thanks Dominik!

Just a few things here that need attention.

Also note that unless you plan to package this for EPEL, you don't need: * the BuildRoot: * rm -rf %{buildroot} under %install * the %clean section.

Please rebuild to fix the issues below:

- = N/A / = Check ! = Problem ? = Not evaluated

=== REQUIRED ITEMS === [!] Rpmlint output is clean: $ rpmlint SPECS/eee-control.spec SPECS/eee-control.spec:10: W: macro-in-comment %{name} SPECS/eee-control.spec:10: W: macro-in-comment %{version} SPECS/eee-control.spec: W: invalid-url Source0: eee-control-0.9.6.tar.gz 0 packages and 1 specfiles checked; 0 errors, 3 warnings.

$ rpmlint SRPMS/eee-control-0.9.6-1.fc14.src.rpm eee-control.src: W: spelling-error Summary(en_US) Asus -> Aus, Asur, Apus eee-control.src: W: spelling-error %description -l en_US hotkeys -> hot keys, hot-keys, hotcakes eee-control.src:10: W: macro-in-comment %{name} eee-control.src:10: W: macro-in-comment %{version} eee-control.src: W: invalid-url Source0: eee-control-0.9.6.tar.gz 1 packages and 0 specfiles checked; 0 errors, 5 warnings.

$ rpmlint RPMS/i686/eee-control-0.9.6-1.fc14.i686.rpm eee-control.i686: W: spelling-error Summary(en_US) Asus -> Aus, Asur, Apus eee-control.i686: W: spelling-error %description -l en_US hotkeys -> hot keys, hot-keys, hotcakes eee-control.i686: W: non-conffile-in-etc /etc/xdg/autostart/eee-control-tray.desktop eee-control.i686: W: spurious-executable-perm /usr/share/doc/eee-control-0.9.6/eee-dispswitch.sh eee-control.i686: W: spurious-executable-perm /usr/share/doc/eee-control-0.9.6/eee-control-query eee-control.i686: W: no-manual-page-for-binary eee-control-daemon eee-control.i686: W: no-manual-page-for-binary eee-control-tray eee-control.i686: W: service-default-enabled /etc/rc.d/init.d/eee-control-daemon eee-control.i686: W: incoherent-subsys /etc/rc.d/init.d/eee-control-daemon $prog eee-control.i686: W: incoherent-init-script-name eee-control-daemon ('eee-control', 'eee-controld') 1 packages and 0 specfiles checked; 0 errors, 10 warnings.

$ rpmlint RPMS/i686/eee-control-debuginfo-0.9.6-1.fc14.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

eee-control.spec: W: invalid-url Source0: eee-control-0.9.6.tar.gz See notes below on tarball

eee-control.i686: W: non-conffile-in-etc /etc/xdg/autostart/eee-control-tray.desktop This is as expected, no problem

eee-control.i686: W: spurious-executable-perm /usr/share/doc/eee-control-0.9.6/eee-dispswitch.sh eee-control.i686: W: spurious-executable-perm /usr/share/doc/eee-control-0.9.6/eee-control-query These (and eee-control-setup.sh) shouldn't be in doc, should they?

eee-control.i686: W: service-default-enabled /etc/rc.d/init.d/eee-control-daemon This is intentional and necessary, right?

eee-control.i686: W: incoherent-subsys /etc/rc.d/init.d/eee-control-daemon $prog eee-control.i686: W: incoherent-init-script-name eee-control-daemon ('eee-control', 'eee-controld') The init script name should be the same as the package name in lower case.

[/] Package is named according to the Package Naming Guidelines. [/] Spec file name must match the base package %{name}, in the format %{name}.spec. [/] Package meets the Packaging Guidelines including the Language specific items [!] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. As Christoph Wickert points out in Comment #15, the package contains Asus' Eee logo, in eee-icon.png and eee-icon-small.png. Where do the other icons in the same directory come from?

[!] License field in the package spec file matches the actual license. ISC license properly identified for the main file, but some icons in /usr/share/eee-control are from the GNOME icon set, which is GPL (see icons here: http://people.freedesktop.org/~jimmac/icons/#git and license here: http://art.gnome.org/ )

[-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-] Spec file is legible and written in American English. [!] Sources used to build the package matches the upstream source, as provided in the spec URL. The git operations you documented got me the source, but I couldn't generate a tarball with the same md5sum. Please note the steps you used to generate the tarball; this will have to include removing the Eee logos noted above, since if we can't ship these in the binary, we can't ship them in source either.

[/] Package successfully compiles and builds into binary rpms on at least one supported architecture. Builds for i686: http://koji.fedoraproject.org/koji/taskinfo?taskID=2599687 [/] Package is not known to require ExcludeArch Package uses ExclusiveArch as it is specific to 32-bit x86 machines [/] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [/] The spec file handles locales properly (with the %find_lang macro) [-] ldconfig called in %post and %postun if required. [/] Package does not bundle copies of system libraries [/] Package is not relocatable. [/] Package must own all directories that it creates. [/] Package does not contain duplicates in %files. [!] Permissions on files are set properly Check the various scripts currently in /usr/share/doc/eee-control-0.9.6/

[/] %files section includes a %defattr(...) line [/] Package consistently uses macros. [-] Large documentation files are in a -doc subpackage, if required. [!] Package uses nothing in %doc for runtime. Check the various scripts currently in /usr/share/doc/eee-control-0.9.6/

[-] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [-] Development .so files in -devel subpackage, if present. [-] -devel packages require base package with full versioning. [/] Package does not contain any libtool archives (.la). [/] Package contains a properly installed %{name}.desktop file if it is a GUI application. [/] Package does not own files or directories owned by other packages. [/] Filenames are valid UTF-8

=== SUGGESTED ITEMS ===

[/] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [/] Reviewer should test that the package builds in mock. Tested through koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2599687 [/] Package should compile and build into binary rpms on all supported architectures. [?] Package functions as described. [/] Scriptlets must be sane, if used. [-] Subpackages other than -devel require the base package as a fully versioned dependency [-] The placement of pkgconfig(.pc) files is correct (normally in -devel) [-] File based requires are sane. [!] Package contains man pages for binaries and scripts. Unfortunately, package contains no man pages, but this is not a blocker.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

Iskren Ivov Chernev iskren.chernev@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |iskren.chernev@gmail.com

--- Comment #33 from Iskren Ivov Chernev iskren.chernev@gmail.com 2011-10-09 11:08:22 EDT --- The latest version of this package I can find is eee-control-0.9.6-1.fc13.i686 It doesn't run out of the box on F14+, because of some minor issues with python version and ioport. I've made it work on my machine, but I haven't packaged it (I'm not very proficient in making rpms). I don't have the spec/src.rpm package for that release but there is a mandriva srpm here: http://rpm.pbone.net/index.php3/stat/4/idpl/16622114/dir/mandrake_other/com/...

The two features of the package that are not provided by anything else are (IMO): - CPU fsb options (performance, normal, powersave). This is using /sys/devices/platform/eeepc/cpufv for this, which comes from eeepc-laptop kernel module - fan control / information. This is using some ioports hardcoded in the app.

If you know any of these two being provided by something else, or at least for a different laptop model, so the packages can be merged.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=487044

--- Comment #35 from Iskren Ivov Chernev iskren.chernev@gmail.com 2011-10-21 08:40:12 EDT --- (In reply to comment #34)

I guess that leaves the fan control / info not provided by another package but I've never used that part so do not know enough to look at what options are available.

The lm_sensors package gives fan speed and CPU temperature, and the fancontrol program (from the package) can be used to set the speed of the fan according to the CPU temp.

This fancontrol program is not packaged like a daemon, but this shouldn't be hard to do.