https://bugzilla.redhat.com/show_bug.cgi?id=1813860
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |thrnciar(a)redhat.com
--- Comment #4 from Miro Hrončok <mhroncok(a)redhat.com> ---
For the review: Before you do a review, always assign the bugzilla you
yourself. I've done that now.
For the spec sanity:
Requires: python3dist(pip)
Requires: python3dist(setuptools)
Requires: python3dist(toml)
Why are those needed? Why are the automatic requires not working? There is an
automatic requirement on setuptools, but not on pip or toml. Is the upstream
metadata OK?
%description
A lightweight wrapper for pip to support Pipenv and Poetry lock files or \
converting them to pip-tools compatible output.
The backslash is a possible leftover form when description was defined via a
macro.
# Remove bundled egg-info
rm -rf %{name}.egg-info
Is this needed? Why?
# Remove shebang line from the module
sed -i '1{\@^#!/usr/bin/env python@d}' %{buildroot}/%{python3_sitelib}/%{name}.py
Is it possible to do this in %prep? Or does that affect both the executable in
%{_bindir} and this file?
%{__python3} -m pytest
The new proper way of doing this is to use %{python3} over %{__python3}.
%{python3_sitelib}/__pycache__/*
%{python3_sitelib}/%{name}.py
You can use the new %pycached macro:
%pycached %{python3_sitelib}/%{name}.py
%{python3_sitelib}/%{name}-%{version}-py?.?.egg-info
This will break with Python 3.10.
Also, please use a trailing slash to ensure this is and remains a directory.
See also problems with
https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Repla...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component