https://bugzilla.redhat.com/show_bug.cgi?id=824057
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> ---
Review:-
+ Koji build used ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4094896
+ rpmlint on rpms gave
fcitx-hangul.src: W: spelling-error %description -l en_US libhangul -> Hangul
fcitx-hangul.src: W: invalid-url Source0:
http://fcitx.googlecode.com/files/fcitx-hangul-0.1.1.tar.xz HTTP Error 404: Not
Found
fcitx-hangul.x86_64: W: spelling-error %description -l en_US libhangul ->
Hangul
fcitx-hangul.x86_64: E: incorrect-fsf-address
/usr/share/doc/fcitx-hangul-0.1.1/COPYING
2 packages and 0 specfiles checked; 1 errors, 3 warnings.
+ Source verified with upstream as (sha1sum)
45ce2f8ee5b9c1f7940bee5e0e424391602aa0e3 fcitx-hangul-0.1.1.tar.xz
45ce2f8ee5b9c1f7940bee5e0e424391602aa0e3 ../SOURCES/fcitx-hangul-0.1.1.tar.xz
Suggestions:
1) each pushd command should have corresponding popd. please add it in %build
2) License should be GPLv2+ and BSD. Add comment above license tag like
# The entire source code is GPLv2+ except symbol.txt which is BSD
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.