6:01 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=848958
Bug ID: 848958
QA Contact: extras-qa(a)fedoraproject.org
Severity: unspecified
Version: rawhide
Priority: unspecified
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Assignee: nobody(a)fedoraproject.org
Summary: Review Request : gmchess - Chinese Chess Game
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: py(a)luyten.fr
Type: Bug
Documentation: ---
Hardware: Unspecified
Mount Type: ---
Status: NEW
Component: Package Review
Product: Fedora
Spec URL: http://py.luyten.fr/Publique/Fedora/gmchess.spec
SRPM URL: http://py.luyten.fr/Publique/Fedora/gmchess-0.29.6-0.1.fc17.src.rpm
Description: GPL v2 Chiness Chess (Xiangqi) game, including AI. Gtk 2 / C++ .
Fedora Account System Username: pyluyten
This package needs a sponsor, this is my first.
--
You are receiving this mail because:
You are on the CC list for the bug.
6:03 p.m.
New subject: [Bug 848958] Review Request : gmchess - Chinese Chess Game
https://bugzilla.redhat.com/show_bug.cgi?id=848958
Pierre-Yves Luyten <py(a)luyten.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |py(a)luyten.fr
Blocks| |177841 (FE-NEEDSPONSOR)
--
You are receiving this mail because:
You are on the CC list for the bug.
8:42 p.m.
New subject: [Bug 848958] Review Request : gmchess - Chinese Chess Game
https://bugzilla.redhat.com/show_bug.cgi?id=848958
Robin Lee <robinlee.sysu(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |robinlee.sysu(a)gmail.com
--- Comment #1 from Robin Lee <robinlee.sysu(a)gmail.com> ---
Some initial comments:
* No use macro in changelog
* No explicit library requires
* Just use:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
* The URL should be the project homepage, not the author's blog.
* Upstream seems not well maintained.
--
You are receiving this mail because:
You are on the CC list for the bug.
1:21 a.m.
New subject: [Bug 848958] Review Request : gmchess - Chinese Chess Game
https://bugzilla.redhat.com/show_bug.cgi?id=848958
--- Comment #2 from Pierre-Yves Luyten <py(a)luyten.fr> ---
Thanks,
"No explicit library requires" : I kept only gtkmm24-devel inside
BuildRequires, unless you meant something else.
URL changed, changelog macro removed.
"Upstream seems not well maintained" : actually I would like to have a look to
this code , but this might require some time and first, a package would be
nice.
Using %post -p /sbin/ldconfig as recommended, i get below errors on RPM, thus
I'll investigate further.
gmchess.x86_64: E: postun-without-ldconfig /usr/lib64/libeval.so.0.0.0
gmchess.x86_64: E: non-empty-%postun /sbin/ldconfig
However I pushed the new spec and srpm.
--
You are receiving this mail because:
You are on the CC list for the bug.
11:27 a.m.
New subject: [Bug 848958] Review Request : gmchess - Chinese Chess Game
https://bugzilla.redhat.com/show_bug.cgi?id=848958
--- Comment #3 from Pierre-Yves Luyten <py(a)luyten.fr> ---
Spec : http://py.luyten.fr/Publique/Fedora/gmchess/gmchess.spec
Srpm :
http://py.luyten.fr/Publique/Fedora/gmchess/gmchess-0.29.6-0.1.fc17.src.rpm
I did add one EOL after postun to reduce issues to below warning
gmchess.x86_64: W: percent-in-%postun
--
You are receiving this mail because:
You are on the CC list for the bug.
6:38 p.m.
New subject: [Bug 848958] Review Request : gmchess - Chinese Chess Game
https://bugzilla.redhat.com/show_bug.cgi?id=848958
Jason Tibbitts <tibbs(a)math.uh.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(py(a)luyten.fr)
--- Comment #4 from Jason Tibbitts <tibbs(a)math.uh.edu> ---
I am triaging old review tickets. I can't promise a review if you reply, but
by closing out the stale tickets we can devote extra attention to the ones
which aren't stale.
This package fails to build for me; here is a scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5489154
Shockingly, libeval.so doesn't appear to conflict with anything else in the
distribution. It's still an amazingly generic name for something which appears
to have no use outside of this program, and renaming it wouldn't be a bad idea.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OvQyA3xUSB&a=cc_unsubscribe
4:22 a.m.
New subject: [Bug 848958] Review Request : gmchess - Chinese Chess Game
https://bugzilla.redhat.com/show_bug.cgi?id=848958
Pierre-Yves Luyten <py(a)luyten.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(py(a)luyten.fr) |
Last Closed| |2013-06-11 05:22:40
Status|NEW |CLOSED
Blocks|177841 (FE-NEEDSPONSOR) |
Resolution|--- |WONTFIX
--- Comment #5 from Pierre-Yves Luyten <py(a)luyten.fr> ---
Thanks for this triaging
gmchess had not release at all since I started the package ; I've upstreamed
the libeval.so issue just in case but i'm closing ticket.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=TTQ2Nb5fsW&a=cc_unsubscribe
4009
days inactive
4308
days old
package-review@lists.fedoraproject.org
6 comments
1 participants
participants (1)
-
Red Hat Bugzilla