https://bugzilla.redhat.com/show_bug.cgi?id=1531670
Bug ID: 1531670 Summary: Review Request: rust-error-chain - Error boilerplate library Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: ignatenko@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-error-chain.spe... SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-error-chain-0.1... Description: Error boilerplate library. FAS account: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1531670
--- Comment #1 from Igor Gnatenko ignatenko@redhat.com --- *** Bug 1531857 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1531670
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com Assignee|nobody@fedoraproject.org |lemenkov@gmail.com Flags| |fedora-review?
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com --- I'll review it.
https://bugzilla.redhat.com/show_bug.cgi?id=1531670
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Peter Lemenkov lemenkov@gmail.com --- REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
The package is mostly autogenerated, so everything is built according to the Guidelines.
+ The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (MIT or Apache 2.0). + The files, containing the text of the license(s) for the package, are included as %license. + The spec file is written in American English. + The spec file for the package is legible. + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No C/C++ header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files without a suffix (e.g. libfoo.so) in some of the dynamic linker's default paths. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + All filenames in rpm packages are valid UTF-8.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1531670
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-error-chain
https://bugzilla.redhat.com/show_bug.cgi?id=1531670
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-01-06 14:10:54
package-review@lists.fedoraproject.org