https://bugzilla.redhat.com/show_bug.cgi?id=1204812
Bug ID: 1204812 Summary: Review Request: perl-Crypt-DH-GMP - Crypt::DH Using GMP Directly Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jplesnik.fedorapeople.org/perl-Crypt-DH-GMP/perl-Crypt-DH-GMP.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Crypt-DH-GMP/perl-Crypt-DH-GMP-0.0001... Description: Crypt::DH::GMP is a (somewhat) portable replacement to Crypt::DH, implemented mostly in C.
Fedora Account System Username: jplesnik@redhat.com
NOTE: Wrong license link mentions in lib/Crypt/DH/GMP.pm was reported to the upstream.
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1205121
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1205121 [Bug 1205121] Review Request: perl-Net-OpenID-Common - Libraries shared between Net::OpenID::Consumer and Net::OpenID::Server
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
--- Comment #1 from Petr Šabata psabata@redhat.com --- A bunch of missing buildtime deps: - Config, inc/Module/Install/Can.pm:5, inc/Module/Install/XSUtil.pm:13 - constant, inc/Module/Install/XSUtil.pm:18 - ExtUtils::MM_Unix, inc/Module/Install/Metadata.pm:323, inc/Module/Install/Metadata.pm:332 - Fcntl, inc/Module/Install/Makefile.pm:7 - File::Spec, inc/Module/Install/XSUtil.pm:15
Optional bug recommended missing build time deps: - Crypt::DH, 03_compat.t:3, 04_compat-results.t:3 - Math::BigInt::GMP, t/03_compat.t:3, t/04_compat-results.t:3 - Net::OpenID::Consumer, 02_binhack.t:3 (not yet packaged in Fedora)
Note: Both strict and warnings are also required for build (by Module::Install::*), not just runtime; listing the dependencies under "# Run-time:" could be confusing.
Missing runtime deps: - XSLoader (or alternatively DynaLoader; XSLoader is preferred)
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- Updated. Links are same.
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Šabata psabata@redhat.com --- Ack.
However, I see you also added a build time dependency on DynaLoader. This isn't used when XSLoader is present (and it is, you buildrequire it as well). Drop it before pushing.
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Jitka Plesnikova jplesnik@redhat.com --- New Package SCM Request ======================= Package Name: perl-Crypt-DH-GMP Short Description: Crypt::DH Using GMP Directly Upstream URL: http://search.cpan.org/dist/Crypt-DH-GMP/ Owners: jplesnik ppisar psabata Branches: f22 InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Fixed In Version| |perl-Crypt-DH-GMP-0.00012-1 | |.fc23
--- Comment #6 from Jitka Plesnikova jplesnik@redhat.com --- Thank you for the review and the repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- perl-Crypt-DH-GMP-0.00012-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/perl-Crypt-DH-GMP-0.00012-1.fc22
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- Package perl-Crypt-DH-GMP-0.00012-1.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing perl-Crypt-DH-GMP-0.00012-1.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-4568/perl-Crypt-DH-GMP-0... then log in and leave karma (feedback).
https://bugzilla.redhat.com/show_bug.cgi?id=1204812
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version|perl-Crypt-DH-GMP-0.00012-1 |perl-Crypt-DH-GMP-0.00012-1 |.fc23 |.fc22 Resolution|--- |ERRATA Last Closed| |2015-03-31 17:43:42
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Crypt-DH-GMP-0.00012-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org