Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=254048 ------- Additional Comments From harald(a)redhat.com 2007-08-24 02:52 EST ------- Created an attachment (id=172394) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=172394&action=...) proposed patch to the specfile my patch to let it build and install -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=254048 harald(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172394|0 |1 is obsolete| | ------- Additional Comments From harald(a)redhat.com 2007-08-24 02:56 EST ------- Created an attachment (id=172396) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=172396&action=...) revised patch -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=254048 ------- Additional Comments From matthias(a)rpmforge.net 2007-08-24 05:01 EST ------- One immediate question : The resulting binary package depends on the shared libsysfs.so.2 which is in /usr/lib*/ and not /lib*/ so for Harald's patch needs further changes to get the package to be able to do anything useful before /usr is mounted. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=254048 ------- Additional Comments From matthias(a)rpmforge.net 2007-08-24 05:20 EST ------- (In reply to comment #6) Yup. Current libsysfs-devel still provides the static library, so that would be an option, but surely moving libsysfs would be cleaner. From the spec file comment, it seems like the static libsysfs should already have been used, but it hasn't been. That comment kind of confuses me overall, though : # some distros won't have a static lib version of libsysfs, which # would be needed to generate these .so files I guess the comment is (at least partially) wrong, since even with the static libsysfs available, the shared one is used. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=254048 ------- Additional Comments From matt_domsch(a)dell.com 2007-08-24 07:45 EST ------- OK, I'll nuke the libsysfs usage. That comes from my use of code from the pcmciautils-014 package, but for what is used there, it's easy enough to replace with standard C lib calls. The code can already build a static binary, called biosdevnameS. I just disabled this for now, but if we really need this called before /usr is mounted (e.g. inside an initrd or NFS-root or something) it's easy enough to build again. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/show_bug.cgi?id=254048 ------- Additional Comments From matthias(a)rpmforge.net 2007-08-27 04:45 EST ------- Looking better. Two more questions : - What is the point of creating a shared library which is used only by the binary from this package? Since the .so symlink is wiped out, nothing will be able to link against it, so not using the static version of the binary only makes us loose the time it takes to run ldconfig, right? - The dynamic file list confuses me. Some distros would have something else than the .so.0 and .so.0.0.0 files without changing the spec file? (btw, the comment regarding libsysfs above it needs updating now ;-)) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/show_bug.cgi?id=254048 ------- Additional Comments From matt_domsch(a)dell.com 2007-08-27 08:08 EST ------- The reason for the dynamic file list is that some versions of some distros don't compile libpci.a with -fPIC, so it can't then be included in a shared library. There's autoconf code to detect this and automatically sets enable_shared=no which results in no libbiosdevname.so.* being created. (OpenSUSE and SLES are this way right now, as were earlier versions of Fedora). This spec builds Fedora, RHEL, OpenSuSE, and SLES at this point, the dynamic file list being the only magic involved (to add, or not, depending on existance of those .so.* files, appropriately). I'm not tied to the idea of the convenience library. If it's really that ugly, it can disappear too. And yes I can fix the spec file comments. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/show_bug.cgi?id=254048 ------- Additional Comments From matthias(a)rpmforge.net 2007-08-30 11:37 EST ------- Spec and resulting package look good to go. I'll just need to runtime test the actual binary package. The %description could maybe be changed from : "takes an kernel name" to "takes a device kernel name" (or "takes a kernel device name"?) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/show_bug.cgi?id=254048 matthias(a)rpmforge.net changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From matthias(a)rpmforge.net 2007-08-30 12:39 EST ------- Okay, package approved! Seems like my workstation's BIOS doesn't override much, though (Precision 490), but the package didn't break anything either ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/show_bug.cgi?id=254048 ------- Additional Comments From matt_domsch(a)dell.com 2007-09-17 10:00 EST ------- I haven't forgotten about this, but I've got a showstopper problem before I am comfortable doing a build. I spoke with Kay about this last week, and he wanted an enhancement to udev-114 to let biosdevname suggest the new name without overriding the values in 70-persistent-net-names. I haven't made the enhancement to udev yet, so that's what's blocking me on this... Hopefully this week I can spend some time on it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/show_bug.cgi?id=254048 kevin(a)tummy.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ ------- Additional Comments From kevin(a)tummy.com 2007-09-21 12:26 EST ------- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: biosdevname - udev helper for naming devices per BIOS names https://bugzilla.redhat.com/show_bug.cgi?id=254048 bugzilla(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.