https://bugzilla.redhat.com/show_bug.cgi?id=1128409
Bug ID: 1128409 Summary: Review Request: perl-Module-Data - Introspect context information about modules in @INC Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ddick@cpan.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ddick.fedorapeople.org/packages/perl-Module-Data.spec SRPM URL: https://ddick.fedorapeople.org/packages/perl-Module-Data-0.007-1.fc20.src.rp... Description: Introspect context information about modules in @INC Fedora Account System Username: ddick
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
David Dick ddick@cpan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1126598
--- Comment #1 from David Dick ddick@cpan.org --- koji builds
rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7269472
f20 at http://koji.fedoraproject.org/koji/taskinfo?taskID=7269480
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1126598 [Bug 1126598] perl-Path-ScanINC-1.000001 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
David Dick ddick@cpan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|1126598 |1124313
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1124313 [Bug 1124313] Review Request: perl-Path-ScanINC - Emulate Perls internal handling of @INC https://bugzilla.redhat.com/show_bug.cgi?id=1126598 [Bug 1126598] perl-Path-ScanINC-1.000001 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Petr Pisar ppisar@redhat.com --- URL and Source0 are usable. Ok. Source archive is original (SHA-256:f5ba4f9070f8f3e08b08cb6524f88e6558e70fbf26236d7cf02fa0b989ad0224). Ok.
TODO: Report the useless version constrain on Module::Build to upstream.
License verified from README, lib/Module/Data.pm, LICENSE. Ok. Summary verified from lib/Module/Data.pm. Ok. Description is OK.
TODO: You can write the description as `%{summary}.'.
No XS code. noarch BuildArch is Ok.
TODO: Do not build-require `perl(Config)', `perl(Cwd)', and `perl(lib)'. The files from maint-travis-ci are not used.
All tests pass. Ok. $ rpmlint perl-Module-Data.spec ../SRPMS/perl-Module-Data-0.007-1.fc22.src.rpm ../RPMS/noarch/perl-Module-Data-0.007-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Module-Data-0.007-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Aug 20 10:12 /usr/share/doc/perl-Module-Data -rw-r--r-- 1 root root 4699 Nov 20 2013 /usr/share/doc/perl-Module-Data/Changes -rw-r--r-- 1 root root 18401 Nov 20 2013 /usr/share/doc/perl-Module-Data/LICENSE -rw-r--r-- 1 root root 3537 Nov 20 2013 /usr/share/doc/perl-Module-Data/README -rw-r--r-- 1 root root 3325 Aug 20 10:11 /usr/share/man/man3/Module::Data.3pm.gz drwxr-xr-x 2 root root 0 Aug 20 10:11 /usr/share/perl5/vendor_perl/Module -rw-r--r-- 1 root root 6330 Aug 20 10:11 /usr/share/perl5/vendor_perl/Module/Data.pm File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Module-Data-0.007-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Module::Metadata) 1 perl(Module::Runtime) 1 perl(Moo) 1 perl(Path::Class::File) 1 perl(Path::ScanINC) >= 0.002 1 perl(strict) 1 perl(Sub::Quote) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Binary provides are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Module-Data-0.007-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Module::Data) = 0.007 1 perl-Module-Data = 0.007-1.fc22 Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Module-Data-0.007-1.fc22.noarch.rpm Binary dependencies resolvable. Ok.
Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7429901).
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the `TODO' items before building this package. Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
David Dick ddick@cpan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from David Dick ddick@cpan.org --- Thanks again Patr.
New Package SCM Request ======================= Package Name: perl-Module-Data Short Description: Introspect context information about modules in @INC Upstream URL: http://search.cpan.org/dist/Module-Data/ Owners: ddick Branches: f20, f21 InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- perl-Module-Data-0.007-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Module-Data-0.007-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- perl-Module-Data-0.007-1.fc20 has been pushed to the Fedora 20 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1128409
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |perl-Module-Data-0.007-1.fc | |20 Resolution|--- |ERRATA Last Closed| |2014-09-05 18:21:55
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- perl-Module-Data-0.007-1.fc20 has been pushed to the Fedora 20 stable repository.
package-review@lists.fedoraproject.org