Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891312
Mamoru TASAKA <mtasaka(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #3 from Mamoru TASAKA <mtasaka(a)fedoraproject.org> ---
Well, while I have not checked in detail how ldapdiff utility
works, packaging for this software seems simple and reviewing
for this srpm is straightforward.
Some minor issues (not blockers)
* Cleaning %buildroot at %install
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelin...
- "rm -rf $RPM_BUILD_ROOT"
at the beginning of %install is no longer needed
because rpmbuild will always clean up $RPM_BUILD_ROOT
at the beginning of %install.
Other things are okay
- spec file clean
- tarball matches with the upstream
- build clean
- built binary rpm clean
- can be installed
- at least ldapdiff -v works
----------------------------------------------------------
This package (ldapdiff) is APPROVED by mtasaka
----------------------------------------------------------
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=IbA4do9Rm4&a=cc_unsubscribe