Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: gnuplot
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225849
varekova(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |MODIFIED
Flag|needinfo? |fedora-review?
------- Additional Comments From varekova(a)redhat.com 2007-03-15 09:20 EST -------
(In reply to comment #1)
* BuildRoot isn't the right one
fixed
* Wouldn't it be a good idea to add directories holding truetype
fonts located in %{_datatdir}/fonts to the gnuplot-4.0.0-refers_to.patch
patch?
The fonts directories are changed too often to have them here.
* A suggestion: depend on the font packages. It has pros and cons.
I'm not sure I like to discuss this with gnuplot upstream.
* unuseful requires:
Requires: libpng
fixed
* I don't like the License tag. It appears not to be free
software as it
is now, although it is. Maybe it would be better to have something like
License: Gnuplot
And in a comment say something along
# changes must be distributed as patches
fixed
* RPM_OPT_FLAGS is unuseful on make command line, and
%{?_smp_mflags}
is missing. I tested that replacing with
make %{?_smp_mflags}
seems right.
fixed
Is
PATH=$RPM_BUILD_DIR/gnuplot-%{version}:$PATH
really needed?
fixed
* The %post scriptlet should be run everytime not only at install
time
fixed
* A suggestion: in %{files} use wildcard to handle different compression or
no compression:
%{_mandir}/man1/gnuplot.1*
%{_infodir}/gnuplot.info*
I think the present version is right and it will help to
reveal changes in new
versions.
* The doc in psdoc isn't generated rightly. I suggested cd to the directory
and
make ps_symbols.ps ps_fontfile_doc.pdf
Then distribute only
ps_fontfile_doc.pdf ps_guide.ps ps_symbols.ps ps_file.doc
fixed
It implies a BuildRequires on latex for pdflatex
Add comment #2
version 4.2.0 will be put to fc8 now it is too late to upgrade.
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.