https://bugzilla.redhat.com/show_bug.cgi?id=2074406
Maxwell G <gotmax(a)e.email> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nobody(a)fedoraproject.org |gotmax(a)e.email
Flags| |fedora-review?
Status|NEW |ASSIGNED
--- Comment #2 from Maxwell G <gotmax(a)e.email> ---
I am not going to go through the whole fedora-review template, as this package
uses go2rpm. For standard packages (or if you're a newer packager), you should
go through the whole template.
- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [!] Package is installable
See below
- [x] All rpmlint errors are trivial
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [!] Binaries don't conflict with binaries already in the distribution
/usr/bin/envsubst conflicts with gettext. I would recommend renaming the binary
to goenvsubst or something else so that this doesn't cause conflicts. At least
on my system, it is uninstallable, because gettext is required by grub and
multiple other packages. Here is a patch[1] to fix the issue.
- [!] The package complies with the Packaging Guidelines.
- [!] Package does not use globs in `%files` for shared directories
[1]:
https://paste.sr.ht/~gotmax23/7e204a3cf40d507a68d7cbc4fc0877a798979a47
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2074406