https://bugzilla.redhat.com/show_bug.cgi?id=1922799
Arthur Bols <arthur(a)bols.dev> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #5 from Arthur Bols <arthur(a)bols.dev> ---
Hi,
Since this review is so old, some changes are needed:
- Add the -f flag to %gometa
New packages should use this to exclude %ix86
- Update to the latest version 1.4.0
- Consider using the rpmautospec macros (%autorelease and %autochangelog)
- Change the %{_bindir}/* to not glob (go2rpm still does this, but it's not
recommended):
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
- goversioninfo is an application, shouldn't the package be named goversioninfo
instead?
I'll let you decide, since I don't know the project:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_source...
I'll continue the review after the changes, but I believe it will be ready for
approval.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1922799
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...