9:38 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
Bug ID: 1413646
Summary: Review Request: librealsense - Cross-platform camera
capture for Intel RealSense
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: till.hofmann(a)posteo.de
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://thofmann.fedorapeople.org/librealsense.spec
SRPM URL: https://thofmann.fedorapeople.org/librealsense-1.12.1-3.fc25.src.rpm
Description:
This project is a cross-platform library (Linux, OSX, Windows) for capturing
data from the Intel® RealSense™ F200, SR300 and R200 cameras. This effort was
initiated to better support researchers, creative coders, and app developers in
domains such as robotics, virtual reality, and the internet of things. Several
often-requested features of RealSense™ devices are implemented in this project,
including multi-camera capture.
Fedora Account System Username: thofmann
COPR: https://copr.fedorainfracloud.org/coprs/thofmann/realsense/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:57 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
Mamoru TASAKA <mtasaka(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:57 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
Mamoru TASAKA <mtasaka(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nobody(a)fedoraproject.org |mtasaka(a)fedoraproject.org
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:14 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #1 from Mamoru TASAKA <mtasaka(a)fedoraproject.org> ---
Some initial comments:
* License
https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#How_should_...
- src/libuvc/ is under BSD and librealsense uses (links) files under
this directory, so the license tag should be "ASL 2.0 and BSD"
* Compiler flags
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
- Changing optimization level is discouraged. Currently -Ofast
overrides -O2 in %optflags. e.g.
/usr/bin/c++ -DRS_USE_V4L2_BACKEND -DUNICODE -Drealsense_EXPORTS -isystem
/usr/include/libusb-1.0 -I/builddir/build/BUILD/librealsense-1.12.1/include
-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -std=c++11
-fPIC -pedantic -g -Ofast -Wno-missing-field-initializers -Wno-switch
-Wno-multichar -mssse3 -fPIC -o CMakeFiles/realsense.dir/src/context.cpp.o -c
/builddir/build/BUILD/librealsense-1.12.1/src/context.cpp
If you really needs -Ofast, you need to write such reason on
the spec file, otherwide please remove this.
! Note that -O3 enables some standard-NONcompliant optimizations
such as -funsafe-math-optimizations and it is highly discouraged.
- Also -mssse3 is added by default, this make it impossible to use
this library on the platform not supporting ssse3, and to my
understanding Fedora bans this type of changing supported
architecture.
* No Trademark
https://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary...
- Remove ® ™ or so from %description
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:19 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #2 from Mamoru TASAKA <mtasaka(a)fedoraproject.org> ---
Created attachment 1242720
--> https://bugzilla.redhat.com/attachment.cgi?id=1242720&action=edit
CLA when contributing to this software
Intel requests that to contribute librealsense (this package) via github pull
requests (for example), the contributor is required to agree CLA attached.
Maybe this is regarded as some additional de-facto "license" for librealsense?
If so, is this CLA allowed for Fedora package?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:19 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
Mamoru TASAKA <mtasaka(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |182235 (FE-Legal)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:59 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #3 from Till Hofmann <till.hofmann(a)posteo.de> ---
Spec URL: https://thofmann.fedorapeople.org/librealsense.spec
SRPM URL: https://thofmann.fedorapeople.org/librealsense-1.12.1-4.fc25.src.rpm
Thank you for your comments!
(In reply to Mamoru TASAKA from comment #1)
Some initial comments:
* License
https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/
FAQ#How_should_I_handle_multiple_licensing_situations.3F
- src/libuvc/ is under BSD and librealsense uses (links) files under
this directory, so the license tag should be "ASL 2.0 and BSD"
Missed that, fixed.
* Compiler flags
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
- Changing optimization level is discouraged. Currently -Ofast
overrides -O2 in %optflags. e.g.
/usr/bin/c++ -DRS_USE_V4L2_BACKEND -DUNICODE -Drealsense_EXPORTS -isystem
/usr/include/libusb-1.0 -I/builddir/build/BUILD/librealsense-1.12.1/include
-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64
-mtune=generic -std=c++11 -fPIC -pedantic -g -Ofast
-Wno-missing-field-initializers -Wno-switch -Wno-multichar -mssse3 -fPIC
-o CMakeFiles/realsense.dir/src/context.cpp.o -c
/builddir/build/BUILD/librealsense-1.12.1/src/context.cpp
If you really needs -Ofast, you need to write such reason on
the spec file, otherwide please remove this.
! Note that -O3 enables some standard-NONcompliant optimizations
such as -funsafe-math-optimizations and it is highly discouraged.
- Also -mssse3 is added by default, this make it impossible to use
this library on the platform not supporting ssse3, and to my
understanding Fedora bans this type of changing supported
architecture.
I'm currently discussing this in
https://github.com/IntelRealSense/librealsense/pull/422 whether they can add a
flag that disables any modification of the compiler flags. If not, I'll stick
with the new patch which simply removes all CFLAGS related stuff from
CMakeLists (except the C++11 check).
* No Trademark
https://fedoraproject.org/wiki/Packaging:
Guidelines#Trademarks_in_Summary_or_Description
- Remove ® ™ or so from %description
Oops, fixed.
I didn't think the CLA would be an issue as long as the code itself is still
licensed under a good license.
But let's wait for FE-Legal on their opinion about the CLA.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:49 p.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #4 from Mamoru TASAKA <mtasaka(a)fedoraproject.org> ---
Just for notes:
I also sent a question about this on legal mailing list but for now I got no
response from spot.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:09 p.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
Tom "spot" Callaway <tcallawa(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tcallawa(a)redhat.com
Blocks|182235 (FE-Legal) |
--- Comment #5 from Tom "spot" Callaway <tcallawa(a)redhat.com> ---
CLA does not impose additional restrictions on the license of librealsense,
only on their acceptance of contributions to that codebase.
Lifting FE-Legal.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:36 p.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #6 from Mamoru TASAKA <mtasaka(a)fedoraproject.org> ---
Okay, thank you, spot.
(In reply to Till Hofmann from comment #3)
Spec URL: https://thofmann.fedorapeople.org/librealsense.spec
SRPM URL:
https://thofmann.fedorapeople.org/librealsense-1.12.1-4.fc25.src.rpm
Does not build on either F-27 or F-26:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18498661
https://koji.fedoraproject.org/koji/taskinfo?taskID=18498684
BTW I forgot to mention that now BR: gcc is needed:
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
Will review again when build issue on F-27 and F-26 is fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:46 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #7 from Till Hofmann <till.hofmann(a)posteo.de> ---
Spec URL: https://thofmann.fedorapeople.org/librealsense.spec
SRPM: https://thofmann.fedorapeople.org/librealsense-1.12.1-6.fc25.src.rpm
Thank you spot for the clarification on the legal question.
I fixed the f27 and f26 builds and submitted a PR upstream:
https://github.com/IntelRealSense/librealsense/pull/461.
I also added a BR: gcc-c++
builds:
rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=18520810
f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=18520820
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:47 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #8 from Till Hofmann <till.hofmann(a)posteo.de> ---
Spec URL: https://thofmann.fedorapeople.org/librealsense.spec
SRPM: https://thofmann.fedorapeople.org/librealsense-1.12.1-7.fc25.src.rpm
Correct SRPM URL.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:45 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
Mamoru TASAKA <mtasaka(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #9 from Mamoru TASAKA <mtasaka(a)fedoraproject.org> ---
For -7:
* Trademarks
- One "TM" is left.
often-requested features of >RealSense™< devices are...
Please fix the above when importing this package into Fedora git.
---------------------------------------------------------------
This package (librealsense) is APPROVED by mtasaka
---------------------------------------------------------------
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:53 p.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #10 from Gwyn Ciesla <limburgher(a)gmail.com> ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/librealsense
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:36 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #11 from Till Hofmann <till.hofmann(a)posteo.de> ---
Thank you for reviewing!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:37 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #12 from Fedora Update System <updates(a)fedoraproject.org> ---
librealsense-1.12.1-7.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c344f1e5bf
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:37 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |MODIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:37 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #13 from Fedora Update System <updates(a)fedoraproject.org> ---
librealsense-1.12.1-7.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-20f9581258
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:37 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #14 from Fedora Update System <updates(a)fedoraproject.org> ---
librealsense-1.12.1-7.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-bc53957ca9
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:39 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #15 from Fedora Update System <updates(a)fedoraproject.org> ---
ngspice-26-8.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-682cd9d476
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:40 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #16 from Fedora Update System <updates(a)fedoraproject.org> ---
ngspice-26-8.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-10f4ed1314
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:40 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #17 from Fedora Update System <updates(a)fedoraproject.org> ---
ngspice-26-8.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2b71902776
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:42 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #18 from Mamoru TASAKA <mtasaka(a)fedoraproject.org> ---
(In reply to Fedora Update System from comment #15)
ngspice-26-8.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-682cd9d476
(In reply to Fedora Update System from comment #16)
ngspice-26-8.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-10f4ed1314
(In reply to Fedora Update System from comment #17)
ngspice-26-8.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2b71902776
Referenced wrong bug ticket, sorry.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:53 p.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #19 from Fedora Update System <updates(a)fedoraproject.org> ---
librealsense-1.12.1-7.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c344f1e5bf
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:19 p.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #20 from Fedora Update System <updates(a)fedoraproject.org> ---
librealsense-1.12.1-7.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-bc53957ca9
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:22 p.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #21 from Fedora Update System <updates(a)fedoraproject.org> ---
librealsense-1.12.1-7.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-20f9581258
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:09 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2017-04-03 12:09:03
--- Comment #22 from Fedora Update System <updates(a)fedoraproject.org> ---
librealsense-1.12.1-7.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:48 a.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #23 from Fedora Update System <updates(a)fedoraproject.org> ---
librealsense-1.12.1-7.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:19 p.m.
New subject: [Bug 1413646] Review Request:
librealsense - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1413646
--- Comment #24 from Fedora Update System <updates(a)fedoraproject.org> ---
librealsense-1.12.1-7.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2614
days inactive
2695
days old
package-review@lists.fedoraproject.org
28 comments
2 participants
participants (2)
-
bugzilla＠redhat.com -
Red Hat Bugzilla