Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226077
Summary: Merge Review: libxkbfile Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: sandmann@redhat.com
Fedora Merge Review: libxkbfile
http://cvs.fedora.redhat.com/viewcvs/devel/libxkbfile/ Initial Owner: sandmann@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libxkbfile
https://bugzilla.redhat.com/show_bug.cgi?id=226077
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From panemade@gmail.com 2007-09-03 11:33 EST ------- rpmlint on Binary rpm gave me E: libxkbfile zero-length /usr/share/doc/libxkbfile-1.0.4/AUTHORS E: libxkbfile zero-length /usr/share/doc/libxkbfile-1.0.4/INSTALL E: libxkbfile zero-length /usr/share/doc/libxkbfile-1.0.4/README => Remove zero-length files from installing them on system.
W: libxkbfile invalid-license MIT/X11 The value of the License tag was not recognized. Known values are: "AFL", "Affero GPL", "ASL 1.0", "ASL 1.0+", "ASL 1.1", "ASL 1.1+", "ASL 2.0", "ASL 2.0+", "APSL 2.0", "APSL 2.0+", "Artistic clarified", "Boost", "BSD with advertising", "BSD", "CeCILL", "CDDL", "CPL", "Condor", "Cryptix", "EPL", "eCos", "EFL 2.0", "EFL 2.0+", "EU Datagrid", "GPL+", "GPLv2", "GPLv2+", "GPLv3", "GPLv3+", "IBM", "iMatix", "Intel ACPI", "Interbase", "Jabber", "LaTeX", "LGPL+", "LGPLv2", "LGPLv2 with exceptions", "LGPLv2+", "LGPLv3", "LGPLv3+", "LPL", "mecab-ipadic", "MIT", "MPLv1.0", "MPLv1.0+", "MPLv1.1", "MPLv1.1+", "NCSA", "NGPL", "NOSL", "Netscape", "Nokia", "OpenLDAP", "OSL 1.0", "OSL 1.0+", "OpenSSL", "Phorum", "PHP", "Public Domain", "Python", "QPL", "RPSL", "Ruby", "Sleepycat", "SMLNJL", "SISSL", "SPL", "Vim", "VNLSL", "VSL", "W3C", "WTFPL", "wxWindows", "xinetd", "Zend", "ZPLv1.0", "ZPLv1.0+", "ZPLv2.0", "ZPLv2.0+", "zlib", "CDL", "FBSDDL", "GFDL", "Open Publication", "CC-BY", "CC-BY-SA", "DSL", "Free Art", "Arphic", "SIL Open Font", "Redistributable, no modification permitted", "Freely redistributable without restriction". =>update license tag. (MIT looks ok but X11 is not recognized or this warning can be ignored then)
W: libxkbfile obsolete-not-provided XFree86-libs If a package is obsoleted by a compatible replacement, the obsoleted package must also be provided in order to provide clean upgrade paths and not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the provides.
W: libxkbfile obsolete-not-provided xorg-x11-libs If a package is obsoleted by a compatible replacement, the obsoleted package must also be provided in order to provide clean upgrade paths and not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the provides. => add Provides: tag with versions check http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-3cfc1ea19d2897...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libxkbfile
https://bugzilla.redhat.com/show_bug.cgi?id=226077
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(sandmann@redhat.co | |m)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libxkbfile
https://bugzilla.redhat.com/show_bug.cgi?id=226077
------- Additional Comments From panemade@gmail.com 2008-01-11 04:26 EST ------- This is merge-review where maintainer should be assumed to be capable of solving simple packaging issues and not required to ask reviewer to give patch.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libxkbfile
https://bugzilla.redhat.com/show_bug.cgi?id=226077
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jrb@redhat.com
------- Additional Comments From panemade@gmail.com 2008-01-11 06:00 EST ------- sandmann, As you asked me to provide patch here it is
--- libxkbfile.spec 2007-08-22 02:13:38.000000000 +0530 +++ libxkbfile-new.spec 2008-01-11 16:26:54.000000000 +0530 @@ -1,15 +1,14 @@ Summary: X.Org X11 libxkbfile runtime library Name: libxkbfile Version: 1.0.4 -Release: 3%{?dist} -License: MIT/X11 +Release: 4%{?dist} +License: MIT Group: System Environment/Libraries URL: http://www.x.org BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Source0: ftp://ftp.x.org/pub/individual/lib/libxkbfile/%{name}-%{version}.tar.bz2
-BuildRequires: pkgconfig BuildRequires: xorg-x11-proto-devel BuildRequires: libX11-devel
@@ -64,7 +63,7 @@
%files %defattr(-,root,root,-) -%doc AUTHORS COPYING README ChangeLog +%doc COPYING ChangeLog %{_libdir}/libxkbfile.so.1 %{_libdir}/libxkbfile.so.1.0.2
@@ -85,6 +84,9 @@ %{_libdir}/pkgconfig/xkbfile.pc
%changelog +* Fri Jan 11 2008 parag paragn@fedoraproject.org 1.0.4-4 +- Merge-review #226077 + * Tue Aug 21 2007 Adam Jackson ajax@redhat.com - 1.0.4-3 - Rebuild for build id
Review this patch and open ACL for this package if you are not have enough time to resolve this ticket.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libxkbfile
https://bugzilla.redhat.com/show_bug.cgi?id=226077
sandmann@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(sandmann@redhat.co| |m) |
------- Additional Comments From sandmann@redhat.com 2008-01-11 14:25 EST ------- Same question: Do AUTHORS and README belong in %doc, or not?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libxkbfile
https://bugzilla.redhat.com/show_bug.cgi?id=226077
------- Additional Comments From mcepl@redhat.com 2008-01-11 16:49 EST ------- (In reply to comment #4)
Same question: Do AUTHORS and README belong in %doc, or not?
Yes, they do. All those ALL-CAPS files should end up in %doc (except for INSTALL).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libxkbfile
https://bugzilla.redhat.com/show_bug.cgi?id=226077
------- Additional Comments From panemade@gmail.com 2008-01-12 00:25 EST ------- I think you really really need to either give up your package maintainance or look how reviewing of other packages done. Are you not aware of rpmlint command? Haven't you seen rpmlint output I posted in comment #1? That really says packaging zero length files is packaging error. This is the reason Merge-review tickets got open as core packages never gone through any reviews and also packaging guidelines formed in recent years.
Why should we make packages to install zero-length files on fedora system and increase unnecessary file listing?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libxkbfile
https://bugzilla.redhat.com/show_bug.cgi?id=226077
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2008-01-16 01:39 EST ------- CVS got SPEC cleanups changes now.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libxkbfile
https://bugzilla.redhat.com/show_bug.cgi?id=226077
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
package-review@lists.fedoraproject.org