Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bsd-games - A collection of text-based games
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-04-29 04:35 EST ------- (In reply to comment #37)
(In reply to comment #36)
MUST Fix:
- Package must own /usr/share/bsd-games
Good catch. It's owned now.
Wouldn't it be easier to just write: %{_datadir}/bsd-games
Instead of all those seperate entreis for files and dirs under it in the %files section? Anyways all MUST Fix items fixed: _approved_!
Should Fix:
- "# It looks like textutils became coreutils at some point. I'm not sure # what is needed from it, so I'm commenting it out until I can find out. #Requires: textutils"
In that case concider dropping these 3 lines from the spec?
- Shouldn't the highscore files be marked %config(noreplace) ?
I say no. If the high score file formats changes at any time then we want to make sure that the old ones get removed. We could mark them as %config only, but that seems pointless because the only reason to preserve the old scoreboard files is if a migration tool is also provided to move it to the new format, and I don't see that happening for any of these games.
Do you concider the changing of these files format likely? If you don't makr them %config(noreplace) the highscores will get reset on each package update, I don't think you / we want that.
package-review@lists.fedoraproject.org