Function set_remove_acl_request
by Pierre-Yves Chibon
Hi Toshio,
As you have probably seen I pushed to staging the function
set_remove_acl_request. It seems to work fine and do what we want.
Could you please review it and let me know if you are fine with it?
When you think it is fine we can push it to production.
Should it also be pushed in pkgdb 0.5.x and devel ?
Infra ticket was created already:
https://fedorahosted.org/fedora-infrastructure/ticket/2850
Thanks !
Pierre
12 years, 10 months
- 2
- 2
[diff] request_acl / remove_acl on dispatcher.py
by Pierre-Yves Chibon
Hi,
There is a (quite) dirty patch (diff*) which adds the possibility to
toggle the acl to request or to obsolete the request of a ACL.
At the moment the CL interface relies on toggle_acl_request, meaning, if
one runs """pkgdb-cli request <package> f15""" and then """pkgdb-cli
request <package> all""" the f15 requests will be reverted to "Obsolete"
while the other will be correctly set to "Awaiting Review".
This is bug #7 on pkgdb-cli [1].
I thought of two ways to fix this:
a) retrieve the ACL information for each branch, check the status of the
ACL and perform the action accordingly.
b) add a method into pkgdb which can only set ACL to "Awaiting
review"/"Obsolete" and do nothing if they already have this status.
This diff is a draft of a patch for option b).
What do you think ?
Pierre
[1] https://fedorahosted.org/packagedb-cli/ticket/7
* I tried to generate a descent patch but:
$ bzr commit -m "Start adding methods to request or remove a ACL"
pkgdb/dispatcher.py
bzr: ERROR: Could not acquire lock
"/home/pingou/Scripts/python/fedora-packagedb-stable/.bzr/checkout/dirstate": [Errno 11] Resource temporarily unavailable
12 years, 10 months
- 2
- 5
- ← Newer
- 1
- Older →