packaging July 2013

packaging@lists.fedoraproject.org

43 participants
26 discussions

arched BuildRequires?
by Björn Esser 28 Jan '15

28 Jan '15

Hi there! I have a question about this review: https://bugzilla.redhat.com/show_bug.cgi?id=889261 Is it ok to havearched BuildRequires? In my opinion they should NOT be arched, because of the reasons given in the comments of the bug. Cheers, Björn

11 29

Naming policy for adding language translation packages
by Parag Nemade 24 Sep '13

24 Sep '13

Hi, I see that we are getting more and more translations packages in Fedora and those can be installed now via yum-langpacks plugin. I found that these packages are not following uniqueness in their naming. e.g. If I look into Russian language translation packages then we have real fedora package names as tesseract-langpack-rus kde-l10n-Russian libreoffice-langpack-ru childsplay-alphabet_sounds_ru My suggestion is we should have some naming guidelines like use language codes for language translation packages e.g. for Russian language your package should end with "-ru" only. We should have some uniqueness in package names. Regards, Parag.

3 4

some packaging issues
by Parag Nemade 31 Jul '13

31 Jul '13

Hi, 1) Using this https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Packageas a base, I suggested (not in any bug) to add %{?_isa} for -libs also in ibus.spec to its maintainer. Following is a part of commit he did. But he also then said this looks unnecessary to him as %{name}%{?_isa} already present. %package gtk3 -Summary: IBus im module for gtk3 -Group: System Environment/Libraries -Requires: %{name}%{?_isa} = %{version}-%{release} -Requires: %{name}-libs = %{version}-%{release} +Summary: IBus im module for gtk3 +Group: System Environment/Libraries +Requires: %{name}%{?_isa} = %{version}-%{release} +Requires: %{name}-libs%{?_isa} = %{version}-%{release} I suppose we can ask such changes in existing packages which do not use %{?_isa} for -libs also right? 2) this package does silent compilation, adding "make V=1" will make it verbose. I want to know can this be MUST or SHOULD item for Fedora packages? Regards, Parag.

3 4

Re: [Fedora-packaging] [virt-tools-list] AppIndicator3 not appindicator
by poma 30 Jul '13

30 Jul '13

On 30.07.2013 01:19, Marc Deslauriers wrote: > On 13-07-29 07:09 PM, poma wrote: >> On 29.07.2013 20:45, Cole Robinson wrote: >>> On 07/29/2013 02:38 PM, Marc Deslauriers wrote: >>>> On 13-07-29 07:29 AM, Cole Robinson wrote: >>>>> Thanks for trying this out and fixing my typo. Unfortunate that this is still >>>>> an issue. >>>>> >>>>> Marc, you did the original appindicators patch, any chance you can give >>>>> virt-manager git a spin and fix the issues with appindicator3 ? My guess is >>>>> they are minor. If I don't hear back for a week I'll likely drop the >>>>> appindicators support since it is currently broken, but I'm happy to revive it >>>>> later when someone has it working. >>>>> >>>>> git clone git://git.fedorahosted.org/virt-manager.git >>>>> cd virt-manager >>>>> ./virt-manager --debug >>>>> Preferences->Enable tray icon >>>> >>>> >>>> Here you go: >>>> >>>> >>>> From bcb0993cc9902574da2ec2e21ae960503ddfc6db Mon Sep 17 00:00:00 2001 >>>> From: Marc Deslauriers <marc.deslauriers(a)ubuntu.com> >>>> Date: Mon, 29 Jul 2013 14:25:07 -0400 >>>> Subject: [PATCH] systray: Switch AppIndicator code to GIR >>>> >>>> Switch AppIndicator code to use GObject introspection. >>>> --- >>>> virtManager/systray.py | 15 +++++++++------ >>>> 1 file changed, 9 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/virtManager/systray.py b/virtManager/systray.py >>>> index 992a59b..d504495 100644 >>>> --- a/virtManager/systray.py >>>> +++ b/virtManager/systray.py >>>> @@ -123,7 +123,8 @@ class vmmSystray(vmmGObject): >>>> self.systray_menu.add(Gtk.SeparatorMenuItem()) >>>> >>>> if self.systray_indicator: >>>> - hide_item = Gtk.MenuItem("_Show Virtual Machine Manager") >>>> + hide_item = Gtk.MenuItem.new_with_mnemonic( >>>> + _("_Show Virtual Machine Manager")) >>>> hide_item.connect("activate", self.systray_activate) >>>> self.systray_menu.add(hide_item) >>>> >>>> @@ -138,10 +139,10 @@ class vmmSystray(vmmGObject): >>>> return >>>> >>>> if self.systray_indicator: >>>> - self.systray_icon = AppIndicator3.Indicator("virt-manager", >>>> + self.systray_icon = AppIndicator3.Indicator.new("virt-manager", >>>> "virt-manager-icon", >>>> - AppIndicator3.CATEGORY_OTHER) >>>> - self.systray_icon.set_status(AppIndicator3.STATUS_ACTIVE) >>>> + AppIndicator3.IndicatorCategory.OTHER) >>>> + self.systray_icon.set_status(AppIndicator3.IndicatorStatus.ACTIVE) >>>> self.systray_icon.set_menu(self.systray_menu) >>>> >>>> else: >>>> @@ -162,9 +163,11 @@ class vmmSystray(vmmGObject): >>>> else: >>>> if self.systray_indicator: >>>> if do_show: >>>> - self.systray_icon.set_status(AppIndicator3.STATUS_ACTIVE) >>>> + self.systray_icon.set_status( >>>> + AppIndicator3.IndicatorStatus.ACTIVE) >>>> else: >>>> - self.systray_icon.set_status(AppIndicator3.STATUS_PASSIVE) >>>> + self.systray_icon.set_status( >>>> + AppIndicator3.IndicatorStatus.PASSIVE) >>>> else: >>>> self.systray_icon.set_visible(do_show) >>>> >>> >>> Thanks Marc! Pushed now. >>> >>> - Cole >>> >> >> With 'systray-fedora.patch' - attach, >> - systray icon is displayed correctly >> - left mouse button single-click on the systray icon opens and closes >> the virtual manager window >> - right mouse button single-click on the systray icon displays menu >> correctly >> >> With Marc's original patch isn't entirely the same case, on Fedora 19. ;) >> >> http://goo.gl/FfiF89 >> > > This patch doesn't make sense. self.systray_indicator should be True only on > systems that have AppIndicator3, which isn't the case on Fedora. > > Marc. > > It is a matter of perspective. :) https://www.redhat.com/archives/virt-tools-list/2013-July/msg00106.html http://pkgs.fedoraproject.org/cgit/libappindicator.git $ rpm -qi libappindicator-gtk3 Name : libappindicator-gtk3 Version : 12.10.0 Release : 2.fc19 Architecture: x86_64 Install Date: Mon 15 Jul 2013 10:46:08 AM CEST Group : System Environment/Libraries Size : 95744 License : LGPLv2 and LGPLv3 Signature : RSA/SHA256, Fri 14 Jun 2013 05:43:00 PM CEST, Key ID 07477e65fb4b18e6 Source RPM : libappindicator-12.10.0-2.fc19.src.rpm Build Date : Thu 13 Jun 2013 06:19:20 PM CEST Build Host : buildvm-16.phx2.fedoraproject.org Relocations : (not relocatable) Packager : Fedora Project Vendor : Fedora Project URL : https://launchpad.net/libappindicator Summary : Application indicators library - GTK 3 Description : A library to allow applications to export a menu into the Unity Menu bar. Based on KSNI it also works in KDE and will fallback to generic Systray support if none of those are available. This package contains the GTK 3 version of this library. poma

2 1

Fix Packaging:ScriptletSnippets#Icon_Cache
by Michael Schwendt 29 Jul '13

29 Jul '13

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > %post > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : > > %postun > if [ $1 -eq 0 ] ; then > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : > fi > > %posttrans > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : Somebody with write-access to that page, please add the missing " || :" to the end of the /bin/touch line in the %postun scriptlet. Then the code would be consistent with its explanation on the page.

2 2

Getting dependencie messages on retired package...
by Darryl L. Pierce 29 Jul '13

29 Jul '13

A while back I retired rubygem-qpid after going through the package rename process to make it rubygem-qpid_messaging. The newer package provides rubygem(qpid). For some reason, over the past 2 weeks, I've started getting automated emails saying that rubygem-qpid has a dependency failure. And today I came in to find a Fedora 20 email listing packages that fail to build and it includes rubygem-qpid, even though that package is retired. What do I need to do to fully retire the package? It's marked as retired in the package database, so I'm not sure what else I can do at this point... -- Darryl L. Pierce <mcpierce(a)gmail.com> http://mcpierce.fedorapeople.org/ "What do you care what people think, Mr. Feynman?"

2 3

%preun problems
by Gary Gatling 27 Jul '13

27 Jul '13

Hello. I have a package I created called bumblebee. I am trying to get it into fedora. I made some changes and now on fedora I get errors un-installing. Here is what my %preun looks like: %preun # Package removal, not upgrade %if 0%{?rhel} == 6 if [ $1 -eq 0 ] ; then /sbin/service bumblebeed stop >/dev/null 2>&1 || : /sbin/chkconfig --level 2345 bumblebeed off >/dev/null 2>&1 || : /sbin/chkconfig --del bumblebeed >/dev/null 2>&1 || : fi %endif %if 0%{?fedora:1} || 0%{?rhel} >= 7 %systemd_preun bumblebeed.service %endif And here is the error message: Running transaction Updating : bumblebee-3.2.1-3.fc19.x86_64 1/2 /var/tmp/rpm-tmp.abgRF7: line 3: syntax error near unexpected token `fi' /var/tmp/rpm-tmp.abgRF7: line 3: `fi' error: %preun(bumblebee-3.2.1-2.fc19.x86_64) scriptlet failed, exit status 2 Error in PREUN scriptlet in rpm package bumblebee-3.2.1-2.fc19.x86_64 Verifying : bumblebee-3.2.1-3.fc19.x86_64 1/2 Verifying : bumblebee-3.2.1-2.fc19.x86_64 2/2 Can anyone see what I am doing wrong? This is causing me so much stress right now.

3 2

Small question about
by Björn Esser 26 Jul '13

26 Jul '13

Hi there! I just got some small question. Is `find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'` still needed for some dists, e.g. el5, or can it be fully ommited? Questions is coming up from here: https://bugzilla.redhat.com/show_bug.cgi?id=988102#c10 Thanks in advance. Cheers, Björn

1 1

Doc packaging questions
by Ville Skyttä 25 Jul '13

25 Jul '13

Related to the unversioned docdirs F-20 feature [1], here's a couple of questions: 1) Should specfiles be using %{_docdir} or %{_defaultdocdir} when referring to the /usr/share/doc dir? Both seem to work, both are being used. To me %{_docdir} sounds better for some reason. 2) Packages that want to refer to the doc dir created by the special %doc form need to take %{_docdir_fmt} into account. I didn't find a nice way to do it, but here's one uglyish way to define a variable in specfiles that should point to the correct location before and after the %{_docdir_fmt} change (everything on one row): %global pkgdocdir %{_docdir}/%{?_docdir_fmt:%{expand:%(echo '%{_docdir_fmt}' | tr A-Z a-z)}}%{!?_docdir_fmt:%{name}-%{version}} Do we want to encourage using this in specfiles that need to refer to the dir created by %doc, or does someone have a better solution? Packages can obviously conditionalize stuff on 0%{?fedora} >= 20 but that doesn't sound too nice to me. [1] https://fedoraproject.org/wiki/Changes/UnversionedDocdirs

5 10

Why don't we write in guidelines that BR: perl is mandatory for perl packages?
by Parag Nemade 23 Jul '13

23 Jul '13

Hi, I have a discussion going on https://bugzilla.redhat.com/show_bug.cgi?id=979677 where my basis of discussion is that "BR: perl is mandatory" is not written in any guidelines. Technically, I can understand what perl people there are trying to tell me. So, question is why is it so hard to write in perl guidelines that perl packages should BR: perl? Regards, Parag.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

packaging July 2013