Dear all,
Not sure if I should e-mail the Extras list or this, so here goes:
Anything stupid that I have missed?
I have imported the srpm to Extras devel.
---------- Name: rsnapshot Summary: Local and remote filesystem snapshot utility Version: 1.2.1 Release: 1 License: GPL Group: Applications/System Url: http://www.rsnapshot.org Source0: http://www.rsnapshot.org/downloads/rsnapshot-1.2.1.tar.gz Patch0: rsnapshot.patch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Requires: perl, rsync, ssh AutoReqProv: no
%description This is a remote backup program that uses rsync to take backup snapshots of filesystems. It uses hard links to save space on disk.
%prep rm -rf %{buildroot}
%setup
%patch
%build %configure
%install install -d %{buildroot}/%{_bindir} install -m 755 rsnapshot %{buildroot}/%{_bindir}/rsnapshot
install -d %{buildroot}/%{_mandir}/man1 install -m 644 rsnapshot.1 %{buildroot}/%{_mandir}/man1/
install -d %{buildroot}/%{_sysconfdir} install -m 644 rsnapshot.conf.default %{buildroot}/%{_sysconfdir}/rsnapshot.conf.default install -m 600 rsnapshot.conf.default %{buildroot}/%{_sysconfdir}/rsnapshot.conf
%post # # upgrade rsnapshot config file # RSNAPSHOT_CONFIG_VERSION=`%{_bindir}/rsnapshot check-config-version` if test $? != 0; then echo "Error upgrading %{_sysconfdir}/rsnapshot.conf" fi
if test "$RSNAPSHOT_CONFIG_VERSION" = "1.2"; then # already latest version exit 0 fi
if test "$RSNAPSHOT_CONFIG_VERSION" = "unknown"; then %{_bindir}/rsnapshot upgrade-config-file RETVAL=$? exit $RETVAL fi
echo "Error upgrading %{_sysconfdir}/rsnapshot.conf. Config format unknown!" exit 1
%clean rm -rf %{buildroot}
%files %defattr(-,root,root) %verify(user group mode md5 size mtime) %doc AUTHORS COPYING ChangeLog README INSTALL TODO %verify(user group mode md5 size mtime) %config %{_sysconfdir}/rsnapshot.conf.default %verify(user group mode) %config(noreplace) %{_sysconfdir}/rsnapshot.conf %verify(user group mode md5 size mtime) %{_bindir}/rsnapshot %verify(user group mode md5 size mtime) %{_mandir}/man1/rsnapshot.1*
%changelog * Tue Apr 12 2005 Gavin Henry ghenry@suretecsystems.com - Cleaned up a lot and imported to Fedora Extras
* Sun Jan 29 2005 Nathan Rosenquist nathan@rsnapshot.org - Added upgrade script
* Sat Jan 22 2005 Nathan Rosenquist nathan@rsnapshot.org - Added --with-du option
* Thu Jan 15 2004 Nathan Rosenquist nathan@rsnapshot.org - Added "AutoReqProv: no" for SuSE compatibility
* Fri Dec 26 2003 Nathan Rosenquist nathan@rsnapshot.org - Added util-linux dependency, and --with-logger= option
* Fri Dec 19 2003 Nathan Rosenquist nathan@rsnapshot.org - now fully support autoconf
* Tue Dec 16 2003 Nathan Rosenquist nathan@rsnapshot.org - changed rsnapshot.conf to rsnapshot.conf.default from the source tree
* Wed Nov 05 2003 Nathan Rosenquist nathan@rsnapshot.org - Removed fileutils dependency, added verification info
* Tue Nov 04 2003 Nathan Rosenquist nathan@rsnapshot.org - fixed anonymous rsync error
* Thu Oct 30 2003 Nathan Rosenquist nathan@rsnapshot.org - update to 1.0.3
* Tue Oct 28 2003 Carl Wilhelm Soderstrom chrome@real-time.com - created spec file
Thanks all.
Doh,
I forgot I had already imported and that there is a ticket open with comments already:
https://bugzilla.fedora.us/show_bug.cgi?id=1298
I get on with it then. Too much going on, sorry guys.
On Tue, 12 Apr 2005 12:06:43 +0100 (BST), Gavin Henry wrote:
Dear all,
Not sure if I should e-mail the Extras list or this, so here goes:
Specific review requests should be posted to fedora-extras-list.
Anything stupid that I have missed?
I have imported the srpm to Extras devel.
CVS commits are posted to fedora-extras-commits list automatically: http://www.redhat.com/mailman/listinfo/fedora-extras-commits
I've posted a comment there (but included you in Cc in case you didn't know about the list before).
As I won't find time to take a deep look, another comment here. The overly verbose
%verify(user group mode md5 size mtime)
in the %files section should be deleted alltogether unless you have a good reason why to add them.
%prep rm -rf %{buildroot}
The rm -rf %buildroot is not needed here.
"install" with option "-p" would be nice, because it preserves timestamps on installed files and enables users to see the age of static files easily.
<quote who="Michael Schwendt">
On Tue, 12 Apr 2005 12:06:43 +0100 (BST), Gavin Henry wrote:
Dear all,
Not sure if I should e-mail the Extras list or this, so here goes:
Specific review requests should be posted to fedora-extras-list.
Anything stupid that I have missed?
I have imported the srpm to Extras devel.
CVS commits are posted to fedora-extras-commits list automatically: http://www.redhat.com/mailman/listinfo/fedora-extras-commits
I've posted a comment there (but included you in Cc in case you didn't know about the list before).
As I won't find time to take a deep look, another comment here. The overly verbose
%verify(user group mode md5 size mtime)
in the %files section should be deleted alltogether unless you have a good reason why to add them.
%prep rm -rf %{buildroot}
The rm -rf %buildroot is not needed here.
"install" with option "-p" would be nice, because it preserves timestamps on installed files and enables users to see the age of static files easily.
Done.
Can you point me to the wiki page that shows how to checkout your own module again, I've forgotten.
On Tue, 12 Apr 2005 14:05:38 +0100 (BST), Gavin Henry wrote:
Can you point me to the wiki page that shows how to checkout your own module again, I've forgotten.
[ http://cvs.fedora.redhat.com/extras.shtml http://cvs.fedora.redhat.com/makefile.shtml ]
http://fedoraproject.org/wiki/Extras
F'up to fedora-extras-list, please.
packaging@lists.fedoraproject.org