10:39 p.m.
Hi,
At list for github we can remove ".tar.gz#" [1] may (or should) I update the
wiki ?
-Source0: https://github.com/OWNER/%{name}/archive/%{commit0}.tar.gz#/%{name}-%{shortcommit0}.tar.gz
+Source0: https://github.com/OWNER/%{name}/archive/%{commit0}/%{name}-%{shortcommit0}.tar.gz
Thanks,
--
Sérgio M. B.
7:08 p.m.
New subject: github SourceURL improvement
Hi,
On Sáb, 2015-12-26 at 04:39 +0000, Sérgio Basto wrote:
Hi,
At list for github we can remove ".tar.gz#" [1] may (or should) I
update the wiki ?
-Source0: https://github.com/OWNER/%{name}/archive/%{commit0}.tar.gz
#/%{name}-%{shortcommit0}.tar.gz
+Source0: https://github.com/OWNER/%{name}/archive/%{commit0}/%{name
}-%{shortcommit0}.tar.gz
I think was Germano that found this formula, previous email demonstrate
that works for commit revision but also works for git tags and
releases.
Instead source url be like this :
https://github.com/besser82/pipelight-selinux/archive/v0.3.1.tar.gz#/pi
pelight-selinux-0.3.1.tar.gz
Could be like this:
https://github.com/besser82/pipelight-selinux/archive/v0.3.1/pipelight-
selinux-0.3.1.tar.gz
https://github.com/OWNER/%{name}/archive/GIT-TAG/%{name}-%{version}.tar
.gz looks better
May I update the wiki page ?
( https://fedoraproject.org/wiki/Packaging:SourceURL )
Thanks,
--
Sérgio M. B.
7:47 p.m.
New subject: github SourceURL improvement
On Fri, Jan 8, 2016 at 5:08 PM, Sérgio Basto <sergio(a)serjux.com> wrote:
I think was Germano that found this formula, previous email
demonstrate
that works for commit revision but also works for git tags and
releases.
...
May I update the wiki page ?
( https://fedoraproject.org/wiki/Packaging:SourceURL
)
The examples were written to be as similar as possible and tested to work
across all three major GIT services.
Keep in mind, they are examples... the text states "...you can use...", not
"...you MUST use...". I'm sure there are many combinations which will
work, and nothing in the existing guideline prevents you from using the
syntax of your choice, as long as it accomplishes the task at hand.
If you DO want a guideline revised, you need to open a ticket with the FPC
so it can be reviewed. The FPC will then vote as to whether or not to make
the change.
10:35 p.m.
New subject: github SourceURL improvement
Hello Sérgio,
On Sat, Jan 9, 2016 at 7:08 AM, Sérgio Basto <sergio(a)serjux.com> wrote:
Hi,
On Sáb, 2015-12-26 at 04:39 +0000, Sérgio Basto wrote:
> Hi,
> At list for github we can remove ".tar.gz#" [1] may (or should) I
> update the wiki ?
>
> -Source0: https://github.com/OWNER/%{name}/archive/%{commit0}.tar.gz
> #/%{name}-%{shortcommit0}.tar.gz
> +Source0: https://github.com/OWNER/%{name}/archive/%{commit0}/%{name
> }-%{shortcommit0}.tar.gz
I think was Germano that found this formula, previous email demonstrate
that works for commit revision but also works for git tags and
releases.
Instead source url be like this :
https://github.com/besser82/pipelight-selinux/archive/v0.3.1.tar.gz#/pi
pelight-selinux-0.3.1.tar.gz
<https://github.com/besser82/pipelight-selinux/archive/v0.3.1.tar.gz#/pipe...
Could be like this:
https://github.com/besser82/pipelight-selinux/archive/v0.3.1/pipelight-
selinux-0.3.1.tar.gz
<https://github.com/besser82/pipelight-selinux/archive/v0.3.1/pipelight-se...
It could be even like this:
https://github.com/besser82/pipelight-selinux/archive/v0.3.1.tar.gz
which is more natural looking at the archives page
https://github.com/besser82/pipelight-selinux/releases
Previously, there was a bit vague wording at [1] which raised questions,
you can see the difference here [2].
"For a number of reasons (immutability, availability, uniqueness), you must
use the full commit revision hash when referring to the sources" looked
like a requirement to use commit hashes all the time.
Now it's gone so we can rely on the statement "If the upstream does create
tarballs you should use them as tarballs provide an easier trail for people
auditing the packages", assuming that GitHub created that archive for us.
Sure, it doesn't create it in advance but since it generates it properly
(preserving file modification time, and such) we can consider it as an
ordinary static tarball.
[1] https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services
[2]
https://fedoraproject.org/w/index.php?title=Packaging:SourceURL&diff=...
--
wbr, Denis.
1:08 p.m.
New subject: github SourceURL improvement
On Fri, Jan 8, 2016 at 6:08 PM, Sérgio Basto <sergio(a)serjux.com> wrote:
Hi,
On Sáb, 2015-12-26 at 04:39 +0000, Sérgio Basto wrote:
> Hi,
> At list for github we can remove ".tar.gz#" [1] may (or should) I
> update the wiki ?
>
> -Source0: https://github.com/OWNER/%{name}/archive/%{commit0}.tar.gz
> #/%{name}-%{shortcommit0}.tar.gz
> +Source0: https://github.com/OWNER/%{name}/archive/%{commit0}/%{name
> }-%{shortcommit0}.tar.gz
I think was Germano that found this formula, previous email demonstrate
that works for commit revision but also works for git tags and
releases.
Instead source url be like this :
https://github.com/besser82/pipelight-selinux/archive/v0.3.1.tar.gz#/pi
pelight-selinux-0.3.1.tar.gz
Could be like this:
https://github.com/besser82/pipelight-selinux/archive/v0.3.1/pipelight-
selinux-0.3.1.tar.gz
The previous discussion brought up that while tags shouldn't change,
nothing enforces that and some upstreams might do that. That was the major
argument for using the commit that corresponds to the tag instead of the
tag itself.
1:16 p.m.
New subject: github SourceURL improvement
On 1/9/2016 11:08 AM, Dave Johansen wrote:
On Fri, Jan 8, 2016 at 6:08 PM, Sérgio Basto <sergio(a)serjux.com
<mailto:sergio@serjux.com>> wrote:
Hi,
On Sáb, 2015-12-26 at 04:39 +0000, Sérgio Basto wrote:
> Hi,
> At list for github we can remove ".tar.gz#" [1] may (or should) I
> update the wiki ?
>
> -Source0:
https://github.com/OWNER/%{name}/archive/%{commit0}.tar.gz
<https://github.com/OWNER/%%7Bname%7D/archive/%%7Bcommit0%7D.tar.gz>
> #/%{name}-%{shortcommit0}.tar.gz
> +Source0:
https://github.com/OWNER/%{name}/archive/%{commit0}/%{name
<https://github.com/OWNER/%%7Bname%7D/archive/%%7Bcommit0%7D/%%7Bname>
> }-%{shortcommit0}.tar.gz
I think was Germano that found this formula, previous email
demonstrate
that works for commit revision but also works for git tags and
releases.
Instead source url be like this :
https://github.com/besser82/pipelight-selinux/archive/v0.3.1.tar.gz#/pi
pelight-selinux-0.3.1.tar.gz
<https://github.com/besser82/pipelight-selinux/archive/v0.3.1.tar.gz#/pi%0...
Could be like this:
https://github.com/besser82/pipelight-selinux/archive/v0.3.1/pipelight-
selinux-0.3.1.tar.gz
<https://github.com/besser82/pipelight-selinux/archive/v0.3.1/pipelight-%0...
The previous discussion brought up that while tags shouldn't change,
nothing enforces that and some upstreams might do that. That was the
major argument for using the commit that corresponds to the tag
instead of the tag itself.
Upstreams could just as easily replace a simple tarball on a site as
well though. It seems like there should be a certain level of
sanity-expectation for what upstreams are doing, and if it violates
generally-expected norms then to call that out as such.
If no release tags are ever made, that's one thing... but it feels like
if a release tag is present we should be using that.
-jc
1:57 p.m.
New subject: github SourceURL improvement
On Sat, Jan 9, 2016 at 11:16 AM, Japheth Cleaver <cleaver(a)terabithia.org>
wrote:
If no release tags are ever made, that's one thing... but it
feels like if
a release tag is present we should be using that.
Correct... that is clearly spelled out in the guideline under the Commit
Revision section. GIT TAGS have already been discussed ad infinitum.
Changing of GIT TAGS after a push is considered "insane" behavior - and if
you have a developer who is doing that, you have bigger issues to consider
- such as what other crap are they doing.
3028
days inactive
3042
days old
packaging@lists.fedoraproject.org
6 comments
5 participants
participants (5)
-
Dave Johansen -
Denis Fateyev -
Gerald B. Cox -
Japheth Cleaver -
Sérgio Basto