I have several projects that include bash-completions, and am trying to get a new one through package review. The reviewer has raised a question about whether the package should own:
%dir %{_datadir}/bash-completion/completions
My existing projects have basically cargo-culted the bash-completion packaging, so I thought I would see if there are official guidelines, but I'm not finding anything. Do we have guidelines?
Rich.
On Wed, Nov 27, 2019 at 11:35 AM Richard W.M. Jones rjones@redhat.com wrote:
I have several projects that include bash-completions, and am trying to get a new one through package review. The reviewer has raised a question about whether the package should own:
%dir %{_datadir}/bash-completion/completions
My existing projects have basically cargo-culted the bash-completion packaging, so I thought I would see if there are official guidelines, but I'm not finding anything. Do we have guidelines?
I’m not aware of any guidelines. In pass e we had a similar problem which we solved by having the main pass package own the directory. Perhaps bash should own the competitions directory?
Regards,
bex
Rich.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html _______________________________________________ packaging mailing list -- packaging@lists.fedoraproject.org To unsubscribe send an email to packaging-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/packaging@lists.fedoraproject....
On 11/27/19 3:39 AM, Brian (bex) Exelbierd wrote:
On Wed, Nov 27, 2019 at 11:35 AM Richard W.M. Jones <rjones@redhat.com mailto:rjones@redhat.com> wrote:
I have several projects that include bash-completions, and am trying to get a new one through package review. The reviewer has raised a question about whether the package should own: %dir %{_datadir}/bash-completion/completions My existing projects have basically cargo-culted the bash-completion packaging, so I thought I would see if there are official guidelines, but I'm not finding anything. Do we have guidelines?I’m not aware of any guidelines. In pass e we had a similar problem which we solved by having the main pass package own the directory. Perhaps bash should own the competitions directory?
Regards,
bex
I've filed:
https://src.fedoraproject.org/rpms/bash-completion/pull-request/4
to create a bash-completion-filesystem package to own the directories.
On Fri, Nov 29, 2019 at 4:56 PM Orion Poplawski orion@nwra.com wrote:
On 11/27/19 3:39 AM, Brian (bex) Exelbierd wrote:
On Wed, Nov 27, 2019 at 11:35 AM Richard W.M. Jones <rjones@redhat.com mailto:rjones@redhat.com> wrote:
I have several projects that include bash-completions, and am trying to get a new one through package review. The reviewer has raised a question about whether the package should own: %dir %{_datadir}/bash-completion/completions My existing projects have basically cargo-culted the bash-completion packaging, so I thought I would see if there are official guidelines, but I'm not finding anything. Do we have guidelines?I’m not aware of any guidelines. In pass e we had a similar problem which we solved by having the main pass package own the directory. Perhaps bash should own the competitions directory?
Regards,
bex
I've filed:
https://src.fedoraproject.org/rpms/bash-completion/pull-request/4
to create a bash-completion-filesystem package to own the directories.
Could we move /etc/bash_completion.d/ from filesystem to bash-completion-filesystem then and make it a core installed package?
On 11/29/19 2:58 PM, Neal Gompa wrote:
On Fri, Nov 29, 2019 at 4:56 PM Orion Poplawski orion@nwra.com wrote:
On 11/27/19 3:39 AM, Brian (bex) Exelbierd wrote:
On Wed, Nov 27, 2019 at 11:35 AM Richard W.M. Jones <rjones@redhat.com mailto:rjones@redhat.com> wrote:
I have several projects that include bash-completions, and am trying to get a new one through package review. The reviewer has raised a question about whether the package should own: %dir %{_datadir}/bash-completion/completions My existing projects have basically cargo-culted the bash-completion packaging, so I thought I would see if there are official guidelines, but I'm not finding anything. Do we have guidelines?I’m not aware of any guidelines. In pass e we had a similar problem which we solved by having the main pass package own the directory. Perhaps bash should own the competitions directory?
Regards,
bex
I've filed:
https://src.fedoraproject.org/rpms/bash-completion/pull-request/4
to create a bash-completion-filesystem package to own the directories.
Could we move /etc/bash_completion.d/ from filesystem to bash-completion-filesystem then and make it a core installed package?
I've moved that as well in the PR. I think it's up to someone else to make it a core installed package.
On 27/11/2019 10:32, Richard W.M. Jones wrote:
I have several projects that include bash-completions, and am trying to get a new one through package review. The reviewer has raised a question about whether the package should own:
%dir %{_datadir}/bash-completion/completions
My existing projects have basically cargo-culted the bash-completion packaging, so I thought I would see if there are official guidelines, but I'm not finding anything. Do we have guidelines?
Certainly:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directo...
But the short answer is that you either have to co-own it or you to require a package (presumably bash-completion in this case) which owns it. This case would appear to fall into :
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is...
Because you don't need bash, you're just providing an extension for it for people that do use it.
In that case co-ownership is recommended unless there is a filesystem package you can require to get the directory, which there isn't in this case.
Tom
On Wed, Nov 27, 2019 at 10:32:39AM +0000, Richard W.M. Jones wrote:
My existing projects have basically cargo-culted the bash-completion packaging, so I thought I would see if there are official guidelines, but I'm not finding anything. Do we have guidelines?
It's good to make the bash completion optional (either put the scripts into a subpackage or do not hard-require bash-completion package). There are people who do not like bash completion and this is a way how it often creeps into their systems.
-- Petr
packaging@lists.fedoraproject.org
-
Brian (bex) Exelbierd -
Neal Gompa -
Orion Poplawski -
Petr Pisar -
Richard W.M. Jones -
Tom Hughes