I agree, but I'd make that a recommendation instead. There are a couple of packages known to break with some optimization flags, most notably such using hand-crafted asm and not tolerating any misalignments of structures.

Hiyas, at this time the Packaging-Guidelines do not mention whether or not %{optflags} should / must be used. They are used everytime %configure is executed, but there are also packages that do not have a ./configure script and for this reason would not use the %{optflags}. The flags in %{optflags} contain not only optimization but also security flags. For this reason I suggest that the Guidelines state that they have to be used. This will also help new contributors to know about this.

On Wed, 2006-08-23 at 23:46 +0200, Till Maas wrote: > Hello, > > thank you for your fast response. In > http://fedoraproject.org/wiki/Packaging/Guidelines?action=diff#head-8b140... > you only mention C and C++ Compilers, > rpm --eval %configure > shows, that also FFLAGS, which I believe are for Fortran, are set with the > values of %optflags.

Thanks for the catch, improved wording is online now: http://fedoraproject.org/wiki/Packaging/Guidelines?action=diff&rev2=7...

On Thu, Aug 24, 2006 at 09:24:12PM +0200, Axel Thimm wrote: > On Thu, Aug 24, 2006 at 09:46:14PM +0300, Ville Skyttä wrote: > > On Wed, 2006-08-23 at 23:46 +0200, Till Maas wrote: > > > Hello, > > > > > > thank you for your fast response. In > > > http://fedoraproject.org/wiki/Packaging/Guidelines?action=diff#head-8b140... > > > you only mention C and C++ Compilers, > > > rpm --eval %configure > > > shows, that also FFLAGS, which I believe are for Fortran, are set with the > > > values of %optflags. > > If you really want to be picky, you'd have to mention FCFLAGS, > too. Which is actually a bug in current FC6, let me think a bit about > it. Hm, looks like it's broken on FC5, too. :/ Probably not that many fortran packages to make this surface.