https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=127988
[ -x %{_libdir}/rpm/brp-compress ] && %{_libdir}/rpm/brp-compress There are several packages like this, and similar perl modules with /usr/lib instead of %{_libdir}. This fails to build on x86_64 for obvious reasons. While this isn't a problem for FC's build system (everything is built on 32bit), we should fix these packages.
[ -x /usr/lib/rpm/brp-compress ] && /usr/lib/rpm/brp-compress While doing this would work, this may confuse people because our packaging docs say to macroize everything. Are there other cases where macroizing directories is NOT the right thing to do?
And... any idea why these packages are running brp-compress anyway? Doesn't this happen automatically without it?
Warren Togami wtogami@redhat.com
On Tue, 2005-03-29 at 11:07 -1000, Warren Togami wrote:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=127988
[ -x %{_libdir}/rpm/brp-compress ] && %{_libdir}/rpm/brp-compress There are several packages like this, and similar perl modules with /usr/lib instead of %{_libdir}. This fails to build on x86_64 for obvious reasons. While this isn't a problem for FC's build system (everything is built on 32bit), we should fix these packages.
[ -x /usr/lib/rpm/brp-compress ] && /usr/lib/rpm/brp-compress While doing this would work,
Yeah, but it ignores the system's other rpmbuild configuration, eg. redhat-rpm-config, which uses /usr/lib/rpm/redhat/brp-compress. Not that there would be too big differences between them nowadays, but to illustrate.
this may confuse people because our packaging docs say to macroize everything. Are there other cases where macroizing directories is NOT the right thing to do?
All cases where it doesn't make sense? I don't think it's possible to give an exhaustive answer to that. Packagers just have to know when to use macros, and what macros, and when not to. If packaging docs say macroize everything, then I think the docs should be improved.
BTW, if one wants to keep the above explicit brp-compress's in, it'd be better to change them to %{_prefix}/lib/rpm/..., see rpm.spec.
And... any idea why these packages are running brp-compress anyway? Doesn't this happen automatically without it?
It does, and I think those should be just removed from all specfiles. They're probably initially from cpanflute2 which creates a lot of cruft no longer needed in non-ancient RH(EL)/FC distro versions.
Ville Skyttä wrote:
And... any idea why these packages are running brp-compress anyway? Doesn't this happen automatically without it?
It does, and I think those should be just removed from all specfiles. They're probably initially from cpanflute2 which creates a lot of cruft no longer needed in non-ancient RH(EL)/FC distro versions.
Some of these are probably false positives... will attempt to fix. Any simple way of scripting a way of comparing the versions of perl modules in rawhide to CPAN to see which need to be upgraded?
Warren Togami wtogami@redhat.com
[wtogami@devserv devel]$ grep --files-with-matches brp-compress perl*/*.spec perl-Archive-Tar/perl-Archive-Tar.spec perl-Bit-Vector/perl-Bit-Vector.spec perl-BSD-Resource/perl-BSD-Resource.spec perl-Compress-Zlib/perl-Compress-Zlib.spec perl-Convert-ASN1/perl-Convert-ASN1.spec perl-Crypt-SSLeay/perl-Crypt-SSLeay.spec perl-Date-Calc/perl-Date-Calc.spec perl-DateManip/perl-DateManip.spec perl-DBD-MySQL/perl-DBD-MySQL.spec perl-DBD-Pg/perl-DBD-Pg.spec perl-DBI/perl-DBI.spec perl-Devel-Symdump/perl-Devel-Symdump.spec perl-Digest-HMAC/perl-Digest-HMAC.spec perl-Digest-SHA1/perl-Digest-SHA1.spec perl-File-MMagic/perl-File-MMagic.spec perl-Filter/perl-Filter.spec perl-Filter-Simple/perl-Filter-Simple.spec perl-Frontier-RPC/perl-Frontier-RPC.spec perl-HTML-Parser/perl-HTML-Parser.spec perl-HTML-Tagset/perl-HTML-Tagset.spec perl-Inline/perl-Inline.spec perl-LDAP/perl-LDAP.spec perl-libwww-perl/perl-libwww-perl.spec perl-libxml-enno/perl-libxml-enno.spec perl-libxml-perl/perl-libxml-perl.spec perl-Net-DNS/perl-Net-DNS.spec perl-Parse-RecDescent/perl-Parse-RecDescent.spec perl-Parse-Yapp/perl-Parse-Yapp.spec perl-PDL/perl-PDL.spec perl/perl.spec perl-RPM2/perl-RPM2.spec perl-RPM-Specfile/perl-RPM-Specfile.spec perl-TermReadKey/perl-TermReadKey.spec perl-TimeDate/perl-TimeDate.spec perl-Time-HiRes/perl-Time-HiRes.spec perl-URI/perl-URI.spec perl-XML-Dumper/perl-XML-Dumper.spec perl-XML-Encoding/perl-XML-Encoding.spec perl-XML-Grove/perl-XML-Grove.spec perl-XML-LibXML-Common/perl-XML-LibXML-Common.spec perl-XML-NamespaceSupport/perl-XML-NamespaceSupport.spec perl-XML-Parser/perl-XML-Parser.spec perl-XML-Twig/perl-XML-Twig.spec [wtogami@devserv devel]$ vim perl/perl.spec [wtogami@devserv devel]$ grep --files-with-matches brp-compress perl*/*.spec perl-Archive-Tar/perl-Archive-Tar.spec perl-Bit-Vector/perl-Bit-Vector.spec perl-BSD-Resource/perl-BSD-Resource.spec perl-Compress-Zlib/perl-Compress-Zlib.spec perl-Convert-ASN1/perl-Convert-ASN1.spec perl-Crypt-SSLeay/perl-Crypt-SSLeay.spec perl-Date-Calc/perl-Date-Calc.spec perl-DateManip/perl-DateManip.spec perl-DBD-MySQL/perl-DBD-MySQL.spec perl-DBD-Pg/perl-DBD-Pg.spec perl-DBI/perl-DBI.spec perl-Devel-Symdump/perl-Devel-Symdump.spec perl-Digest-HMAC/perl-Digest-HMAC.spec perl-Digest-SHA1/perl-Digest-SHA1.spec perl-File-MMagic/perl-File-MMagic.spec perl-Filter/perl-Filter.spec perl-Filter-Simple/perl-Filter-Simple.spec perl-Frontier-RPC/perl-Frontier-RPC.spec perl-HTML-Parser/perl-HTML-Parser.spec perl-HTML-Tagset/perl-HTML-Tagset.spec perl-Inline/perl-Inline.spec perl-LDAP/perl-LDAP.spec perl-libwww-perl/perl-libwww-perl.spec perl-libxml-enno/perl-libxml-enno.spec perl-libxml-perl/perl-libxml-perl.spec perl-Net-DNS/perl-Net-DNS.spec perl-Parse-RecDescent/perl-Parse-RecDescent.spec perl-Parse-Yapp/perl-Parse-Yapp.spec perl-PDL/perl-PDL.spec perl/perl.spec perl-RPM2/perl-RPM2.spec perl-RPM-Specfile/perl-RPM-Specfile.spec perl-TermReadKey/perl-TermReadKey.spec perl-TimeDate/perl-TimeDate.spec perl-Time-HiRes/perl-Time-HiRes.spec perl-URI/perl-URI.spec perl-XML-Dumper/perl-XML-Dumper.spec perl-XML-Encoding/perl-XML-Encoding.spec perl-XML-Grove/perl-XML-Grove.spec perl-XML-LibXML-Common/perl-XML-LibXML-Common.spec perl-XML-NamespaceSupport/perl-XML-NamespaceSupport.spec perl-XML-Parser/perl-XML-Parser.spec perl-XML-Twig/perl-XML-Twig.spec
packaging@lists.fedoraproject.org
-
Ville Skyttä -
Warren Togami