Cleanup issues introduced in pam_motd by the recent Github pull request
by Tomas Mraz
The attached patch cleans up some issues introduced in pam_motd by the
recent Github pull request. I made the mistake that I did not build it
before merging and I did not catch these issues in the review.
In particular it fixes warnings about int signedness, about losing
const qualifier and unused function.
It also silences syslog error reporting if in the default configuration
the motd directories are missing. I keep the error log in case the
configuration is non-default or the error is something else than
ENOENT.
OK to commit?
--
Tomáš Mráz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
[You'll know whether the road is wrong if you carefully listen to your
conscience.]
5 years, 4 months
Move duplicated search_key function to new pam_modutil_search_key function
by Tomas Mraz
The attached patch moves the implementation of search_key function that
was duplicated in multiple PAM modules into a new
pam_modutil_search_key function.
I plan to add one more place where it will be used - pam_lastlog.
OK to commit?
--
Tomáš Mráz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
[You'll know whether the road is wrong if you carefully listen to your
conscience.]
5 years, 4 months
