On Čt, 2015-11-26 at 16:05 +0100, Tomas Mraz wrote: > The attached patch makes pam_tally2 to always report the tally count in > syslog for debugging purposes with LOG_DEBUG level. It can be useful to > track the tally count for simultaneous login attempts. I've used > LOG_DEBUG level for the added messages as the purpose is really rather > for debugging than anything else. > > OK to commit? ping? If nobody objects, I'll commit it next week.

On Čt, 2015-12-03 at 14:42 +0100, Thorsten Kukuk wrote: > On Thu, Dec 03, Tomas Mraz wrote: > > > On Čt, 2015-11-26 at 16:05 +0100, Tomas Mraz wrote: > > > The attached patch makes pam_tally2 to always report the tally count in > > > syslog for debugging purposes with LOG_DEBUG level. It can be useful to > > > track the tally count for simultaneous login attempts. I've used > > > LOG_DEBUG level for the added messages as the purpose is really rather > > > for debugging than anything else. > > > > > > OK to commit? > > > > ping? If nobody objects, I'll commit it next week. > > Sorry, wanted to take a closer look at this but got ill... > > Do I understand the code correct, that we print now a LOG_DEBUG > with every login attemp? > I'm pretty sure a lot of people will complain about the additonal > noise in the log files. I would prefer to introduce a debug option > for this. I wanted to avoid the feature creep and was thinking that normally the LOG_DEBUG messages are usually suppressed in the logs. But if you think the debug option is necessary, I can add it.

On Pá, 2015-12-11 at 11:53 +0100, Thorsten Kukuk wrote: > On Thu, Dec 03, Tomas Mraz wrote: > > > On Čt, 2015-12-03 at 14:42 +0100, Thorsten Kukuk wrote: > > > On Thu, Dec 03, Tomas Mraz wrote: > > > > > > > On Čt, 2015-11-26 at 16:05 +0100, Tomas Mraz wrote: > > > > > The attached patch makes pam_tally2 to always report the tally count in > > > > > syslog for debugging purposes with LOG_DEBUG level. It can be useful to > > > > > track the tally count for simultaneous login attempts. I've used > > > > > LOG_DEBUG level for the added messages as the purpose is really rather > > > > > for debugging than anything else. > > > > > > > > > > OK to commit? > > > > > > > > ping? If nobody objects, I'll commit it next week. > > > > > > Sorry, wanted to take a closer look at this but got ill... > > > > > > Do I understand the code correct, that we print now a LOG_DEBUG > > > with every login attemp? > > > I'm pretty sure a lot of people will complain about the additonal > > > noise in the log files. I would prefer to introduce a debug option > > > for this. > > > > I wanted to avoid the feature creep and was thinking that normally the > > LOG_DEBUG messages are usually suppressed in the logs. But if you think > > the debug option is necessary, I can add it. > > Looks like nobody else has an opinion about this? > > I would prefer to have a debug option for this. No problem, here is the patch with debug option added. OK to commit?