5:15 a.m.
The attached patch adds possibility to match some other PAM items to
pam_succeed_if module.
Please review.
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
11:56 a.m.
On Fri, Dec 16, 2011 at 12:15:56PM +0100, Tomas Mraz wrote:
The attached patch adds possibility to match some other PAM items to
pam_succeed_if module.
Please review.
This patch also makes PAM_RUSER override the value returned by
pam_modutil_getpwuid(); I'm not sure there are no unwanted side effects
of this change.
--
ldv
1:12 p.m.
On Fri, 2011-12-16 at 21:56 +0400, Dmitry V. Levin wrote:
On Fri, Dec 16, 2011 at 12:15:56PM +0100, Tomas Mraz wrote:
> The attached patch adds possibility to match some other PAM items to
> pam_succeed_if module.
>
> Please review.
This patch also makes PAM_RUSER override the value returned by
pam_modutil_getpwuid(); I'm not sure there are no unwanted side effects
of this change.
You mean the user = buf; assignment after getting the PAM_RUSER item?
But that will not break anything, it just allows the ruser to be used
with the (not)innetgr and (not)ingroup matches.
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
5:26 a.m.
On Mon, 2011-12-19 at 20:12 +0100, Tomas Mraz wrote:
On Fri, 2011-12-16 at 21:56 +0400, Dmitry V. Levin wrote:
> On Fri, Dec 16, 2011 at 12:15:56PM +0100, Tomas Mraz wrote:
> > The attached patch adds possibility to match some other PAM items to
> > pam_succeed_if module.
> >
> > Please review.
>
> This patch also makes PAM_RUSER override the value returned by
> pam_modutil_getpwuid(); I'm not sure there are no unwanted side effects
> of this change.
>
You mean the user = buf; assignment after getting the PAM_RUSER item?
But that will not break anything, it just allows the ruser to be used
with the (not)innetgr and (not)ingroup matches.
So are there another objections to the patch?
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
11:36 a.m.
On Tue, Jan 03, 2012 at 12:26:32PM +0100, Tomas Mraz wrote:
On Mon, 2011-12-19 at 20:12 +0100, Tomas Mraz wrote:
> On Fri, 2011-12-16 at 21:56 +0400, Dmitry V. Levin wrote:
> > On Fri, Dec 16, 2011 at 12:15:56PM +0100, Tomas Mraz wrote:
> > > The attached patch adds possibility to match some other PAM items to
> > > pam_succeed_if module.
> > >
> > > Please review.
> >
> > This patch also makes PAM_RUSER override the value returned by
> > pam_modutil_getpwuid(); I'm not sure there are no unwanted side effects
> > of this change.
>
> You mean the user = buf; assignment after getting the PAM_RUSER item?
> But that will not break anything, it just allows the ruser to be used
> with the (not)innetgr and (not)ingroup matches.
>
So are there another objections to the patch?
I've re-read the whole function, there are no side effects indeed.
I have no objections.
--
ldv
4495
days inactive
4513
days old
pam-developers@lists.fedorahosted.org
4 comments
2 participants
participants (2)
-
Dmitry V. Levin -
Tomas Mraz