[Bug 183028] Review Request: perl-Spiffy
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Spiffy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028
------- Additional Comments From steve(a)silug.org 2006-02-28 10:52 EST -------
> BTW, while talking with Ville I found that for correctness you need to
> backwhack the first XXX. My screwup. I don't know if it breaks anything,
> but you might wnat to hit it before checking in.
I wonder what the reason is for that. It seems to build fine as-is.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
18 years, 1 month
[Bug 183028] Review Request: perl-Spiffy
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Spiffy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028
tibbs(a)math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs(a)math.uh.edu 2006-02-27 20:54 EST -------
I think we're set. Approved.
BTW, while talking with Ville I found that for correctness you need to backwhack
the first XXX. My screwup. I don't know if it breaks anything, but you might
wnat to hit it before checking in. The current version of this stuff is at
http://fedoraproject.org/wiki/Packaging/Perl
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
18 years, 1 month
[Bug 183028] Review Request: perl-Spiffy
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Spiffy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028
------- Additional Comments From steve(a)silug.org 2006-02-27 17:10 EST -------
Given that there is a real mixin.pm, I'm checking now to see if Spiffy is a
drop-in replacement for it. If it is, we *should* be able to include a fake
mixin.pm that just does "use Spiffy". Otherwise, I guess I have to filter the
perl(mixin) dependency.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
18 years, 1 month
[Bug 183028] Review Request: perl-Spiffy
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Spiffy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028
------- Additional Comments From tibbs(a)math.uh.edu 2006-02-27 14:52 EST -------
Look, he's trying to come up with a solution that doesn't involve hacking 130
downstream packages. If you don't want to be constructive then please just
don't post.
Steve, I'm working on filtering the requires and it's really simple; you just
need six lines in %prep. Looking through what other packages in Core and Extras
do, I see that this is really very common:
cat << EOF > %{name}-req
#!/bin/sh
%{__perl_requires} $* | sed -e '/perl(mixin)/d'
EOF
%define __perl_requires %{_builddir}/%{name}-%{version}/%{name}-req
chmod +x %{__perl_requires}
(You can also reference an external script as %{SOURCE99} if you find emitting
it from the spec distasteful.)
Finally, I was hacking on the packages and noticed that Spiffy also provides
perl(DB), which I think is broken. (It overrides the super() method in the DB
package, and so it has a "package DB" statement which RPM turns into Provides:
perl(DB).) This has the capacity to break other things, so Spiffy is definitely
going to need a __perl_provides override as well:
cat <<XXX > %{name}-prov
#!/bin/sh
%{__perl_provides} $* | sed -e '/perl(DB)/d'
XXX
%define __perl_provides %{_builddir}/Spiffy-%{version}/%{name}-prov
chmod +x %{__perl_provides}
With this, things are working cleanly.
I know it's a pain to have to do this in all of the modules, but I think this is
going to be the only way to move forward. I will try to get these overrides
into the Perl template and I suggest that they get into cpanspec as well.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
18 years, 1 month
Sub::Uplevel and perl 5.8.8
by Jose Pedro Oliveira
Hi,
The perl module Sub::Uplevel is generating warnings under perl 5.8.8
(this didn't happened with perl 5.8.6 and 5.8.7). I believe something
related to caller() must have changed in perl 5.8.8 but I am unable to
pinpoint the source of the problem (caller appears to be returning undef
in a new situation).
These warnings are causing major problems in other packages:
* perl-Test-Warn fails to build (test problems)
* perl-Test-Exception produces a couple of warnings during the
test suite execution
* perl-WWW-Mechanize fails to build (test failures)
I have a patch already in CVS (perl-Sub-Uplevel devel branch) but I
would appreciate feedback before releasing a new build of the
perl-Sub-Uplevel. Additional information is available in ticket #182488
(https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182488)
Thanks in advance,
jpo
--
José Pedro Oliveira
* mailto: jpo(a)di.uminho.pt * http://gsd.di.uminho.pt/jpo *
* gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
18 years, 1 month