4:19 a.m.
Author: spot
Update of /cvs/pkgs/rpms/perl-DBIx-Class-DynamicDefault/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv3556
Modified Files:
perl-DBIx-Class-DynamicDefault.spec
Log Message:
fix duplicate directory ownership
Index: perl-DBIx-Class-DynamicDefault.spec
===================================================================
RCS file:
/cvs/pkgs/rpms/perl-DBIx-Class-DynamicDefault/devel/perl-DBIx-Class-DynamicDefault.spec,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -p -r1.1 -r1.2
--- perl-DBIx-Class-DynamicDefault.spec 7 Jun 2009 20:30:12 -0000 1.1
+++ perl-DBIx-Class-DynamicDefault.spec 26 Jun 2009 09:18:50 -0000 1.2
@@ -1,6 +1,6 @@
Name: perl-DBIx-Class-DynamicDefault
Version: 0.03
-Release: 1%{?dist}
+Release: 2%{?dist}
# lib/DBIx/Class/DynamicDefault.pm -> GPL+ or Artistic
License: GPL+ or Artistic
Group: Development/Libraries
@@ -48,10 +48,13 @@ rm -rf %{buildroot}
%files
%defattr(-,root,root,-)
%doc Changes README
-%{perl_vendorlib}/*
+%{perl_vendorlib}/DBIx/Class/*
%{_mandir}/man3/*.3*
%changelog
+* Fri Jun 26 2009 Tom "spot" Callaway <tcallawa(a)redhat.com> 0.03-2
+- fix duplicate directory ownership (perl-DBIx-Class owns %{perl_vendorlib}/DBIx/Class/)
+
* Tue Jun 02 2009 Chris Weyl <cweyl(a)alumni.drew.edu> 0.03-1
- submission
4:58 a.m.
New subject: rpms/perl-DBIx-Class-DynamicDefault/devel perl-DBIx-Class-DynamicDefault.spec, 1.1, 1.2
Tom Callaway wrote:
Author: spot
Update of /cvs/pkgs/rpms/perl-DBIx-Class-DynamicDefault/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv3556
Modified Files:
perl-DBIx-Class-DynamicDefault.spec
Log Message:
fix duplicate directory ownership
Index: perl-DBIx-Class-DynamicDefault.spec
===================================================================
RCS file:
/cvs/pkgs/rpms/perl-DBIx-Class-DynamicDefault/devel/perl-DBIx-Class-DynamicDefault.spec,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -p -r1.1 -r1.2
--- perl-DBIx-Class-DynamicDefault.spec 7 Jun 2009 20:30:12 -0000 1.1
+++ perl-DBIx-Class-DynamicDefault.spec 26 Jun 2009 09:18:50 -0000 1.2
@@ -1,6 +1,6 @@
Name: perl-DBIx-Class-DynamicDefault
Version: 0.03
-Release: 1%{?dist}
+Release: 2%{?dist}
# lib/DBIx/Class/DynamicDefault.pm -> GPL+ or Artistic
License: GPL+ or Artistic
Group: Development/Libraries
@@ -48,10 +48,13 @@ rm -rf %{buildroot}
%files
%defattr(-,root,root,-)
%doc Changes README
-%{perl_vendorlib}/*
+%{perl_vendorlib}/DBIx/Class/*
%{_mandir}/man3/*.3*
%changelog
+* Fri Jun 26 2009 Tom "spot" Callaway <tcallawa(a)redhat.com> 0.03-2
+- fix duplicate directory ownership (perl-DBIx-Class owns %{perl_vendorlib}/DBIx/Class/)
Tom, you are not fixing bugs your are breaking things!
perl modules do not share a strict hierarchy, but are independent packages!
Stop this insanity ... !
7:45 a.m.
On Fri, 2009-06-26 at 11:58 +0200, Ralf Corsepius wrote:
Tom Callaway wrote:
> Author: spot
>
> Update of /cvs/pkgs/rpms/perl-DBIx-Class-DynamicDefault/devel
> In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv3556
>
> Modified Files:
> perl-DBIx-Class-DynamicDefault.spec
> Log Message:
> fix duplicate directory ownership
>
>
> Index: perl-DBIx-Class-DynamicDefault.spec
> ===================================================================
> RCS file:
/cvs/pkgs/rpms/perl-DBIx-Class-DynamicDefault/devel/perl-DBIx-Class-DynamicDefault.spec,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -p -r1.1 -r1.2
> --- perl-DBIx-Class-DynamicDefault.spec 7 Jun 2009 20:30:12 -0000 1.1
> +++ perl-DBIx-Class-DynamicDefault.spec 26 Jun 2009 09:18:50 -0000 1.2
> @@ -1,6 +1,6 @@
> Name: perl-DBIx-Class-DynamicDefault
> Version: 0.03
> -Release: 1%{?dist}
> +Release: 2%{?dist}
> # lib/DBIx/Class/DynamicDefault.pm -> GPL+ or Artistic
> License: GPL+ or Artistic
> Group: Development/Libraries
> @@ -48,10 +48,13 @@ rm -rf %{buildroot}
> %files
> %defattr(-,root,root,-)
> %doc Changes README
> -%{perl_vendorlib}/*
> +%{perl_vendorlib}/DBIx/Class/*
> %{_mandir}/man3/*.3*
>
> %changelog
> +* Fri Jun 26 2009 Tom "spot" Callaway <tcallawa(a)redhat.com> 0.03-2
> +- fix duplicate directory ownership (perl-DBIx-Class owns
%{perl_vendorlib}/DBIx/Class/)
Tom, you are not fixing bugs your are breaking things!
perl modules do not share a strict hierarchy, but are independent packages!
What do you mean ? How DBI::Class::DynamicDefault is independent of
DBI::Class ?
http://deps.cpantesters.org/?module=DBIx::Class::DynamicDefault;perl=latest
1:08 p.m.
On Fri, Jun 26, 2009 at 5:45 AM, Yanko Kaneti <yaneti(a)declera.com> wrote:
On Fri, 2009-06-26 at 11:58 +0200, Ralf Corsepius wrote:
> Tom Callaway wrote:
> > -%{perl_vendorlib}/*
> > +%{perl_vendorlib}/DBIx/Class/*
> > %{_mandir}/man3/*.3*
> >
> > %changelog
> > +* Fri Jun 26 2009 Tom "spot" Callaway <tcallawa(a)redhat.com>
0.03-2
> > +- fix duplicate directory ownership (perl-DBIx-Class owns
%{perl_vendorlib}/DBIx/Class/)
>
> Tom, you are not fixing bugs your are breaking things!
>
> perl modules do not share a strict hierarchy, but are independent
packages!
What do you mean ? How DBI::Class::DynamicDefault is independent of
DBI::Class ?
http://deps.cpantesters.org/?module=DBIx::Class::DynamicDefault;perl=latest
What Ralf is rather vigorously saying is that both by convention and
explicit guideline, due to the fluid nature of perl-* packages they're
supposed to own everything they provide under %{perl_vendorarch} or
%{perl_vendorlib}. Specifying ownership of a subset of that is considered a
blocker at review and a packaging bug post-review... It's just a packging
issue, it has nothing to do with the relationship between DBIC and
DBIC::DynamicDefault.
-Chris
--
Chris Weyl
Ex astris, scientia
2:53 p.m.
On Fri, 2009-06-26 at 11:08 -0700, Chris Weyl wrote:
On Fri, Jun 26, 2009 at 5:45 AM, Yanko Kaneti
<yaneti(a)declera.com>
wrote:
On Fri, 2009-06-26 at 11:58 +0200, Ralf Corsepius wrote:
> Tom Callaway wrote:
> > -%{perl_vendorlib}/*
> > +%{perl_vendorlib}/DBIx/Class/*
> > %{_mandir}/man3/*.3*
> >
> > %changelog
> > +* Fri Jun 26 2009 Tom "spot" Callaway
<tcallawa(a)redhat.com> 0.03-2
> > +- fix duplicate directory ownership (perl-DBIx-Class owns
%{perl_vendorlib}/DBIx/Class/)
>
> Tom, you are not fixing bugs your are breaking things!
>
> perl modules do not share a strict hierarchy, but are
independent packages!
What do you mean ? How DBI::Class::DynamicDefault is
independent of
DBI::Class ?
http://deps.cpantesters.org/?module=DBIx::Class::DynamicDefault;perl=latest
What Ralf is rather vigorously saying is that both by convention and
explicit guideline, due to the fluid nature of perl-* packages they're
supposed to own everything they provide under %{perl_vendorarch} or
%{perl_vendorlib}. Specifying ownership of a subset of that is
considered a blocker at review and a packaging bug post-review...
It's just a packging issue, it has nothing to do with the relationship
between DBIC and DBIC::DynamicDefault.
I read the guidelines again and think I understand what you mean.
I gotta say tho, whats written in the guidelines is not nearly explicit
enough to convey the message.
"there are several instances where it's desirable for multiple packages
to own a directory" desirable, really....
"perl packages are permitted to share ownership of directories."
permitted, how nice.
Its rather counter intuitive to the way that almost anything else works.
Unless there is a bold "must" somewhere there, and perhaps a rpmlint
warning I think this will come back again and again.
Cheers
Yanko
3:27 p.m.
On Fri, Jun 26, 2009 at 12:53 PM, Yanko Kaneti <yaneti(a)declera.com> wrote:
On Fri, 2009-06-26 at 11:08 -0700, Chris Weyl wrote:
> What Ralf is rather vigorously saying is that both by convention and
> explicit guideline, due to the fluid nature of perl-* packages they're
> supposed to own everything they provide under %{perl_vendorarch} or
> %{perl_vendorlib}. Specifying ownership of a subset of that is
> considered a blocker at review and a packaging bug post-review...
> It's just a packging issue, it has nothing to do with the relationship
> between DBIC and DBIC::DynamicDefault.
>
I read the guidelines again and think I understand what you mean.
I gotta say tho, whats written in the guidelines is not nearly explicit
enough to convey the message.
"there are several instances where it's desirable for multiple packages
to own a directory" desirable, really....
"perl packages are permitted to share ownership of directories."
permitted, how nice.
Its rather counter intuitive to the way that almost anything else works.
Unless there is a bold "must" somewhere there, and perhaps a rpmlint
warning I think this will come back again and again.
As it is right now :) (What is it the Cylons say? All this has happened
before, and all this will happen again?)
You're right in that It's not a listed as a must, but a should... Even
though it is enforced as a must through reviews and packaging bugs. It all
basically boils down to that a package providing "perl(DBIx::Class)"
doesn't
actually tell you exactly where DBIx/Class.pm is located, only that it's
somewhere under @INC.
There's actually a few things I'd like rpmlint to catch -- like, say,
provides being issued for shared libs not in traditional "system paths"
(/usr/lib, etc) -- but I'm not holding my breath for it.
-Chris
--
Chris Weyl
Ex astris, scientia
5473
days inactive
5473
days old
perl-devel@lists.fedoraproject.org
5 comments
4 participants
participants (4)
-
Chris Weyl -
Ralf Corsepius -
Tom Callaway -
Yanko Kaneti