#29: error route of tuned-adm profile if tuned isn't running -----------------------+----------------------- Reporter: moriwaka | Owner: Type: defect | Status: new Priority: major | Component: utilities Version: 2.0 | Keywords: Blocked By: | Blocking: -----------------------+----------------------- reproducer:

1. systemctl stop tuned.service 2. tuned-adm profile latency-performance

this shows two type of error.

case 1. invalid pid file ---------------------------- Traceback (most recent call last): File "/usr/sbin/tuned-adm", line 145, in <module> tuned_adm.run(args) File "/usr/sbin/tuned-adm", line 69, in run self.set_active_profile(args[1]) File "/usr/sbin/tuned-adm", line 129, in set_active_profile os.kill(pid, signal.SIGHUP) OSError: [Errno 3] No such process ----------------------------

case 2. no pid file (this caused if /var/run/tuned/tuned.pid isn't there) ----------------------------------------------------------- Cannot read /var/run/tuned/tuned.pid: [Errno 2] No such file or directory: '/var/run/tuned/tuned.pid' -----------------------------------------------------------

description: - case 1 can be problem if same pid is reused in other process than tuned. mix with https://bugzilla.redhat.com/show_bug.cgi?id=845336, this can be a security flaw. pid file should be removed when it found to be invalid. - case 2 is less problematic, but adding some advisory message is nice to have. "Please run tuned daemon to configure profile"