On Mon, Mar 18, 2013 at 10:37:01PM +0200, Yaniv Kaul wrote: Hi, I implemented this privately awhile ago. Took some time to port to 0.8.0, but you can try this patch to see if it is what you are looking for. The output could use suggestions. Cheers, Don ---------------8<---------------------- From: Don Zickus <dzickus(a)redhat.com&gt; Date: Wed, 14 Mar 2012 17:25:59 -0400 Subject: [PATCH] Add history command Something came up and I started hacking up the interface for the 'history' command. I decided to cleanup what I wrote and add it officially to the python-bugzilla project. What it does is simple, just display the change history of the bug id. This might not sound terribly useful, but it is just another little tool that the bugzilla app can use to extract yet more info from the bugzilla database. Signed-off-by: Don Zickus <dzickus(a)redhat.com&gt; --- bin/bugzilla | 37 ++++++++++++++++++++++++++++++++++++- bugzilla/base.py | 8 ++++++++ bugzilla/bugzilla3.py | 6 ++++++ 3 files changed, 50 insertions(+), 1 deletions(-) diff --git a/bin/bugzilla b/bin/bugzilla index 95fd747..670758c 100755 --- a/bin/bugzilla +++ b/bin/bugzilla @@ -32,7 +32,7 @@ if '--debug' in sys.argv: elif '--verbose' in sys.argv: log.setLevel(logging.INFO) -cmdlist = ['login','new','query','modify','attach','info'] +cmdlist = ['login','new','query','modify','attach','info','history'] def to_encoding(ustring): if isinstance(ustring, basestring): @@ -230,6 +230,9 @@ def setup_action_parser(action): elif action == 'login': p.set_usage('%prog login [username [password]]') p.set_description("Log into bugzilla and save a login cookie.") + elif action == 'history': + p.set_usage('%prog history BUGID [BUGID...]') + p.set_description("Prints out the change history of the bugzillas") if action in ['new','query']: # output modifiers @@ -697,6 +700,23 @@ def main(): if opt.fixed_in: data['fixed_in'] = opt.fixed_in bz._update_bugs(bugid_list, data) + elif action == 'history': + bugid_list = [] + for a in args: + if ',' in a: + for b in a.split(','): + bugid_list.append(b) + else: + bugid_list.append(a) + # surely there's a simpler way to do that.. + # bail out if no bugs were given + if not bugid_list: + parser.error('no bug ids given (maybe you forgot an argument somewhere?)') + # iterate over a list of bug objects + buglist = bz.history(bugid_list) + if not buglist: + parser.error('no bugs were found. check your bug ids.') + else: print "Sorry - '%s' not implemented yet." % action @@ -793,6 +813,21 @@ def main(): else: parser.error("opt.output was set to something weird.") + elif action == 'history': + #mimic the bugzilla webpage output + for bug in buglist: + print "Bugzilla %s" % bug.bug_id + print "%-20s %-20s %-20s %-20s %-20s" % ("Who", "When", "What", "Removed", "Added") + for h in bug.history: + who=h['who'] + when=h['when'] + changes = h['changes'] + for c in changes: + print "%-20s %-20s %-20s %-20s %-20s" %(who, when, c['field_name'], c['removed'], c['added']) + who="" + when="" + print + if __name__ == '__main__': try: if '--generate-man' in sys.argv: diff --git a/bugzilla/base.py b/bugzilla/base.py index f4707e0..7adb175 100644 --- a/bugzilla/base.py +++ b/bugzilla/base.py @@ -499,6 +499,10 @@ class BugzillaBase(object): def _query(self,query): '''IMPLEMENT ME: Query bugzilla and return a list of matching bugs.''' raise NotImplementedError + def _history(self,idlist): + '''IMPLEMENT ME: Return a list of full bug dicts, one for each of the + given bug ids''' + raise NotImplementedError # these return Bug objects def getbug(self,id): @@ -543,6 +547,10 @@ class BugzillaBase(object): 'long_desc':string,'long_desc_type':matchtype} return self.query(q) + def history(self,idlist): + '''Return a list of Bug objects with the history of changes for those + Bug objects''' + return [(b and _Bug(bugzilla=self,dict=b)) or None for b in self._history(idlist)] #---- Methods for modifying existing bugs. # Most of these will probably also be available as Bug methods, e.g.: diff --git a/bugzilla/bugzilla3.py b/bugzilla/bugzilla3.py index ef25278..4a0272b 100644 --- a/bugzilla/bugzilla3.py +++ b/bugzilla/bugzilla3.py @@ -176,6 +176,12 @@ class Bugzilla34(Bugzilla32): ''' return self._proxy.Bug.search(query) + def _history(self,idlist): + '''Get the change history of a list of bugs + ''' + buglist = self._proxy.Bug.history({'ids':idlist}) + return buglist['bugs'] + # Bugzilla 3.6 was released April 13, 2010 # XXX TODO probably more new methods from Bugzilla 3.6 we could use class Bugzilla36(Bugzilla34): -- 1.7.7.6

On Mon, Mar 25, 2013 at 04:37:14PM -0400, Cole Robinson wrote: Grr. I suck. I sent my original patch from last year. Here is the one that I tested on top of 0.8.0 from last week. My apologies for that. Cheers, Don ---------------8<------------ From: Don Zickus <dzickus(a)redhat.com&gt; Date: Fri, 22 Mar 2013 15:19:02 -0400 Subject: [PATCH] bugzilla: New command 'history' This patch just adds supports for reviewing the history of bugzillas. I hacked up most of this patch a while ago for some other reason. I spent an hour this morning migrating it to 0.8.0. The data is valid, but the output display could probably use some suggestions. For now I stuck with something that mimic'd what the web GUI would show. Most of the work is done on the front end bugzilla CLI. A couple of output format hacks added because I didn't know the right way to hook things in. The backend has a little tweak because the data returned from the server needs to be dereferenced correctly (for b in r['bugs']) like every other RPC call to the server. Signed-off-by: Don Zickus <dzickus(a)redhat.com&gt; --- bin/bugzilla | 43 +++++++++++++++++++++++++++++++++++++++++-- bugzilla/base.py | 3 ++- 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/bin/bugzilla b/bin/bugzilla index 881c44e..67c8960 100755 --- a/bin/bugzilla +++ b/bin/bugzilla @@ -27,7 +27,7 @@ import bugzilla default_bz = 'https://bugzilla.redhat.com/xmlrpc.cgi' _is_unittest = bool(os.getenv("__BUGZILLA_UNITTEST")) -cmdlist = ['login', 'new', 'query', 'modify', 'attach', 'info'] +cmdlist = ['login', 'new', 'query', 'modify', 'attach', 'info', 'history'] format_field_re = re.compile("%{([a-z0-9_]+)(?::([^}]*))?}") log = bugzilla.log @@ -309,6 +309,10 @@ def setup_action_parser(action): p.set_usage('%prog login [username [password]]') p.set_description("Log into bugzilla and save a login cookie.") + elif action == 'history': + p.set_usage('%prog history BUGID [BUGID...]') + p.set_description("Prints out the change history of the bugzillas") + if action in ['new', 'query']: outg = optparse.OptionGroup(p, "Output format options") outg.add_option('-f', '--full', action='store_const', dest='output', @@ -619,6 +623,11 @@ def _convert_to_outputformat(output): fmt += "#%{bug_id} %{status} %{assigned_to} %{component}\t" fmt += "[%{target_milestone}] %{flags} %{cve}" + elif output == 'history': + fmt += "Bugzilla %{bug_id}\n" + fmt += "%-20s %-20s %-20s %-20s %-20s\n" % ("Who", "When", "What", "Removed", "Added") + fmt += "%{history}" + else: raise RuntimeError("Unknown output type '%s'" % opt.output) @@ -674,6 +683,20 @@ def _format_output(bz, opt, buglist): val += ("\n* %s - %s:\n%s\n" % (c['time'], c['author'], c['text'])) + elif fieldname == "history": + val = "" + for h in getattr(b, "history", []): + who = h['who'] + when = h['when'] + changes = h['changes'] + for c in changes: + val += ("%-20s %-20s %-20s %-20s %-20s\n\n" % (who, when, + c['field_name'], c['removed'], c['added'])) + + #make it obvious when multiple changes happened at once + who = "" + when = "" + elif fieldname == "__unicode__": val = unicode(b) else: @@ -845,6 +868,11 @@ def _do_set_attach(bz, opt, parser, args): attid = bz.attachfile(bugid, fileobj, desc, **kwargs) print "Created attachment %i on bug %s" % (attid, bugid) +def _do_history(bz, opt, args): + bugid_list = reduce(lambda l1, l2: l1 + l2, + [a.split(",") for a in args]) + + return bz.bugs_history(bugid_list) ################# # Main function # @@ -992,11 +1020,22 @@ def main(bzinstance=None): _do_modify(bz, opt, args) + elif action == 'history': + if not args: + parser.error('No bug IDs given ' + '(maybe you forgot an argument somewhere?)') + + #opt hacks + opt.output = "" + opt.outputformat = _convert_to_outputformat('history') + newbugs = _do_history(bz, opt, args) + buglist += newbugs + else: raise RuntimeError("Unexpected action '%s'" % action) # If we're doing new/query/modify, output our results - if action in ['new', 'query']: + if action in ['new', 'query', 'history']: _format_output(bz, opt, buglist) diff --git a/bugzilla/base.py b/bugzilla/base.py index c2b9295..31b668c 100644 --- a/bugzilla/base.py +++ b/bugzilla/base.py @@ -830,7 +830,8 @@ class BugzillaBase(object): Experimental. Gets the history of changes for particular bugs in the database. ''' - return self._proxy.Bug.history({'ids': bug_ids}) + r = self._proxy.Bug.history({'ids': bug_ids}) + return [_Bug(bugzilla=self, dict=b) for b in r['bugs']] ####################################### # Methods for modifying existing bugs # -- 1.7.1

On Mon, Mar 25, 2013 at 05:46:34PM -0400, Cole Robinson wrote: Ok. Ok. Yeah, I wasn't sure how you wanted this hooked in properly. Ok. Well the thing is this API is not consistent with the other calls which return an array of bzs. Here you have to de-reference the object r['bugs'] and the returned object is not part of the _Bug object. Which means referencing the data beneath it is different than the other objects. So I would argue to bit the bullet now while no one is using it and fix the API to be consistent with the rest of the APIs. In addition, a lot of us don't use bin/bugzilla, instead we have our own scripts that reference the python library and expect returned data to be in a certain format for parsing. Anyway, it's up to you. Just wanted to point out my reason. :-) Cheers, Don