Re: Help for package review
On 12.7.2017 10:41, Germano Massullo wrote:
Hi there, I am doing the review of
https://bugzilla.redhat.com/show_bug.cgi?id=1189171
but I am experiencing some difficulties in understanding line
%{__python} setup.py install -O1 --skip-build --root %{buildroot}
I haven't find any trace of such flags in setup.py file.
The setup.py doesn't define any flags. They are all brought by setuptools.
On Fedora, we use the %py2_install macro that evaluates to:
CFLAGS="%{optflags}" %{__python2} setup.py install -O1 --skip-build
--root %{buildroot}
Which is almost what you have there. The line is theoretically fine.
However, the %py2_install macro is also defined in EPEL 6, so it should
be preferred. Will comment on the review.
Have a nice day
_______________________________________________
python-devel mailing list -- python-devel(a)lists.fedoraproject.org
To unsubscribe send an email to python-devel-leave(a)lists.fedoraproject.org
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok